From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0683A496D45 for ; Sat, 10 Oct 2026 11:56:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791633367; cv=none; b=iBZC+VJ8NziaaWbxXZMJTrBsfkaaU5k5NHLdC8Ra8uafxo3h8TJEgRa0nqiyVJxpmQZy7XtPUZh9mHwrnqhYc6JLHfWggNGdN2rG9GLwLePJ6XTq+9De4xoaftvxXag2E7AFI8NRiJ9hheGaGuwCVmsCm3jN7+ZwiIiaeDjGa6s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791633367; c=relaxed/simple; bh=R9jduDBNkrUI4Ytp4d+BkWD4r0GbRTA682YKtlbMYd0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=edBl9XkxMF6znIScCFNjaMvJ/K5HYKq/XmQaObDSwPVurZvAUGNcOYLqjNXgvQ9HA+OlGCNCrsKcCs45yr+ub/1lMbiszwgl4Z1/yXz68zX8BdmgsTeowt1SMpYkzx3rD5SkvdTBmRiES4/7/SIImiHQiV+6uCRPUArSi14FLlQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CM9SymQC; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CM9SymQC" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-48b03f23305so443979f8f.1 for ; Sat, 10 Oct 2026 04:56:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791633361; x=1792238161; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=RPzRZvC6M3eYrQVDkjYe0kKV8YaVNewsubnx0uw/yuw=; b=CM9SymQCPjpuB/uy//d4QH8tZKx3scvoSVsls4CbuFwAXcu+ROF9w7TLoWbXxn3MnT ytxdhP38ZzjGfFjx3ZOFogizxpdJTXZZ4RVd1JUhoVj1gqye/MT6ELHKNdkOHjDpGE/I RQKW9IPBacEMRYCU7Ja3zzhtsDLgTYq1HjufOrRRKanS5Mt3v3JXVr25SbWWO2yCx+Wl ZU11weVxFNMlSjuj9NsjVAGNqB6wso/JvVbDYOQtvJVuQi68jHwjZrELdrxbaGDvGdqe jPHPlAOCTQLVaJVxv0MFX4yZ4/vyzaIAKo3DhTPZRK5WvbORzjPyHFcacJnMcPiEGLyk OPLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791633361; x=1792238161; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=RPzRZvC6M3eYrQVDkjYe0kKV8YaVNewsubnx0uw/yuw=; b=KjDhjhQcOZljPpVF3l3FBZAlzzKW1hlMYN9v4T1X/C7uFneEPqg6kyVOmmqedSkDDu 88K7TS3A46rVAvzcOy1g6eFALwfzqbcfzTKoqaLGzdBJLgbIdMrNWxcudQrAdFXmJb1r NJrqJnuBU0VZJDJa5FO3s0jgezZtyZ6iIRYjCsZGZRlX2dzEUwF/Rmpa5Y/LAShFkBW5 Krp0dNZIbqhB51jn+2mtDdkWwwlLf/1J1zGTj0kzDo/Y8sjcWJokKg1NiVLVsa1tSjNV gDSHEtTpzeS1IZ/GiPxtbmvsAQbeeeSzggSgEjsaQJQZbdkOAq8xYlOQ33zORzFIxJWn fH9A== X-Forwarded-Encrypted: i=1; AKwUvBwtrJ2O4xe3OBwdsvzoSzWdc+cNTMt9GT1oPMqpLby2jngdDicZgy/RnW8ILHLKAr9sRnN8CjfS6smS0Fw=@vger.kernel.org X-Gm-Message-State: AFq9FYIuj1ewN13SQWgA7fhIY/Q+ajPn3TXu4kYivuS0VRIt/vCg6S5X d0Y1FvXeyKQG6Xo6XFWAgWk0u0mqlTe4Mc4ItTWEAkuxSA0eSg3ufXpd X-Gm-Gg: AYBFou0RWTA6DROt9ouWZXnBo6QyBAmNcKQg+OStCGdTEqzcs13Sx1THU1RW+2ZVClW uR7heIgxvmZchc5pDy0TzIrCcr9sKeaXcQwWCNZ0Z6bxlOa83Pp5xG3g17wh0bwKibEgbkxXSoB eEEJdvU9V4HgCLieTchSMjkC1/jBdmEdAu70ohWGN6IrKO8M1jKe+uGoqc1lDBHwN8WlTnWoepV a3JDMG7bx43+KKEcRTkkcuyGyTWBZNhfoNpZas69Y5Sdfu6tzS60QFY2iCrNkPSjhszpTPZs2lJ OosLKHsukEx71PSsisIDytUrC3Q+rgqxlA57FpuUsIpgagfQO6H+BW1wfIF9x+W/MTG0cdo5DQ8 L1bMY9oz0oXgB/DMgW8qvdOBLqIe8oAIYZ7joRnhfjeBtf7XTuppah80NKlYcI2VcDVItW0aWaD X04DSkbRcm+9ju8k9jXKTkQNfCLmaWKoAZqE9aS3okDxH78n8hT6p0OlUVPhfR64P9WQ== X-Received: by 2002:a05:6000:4310:b0:48a:f1fb:e165 with SMTP id ffacd0b85a97d-48dbaae39e0mr7896198f8f.21.1791633360918; Sat, 10 Oct 2026 04:56:00 -0700 (PDT) Received: from luca-vm.lan ([154.61.61.58]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48db9aca657sm8746340f8f.43.2026.10.10.04.55.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Oct 2026 04:56:00 -0700 (PDT) From: Luca Leonardo Scorcia To: linux-mediatek@lists.infradead.org Cc: Luca Leonardo Scorcia , Chunfeng Yun , Vinod Koul , Neil Armstrong , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Stephen Boyd , Brian Masney , Jerome Brunet , Chun-Kuang Hu , Philipp Zabel , David Airlie , Simona Vetter , Nicolas Frattaroli , Chen-Yu Tsai , Fabien Parent , CK Hu , chunhui dai , linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH 3/7] clk: mediatek: mt8167: Map apmixedsys iomem as shared Date: Sat, 10 Oct 2026 13:54:03 +0200 Message-ID: <20261010115539.9237-4-l.scorcia@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261010115539.9237-1-l.scorcia@gmail.com> References: <20261010115539.9237-1-l.scorcia@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The hdmi_phy for mt8167 and the apmixedsys clocks share the same IO memory region and they both map it using devm_platform_ioremap_resource, which implies exclusive access. Switch the apmixedsys driver to of_iomap, like it is done in the mt8173-apmixedsys driver. Also, implement the remove function while we're at it. Fixes the following runtime error: hdmi-phy: error -EBUSY: can't request region for resource [mem 0x10018300-0x1001831f] Signed-off-by: Luca Leonardo Scorcia --- drivers/clk/mediatek/clk-mt8167-apmixedsys.c | 24 ++++++++++++++++---- 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/drivers/clk/mediatek/clk-mt8167-apmixedsys.c b/drivers/clk/mediatek/clk-mt8167-apmixedsys.c index fb6c21bbeef8..3e8611991de7 100644 --- a/drivers/clk/mediatek/clk-mt8167-apmixedsys.c +++ b/drivers/clk/mediatek/clk-mt8167-apmixedsys.c @@ -8,6 +8,7 @@ #include #include #include +#include #include #include "clk-pll.h" @@ -97,17 +98,19 @@ static int clk_mt8167_apmixed_probe(struct platform_device *pdev) struct device *dev = &pdev->dev; int ret; - base = devm_platform_ioremap_resource(pdev, 0); + base = of_iomap(node, 0); if (IS_ERR(base)) return PTR_ERR(base); clk_data = mtk_devm_alloc_clk_data(dev, MT8167_CLK_APMIXED_NR_CLK); - if (!clk_data) - return -ENOMEM; + if (IS_ERR_OR_NULL(clk_data)) { + ret = -ENOMEM; + goto unmap_io; + } ret = mtk_clk_register_plls(dev, plls, ARRAY_SIZE(plls), clk_data); if (ret) - return ret; + goto unmap_io; ret = mtk_clk_register_dividers(dev, adj_divs, ARRAY_SIZE(adj_divs), base, &mt8167_apmixed_clk_lock, clk_data); @@ -124,10 +127,22 @@ static int clk_mt8167_apmixed_probe(struct platform_device *pdev) mtk_clk_unregister_dividers(adj_divs, ARRAY_SIZE(adj_divs), clk_data); unregister_plls: mtk_clk_unregister_plls(plls, ARRAY_SIZE(plls), clk_data); +unmap_io: + iounmap(base); return ret; } +static void clk_mt8167_apmixed_remove(struct platform_device *pdev) +{ + struct device_node *node = pdev->dev.of_node; + struct clk_hw_onecell_data *clk_data = platform_get_drvdata(pdev); + + of_clk_del_provider(node); + mtk_clk_unregister_dividers(adj_divs, ARRAY_SIZE(adj_divs), clk_data); + mtk_clk_unregister_plls(plls, ARRAY_SIZE(plls), clk_data); +} + static const struct of_device_id of_match_clk_mt8167_apmixed[] = { { .compatible = "mediatek,mt8167-apmixedsys" }, { /* sentinel */ } @@ -136,6 +151,7 @@ MODULE_DEVICE_TABLE(of, of_match_clk_mt8167_apmixed); static struct platform_driver clk_mt8167_apmixed_drv = { .probe = clk_mt8167_apmixed_probe, + .remove = clk_mt8167_apmixed_remove, .driver = { .name = "clk-mt8167-apmixed", .of_match_table = of_match_clk_mt8167_apmixed, -- 2.43.0