From: Andrew Morton <akpm@linux-foundation.org>
To: Nicolas Schier <nsc@kernel.org>
Cc: Jim Cromie <jim.cromie@gmail.com>,
Nathan Chancellor <nathan@kernel.org>,
Denis Benato <denis.benato@linux.dev>,
linux-kbuild@vger.kernel.org, thomas.weissschuh@linutronix.de,
chewi@gentoo.org, abelvesa@kernel.org,
linux-kernel@vger.kernel.org, Kees Cook <kees@kernel.org>
Subject: Re: [PATCH] kallsyms: copy constants from __KERNEL__ to user, drop the inclusion
Date: Sat, 10 Oct 2026 16:34:25 -0700 [thread overview]
Message-ID: <20261010163425.b291248543a3423e2a445e14@linux-foundation.org> (raw)
In-Reply-To: <179157208243.362135.3553274020133646760.b4-review@b4>
On Fri, 09 Oct 2026 20:54:42 +0200 Nicolas Schier <nsc@kernel.org> wrote:
> > commit 4fafd1165b33 replaced hardcoded values which determine marker
> > array size, with new values that accelerate symbol-name lookups.
> > These symbols are needed in user-space to generate the lookup tables,
> > and in kernel to read the generated table.
> >
> > To avoid 2-defns problem, they were added to a kernel header (with
> > ifdef guards) and included by scripts/kallsyms.c. But that creates
> > packaging problems elsewhere, so just add the 2nd defns, with an
> > explicit comment about the user-kernel coupling.
> >
> > Fixes: 4fafd1165b33 ("kallsyms: increase marker density to 16:1 to accelerate lookups")
> >
> > Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
> > ---
Thanks, I added this as a to-be-squashed-later fix against "kallsyms:
increase marker density to 16:1 to accelerate lookups".
btw, I have recorded some question marks about this series:
https://lore.kernel.org/20260929221330.72cd1de4@pumpkin
https://lore.kernel.org/20260930132109.260597-1-david.laight.linux@gmail.com
https://lore.kernel.org/20260930101307.4477e264@pumpkin
and I'd like to get those crossed off before proceeding.
> FTR: Please keep trailers in a single trailer block, otherwise that will
> probably break some common tooling (cp. e.g. git-interpret-trailers).
>
> Is the commit ID correct? In mm-nonmm-unstable I find
> e2c2904abf71d0144f37844fde7dffe8b814a44f instead.
mm-unstable is "unstable". It rebases more than once per day so lookup
by hash doesn't work.
git log --oneline | grep "kallsyms increase marker density to 16:1 to accelerate lookups"
works for me.
prev parent reply other threads:[~2026-10-10 23:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 23:19 Jim Cromie via B4 Relay
2026-10-09 18:54 ` Nicolas Schier
2026-10-10 23:34 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261010163425.b291248543a3423e2a445e14@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=abelvesa@kernel.org \
--cc=chewi@gentoo.org \
--cc=denis.benato@linux.dev \
--cc=jim.cromie@gmail.com \
--cc=kees@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=nsc@kernel.org \
--cc=thomas.weissschuh@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®