From: Karlos Abel <kabel@voidship.net>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
sashiko-bot@kernel.org
Subject: [PATCH v2 0/2] Input: discard pre-registration events and test state seeding
Date: Sat, 10 Oct 2026 15:10:31 -0400 [thread overview]
Message-ID: <20261010191033.23577-1-kabel@voidship.net> (raw)
This series prevents input handlers from receiving buffered initialization
events after device registration. On a ThinkPad T14 Gen 6, a later LED
update flushed a stale SW_RFKILL_ALL event seeded by thinkpad_acpi.
The fix drops the pending events and their timestamp before handlers
attach, while retaining the seeded switch and absolute-axis state.
Patch 1 contains the six-line runtime fix. Patch 2 adds KUnit coverage for
registration with and without event-buffer resizing. The test uses a
virtual SW_DOCK device and performs no real radio operations.
Tested on mainline 3857c2fe5449541e24afc5efdb0f81a8a8f9a3a0 (7.3.0-rc6):
- Tests alone on the unmodified input core: four pass, two fail.
The non-resizing case replays one stale switch event; both cases
retain the initialization timestamp.
- Patch 1 alone: all four existing input-core tests pass.
- Both patches: all six input-core tests pass.
Both source commits were built and tested under UML without compiler
warnings. The revised tests repeat the same failing/passing comparison.
The same runtime fix was also tested with QEMU/KVM on Arch 7.2.7 and on
the ThinkPad.
AI assistance: OpenAI Codex assisted source analysis, the fix, regression
tests and this text. The submitter performed the physical hardware
comparisons.
Previous version:
Message-ID: <20261010180031.7-1-kabel@voidship.net>
Review addressed:
Message-ID: <sashiko-outbox-166792@kernel.org>
Changes in v2:
- Patch 1 is unchanged.
- Patch 2 checks absinfo allocation before event seeding and unregisters
its handler before its device, addressing Sashiko's review of v1.
- Forced allocation failure now reaches the explicit check and cleanup.
A forced teardown interleaving reproduced unintended binding after
actual allocator address reuse; handler-first cleanup prevents it.
Karlos Abel (2):
Input: discard pre-registration events before attaching handlers
Input: test state seeding across device registration
drivers/input/input.c | 6 ++
drivers/input/tests/input_test.c | 171 +++++++++++++++++++++++++++++++
2 files changed, 177 insertions(+)
base-commit: 3857c2fe5449541e24afc5efdb0f81a8a8f9a3a0
next reply other threads:[~2026-10-10 19:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-10 19:10 Karlos Abel [this message]
2026-10-10 19:10 ` [PATCH v2 1/2] Input: discard pre-registration events before attaching handlers Karlos Abel
2026-10-10 19:10 ` [PATCH v2 2/2] Input: test state seeding across device registration Karlos Abel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261010191033.23577-1-kabel@voidship.net \
--to=kabel@voidship.net \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sashiko-bot@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®