From: Mohamad Raizudeen <raizudeen.kerneldev@gmail.com>
To: ebiggers@kernel.org, ardb@kernel.org, Jason@zx2c4.com
Cc: skhan@linuxfoundation.org, me@brighamcampbell.com,
jkoolstra@xs4all.nl, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org,
Mohamad Raizudeen <raizudeen.kerneldev@gmail.com>
Subject: [PATCH] lib/crypto: sha1: use put_unaligned_be64() for length encoding
Date: Sun, 11 Oct 2026 10:45:24 +0530 [thread overview]
Message-ID: <20261011051524.6703-1-raizudeen.kerneldev@gmail.com> (raw)
The SHA1 final code in __sha1_final() and hmac_sha1_final() writes the
64-bit message bit length of the SHA1 padding using direct access
pointer casts:
`*(__be64 *)&ctx->buf[SHA1_BLOCK_SIZE - 8] = cpu_to_be64(bitcount);`
`*(__be32 *)&ctx->sha_ctx.buf[SHA1_BLOCK_SIZE - 4] =
cpu_to_be32(8 * (SHA1_BLOCK_SIZE + SHA1_DIGEST_SIZE));`
The rest of this file already uses the unaligned access helpers like
get_unaligned_be32() for reading input and put_unaligned_be32() for writing
the digest, for all structured buffer accesses. Replace both casts with
put_unaligned_be64() for consistency.
In hmac_sha1_final(), this also writes the full 64-bit length field
explicitly rather than writing only 32 bits and relying on a preceding
memset() to zero the upper 32 bits. The resulting bytes are identical,
nothing changes functionally.
Signed-off-by: Mohamad Raizudeen <raizudeen.kerneldev@gmail.com>
---
lib/crypto/sha1.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/crypto/sha1.c b/lib/crypto/sha1.c
index b687b89d97cb..17d97160d578 100644
--- a/lib/crypto/sha1.c
+++ b/lib/crypto/sha1.c
@@ -183,7 +183,7 @@ static void __sha1_final(struct sha1_ctx *ctx, u8 out[SHA1_DIGEST_SIZE])
partial = 0;
}
memset(&ctx->buf[partial], 0, SHA1_BLOCK_SIZE - 8 - partial);
- *(__be64 *)&ctx->buf[SHA1_BLOCK_SIZE - 8] = cpu_to_be64(bitcount);
+ put_unaligned_be64(bitcount, &ctx->buf[SHA1_BLOCK_SIZE - 8]);
sha1_blocks(&ctx->state, ctx->buf, 1);
for (size_t i = 0; i < SHA1_DIGEST_SIZE; i += 4)
@@ -267,8 +267,8 @@ void hmac_sha1_final(struct hmac_sha1_ctx *ctx, u8 out[SHA1_DIGEST_SIZE])
memset(&ctx->sha_ctx.buf[SHA1_DIGEST_SIZE], 0,
SHA1_BLOCK_SIZE - SHA1_DIGEST_SIZE);
ctx->sha_ctx.buf[SHA1_DIGEST_SIZE] = 0x80;
- *(__be32 *)&ctx->sha_ctx.buf[SHA1_BLOCK_SIZE - 4] =
- cpu_to_be32(8 * (SHA1_BLOCK_SIZE + SHA1_DIGEST_SIZE));
+ put_unaligned_be64((u64)8 * (SHA1_BLOCK_SIZE + SHA1_DIGEST_SIZE),
+ &ctx->sha_ctx.buf[SHA1_BLOCK_SIZE - 8]);
/* Compute the outer hash, which gives the HMAC value. */
sha1_blocks(&ctx->ostate, ctx->sha_ctx.buf, 1);
--
2.53.0
next reply other threads:[~2026-10-11 5:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-11 5:15 Mohamad Raizudeen [this message]
2026-10-11 6:10 ` Simon Richter
2026-10-11 9:14 ` Mohamad Raizudeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261011051524.6703-1-raizudeen.kerneldev@gmail.com \
--to=raizudeen.kerneldev@gmail.com \
--cc=Jason@zx2c4.com \
--cc=ardb@kernel.org \
--cc=ebiggers@kernel.org \
--cc=jkoolstra@xs4all.nl \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@brighamcampbell.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®