mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrei-Alexandru Bleortu <me@andrei-z.com>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
	Marcel Holtmann <marcel@holtmann.org>
Cc: <linux-bluetooth@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	George Moussalem <george.moussalem@outlook.com>,
	<linux-arm-msm@vger.kernel.org>
Subject: [PATCH 2/3] Bluetooth: btqcomipc: deassert the BTSS reset before enabling its clock
Date: Mon, 12 Oct 2026 01:09:18 +0300	[thread overview]
Message-ID: <20261011220919.1816407-3-me@andrei-z.com> (raw)
In-Reply-To: <20261011220919.1816407-1-me@andrei-z.com>

An unbind asserts the BTSS reset through devres, and a later probe then
enabled the LPO branch clock with the subsystem still in reset:
"gcc_btss_lpo_clk status stuck at 'off'" and the probe failed with
-EBUSY. Deassert the reset first; devres then also undoes them in the
right order (clock off, then reset).

Assisted-by: LLM
Signed-off-by: Andrei-Alexandru Bleortu <me@andrei-z.com>
---
 drivers/bluetooth/btqcomipc.c | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/drivers/bluetooth/btqcomipc.c b/drivers/bluetooth/btqcomipc.c
index 21dd3e812..8513c1780 100644
--- a/drivers/bluetooth/btqcomipc.c
+++ b/drivers/bluetooth/btqcomipc.c
@@ -1147,16 +1147,20 @@ static int btqcomipc_probe(struct platform_device *pdev)
 
 	of_node_put(ipc_np);
 
-	lpo_clk = devm_clk_get_enabled(dev, "lpo");
-	if (IS_ERR(lpo_clk))
-		return dev_err_probe(dev, PTR_ERR(lpo_clk),
-				     "Failed to get lpo clock\n");
-
+	/*
+	 * The LPO branch clock cannot turn on while the subsystem is held
+	 * in reset, which is how an unbind leaves it: deassert first.
+	 */
 	btss_reset = devm_reset_control_get_exclusive_deasserted(dev, NULL);
 	if (IS_ERR_OR_NULL(btss_reset))
 		return dev_err_probe(dev, PTR_ERR(btss_reset),
 				     "unable to deassert reset\n");
 
+	lpo_clk = devm_clk_get_enabled(dev, "lpo");
+	if (IS_ERR(lpo_clk))
+		return dev_err_probe(dev, PTR_ERR(lpo_clk),
+				     "Failed to get lpo clock\n");
+
 	desc->irq = platform_get_irq(pdev, 0);
 	if (desc->irq < 0)
 		return dev_err_probe(dev, desc->irq, "Failed to acquire IRQ\n");


  parent reply	other threads:[~2026-10-11 22:11 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-09  9:18 [PATCH v5 0/6] Add support for IPQ5018 Bluetooth George Moussalem via B4 Relay
2026-07-09  9:18 ` [PATCH v5 1/6] dt-bindings: net: bluetooth: Document Qualcomm IPQ5018 Bluetooth controller George Moussalem via B4 Relay
2026-07-09  9:18 ` [PATCH v5 2/6] Bluetooth: btqca: Add IPQ5018 support George Moussalem via B4 Relay
2026-07-09  9:18 ` [PATCH v5 3/6] firmware: qcom: scm: Add support for setting Bluetooth power modes George Moussalem via B4 Relay
2026-07-09  9:18 ` [PATCH v5 4/6] Bluetooth: Introduce Qualcomm IPQ5018 IPC based HCI driver George Moussalem via B4 Relay
2026-10-11 22:09   ` [PATCH 0/3] Bluetooth: btqcomipc: fixes on top of the IPQ5018 v5 series Andrei-Alexandru Bleortu
2026-10-11 22:09     ` [PATCH 1/3] Bluetooth: btqcomipc: keep the dot in split firmware segment names Andrei-Alexandru Bleortu
2026-10-11 22:09     ` Andrei-Alexandru Bleortu [this message]
2026-10-11 22:09     ` [PATCH 3/3] Bluetooth: btqcomipc: take the board's address from the host Andrei-Alexandru Bleortu
2026-07-09  9:18 ` [PATCH v5 5/6] arm64: dts: qcom: ipq5018: add node required for Bluetooth support George Moussalem via B4 Relay
2026-07-09 18:16   ` Konrad Dybcio
2026-07-09 18:23     ` George Moussalem
2026-07-09 18:17   ` Konrad Dybcio
2026-07-09 18:25     ` George Moussalem
2026-07-09 18:40       ` Konrad Dybcio
2026-07-10  9:14         ` Bartosz Golaszewski
2026-07-10  9:23           ` Konrad Dybcio
2026-07-10  9:32             ` George Moussalem
2026-07-09  9:18 ` [PATCH v5 6/6] MAINTAINERS: Add IPQ5018 driver to Qualcomm Bluetooth driver entry George Moussalem via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261011220919.1816407-3-me@andrei-z.com \
    --to=me@andrei-z.com \
    --cc=george.moussalem@outlook.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®