From: Sasha Levin <sashal@kernel.org>
To: Shuah Khan <shuah@kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Cc: Sasha Levin <sashal@kernel.org>,
stable@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] selftests/thermal/intel: don't fail to build when cross compiling
Date: Sun, 11 Oct 2026 18:33:43 -0400 [thread overview]
Message-ID: <20261011223358.2327625-15-sashal@kernel.org> (raw)
The power_floor and workload_hint Makefiles include lib.mk only for
native x86 builds. With CROSS_COMPILE set, or for other architectures,
the Makefile defines no targets at all and the build fails:
make: *** No targets. Stop.
Include lib.mk unconditionally, so that those builds have nothing to do
instead of failing. Native x86 builds are unchanged.
Fixes: 27801542b2b81 ("selftests/thermel/intel: Add test to read workload hint")
Fixes: d4d27e5a1a88f ("selftests/thermel/intel: Add test to read power floor status")
Cc: stable@vger.kernel.org
Assisted-by: LLM
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
tools/testing/selftests/thermal/intel/power_floor/Makefile | 5 ++---
tools/testing/selftests/thermal/intel/workload_hint/Makefile | 5 ++---
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/tools/testing/selftests/thermal/intel/power_floor/Makefile b/tools/testing/selftests/thermal/intel/power_floor/Makefile
index 07463c2160e09..12697c717881d 100644
--- a/tools/testing/selftests/thermal/intel/power_floor/Makefile
+++ b/tools/testing/selftests/thermal/intel/power_floor/Makefile
@@ -5,8 +5,7 @@ override ARCH := $(shell echo $(ARCH) | sed -e s/i.86/x86/ -e s/x86_64/x86/)
ifeq ($(ARCH),x86)
TEST_GEN_PROGS := power_floor_test
-
-include ../../../lib.mk
-
endif
endif
+
+include ../../../lib.mk
diff --git a/tools/testing/selftests/thermal/intel/workload_hint/Makefile b/tools/testing/selftests/thermal/intel/workload_hint/Makefile
index 49e3bc2b20f9d..7f4cdbaf7452c 100644
--- a/tools/testing/selftests/thermal/intel/workload_hint/Makefile
+++ b/tools/testing/selftests/thermal/intel/workload_hint/Makefile
@@ -5,8 +5,7 @@ override ARCH := $(shell echo $(ARCH) | sed -e s/i.86/x86/ -e s/x86_64/x86/)
ifeq ($(ARCH),x86)
TEST_GEN_PROGS := workload_hint_test
-
-include ../../../lib.mk
-
endif
endif
+
+include ../../../lib.mk
--
2.53.0
reply other threads:[~2026-10-11 22:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261011223358.2327625-15-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=shuah@kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®