From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0736A47DFB2; Tue, 13 Oct 2026 02:36:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791859001; cv=none; b=lGU0NP+m9KfQQUCCB1WwWTxJ0Ju7ULaoPYM+TLV5cfu7LlZAEIeEkypGV9SMSn1oXiRJ30zRbtWGvfGEn2eyWj9V/v45LyCHMyxp4NFIqPjhPwOiQZTZlGbLbCXxjJPmy7I6jUKHGfNgYaMkN/kW0lICwqlPTH82l0ysEjwzTjo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791859001; c=relaxed/simple; bh=vVk7Tt2qeM/4dyRuVq2mcFwTYh/CB+Y70GzrunHOgUs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UbW6Gdt0lnUbmBx5794qQ2PX2FBIvGmz4Er3mgtBP9Hf3D/1P9vhT1Z6z/kzfr83KU7DlXU7Dct90DC3fMZoBHRKZvG7TklZvl1CTD9KHQIcALz9J6JJdq5fL8PxNmr4OlIDqvsemBtzey/4/h5DHK8Q1NqkoFgXHsBHfNxqEz0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ADeCo+mk; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ADeCo+mk" Received: by smtp.kernel.org (Postfix) with ESMTPS id CF792C2BD01; Tue, 13 Oct 2026 02:36:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1791859000; bh=vVk7Tt2qeM/4dyRuVq2mcFwTYh/CB+Y70GzrunHOgUs=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=ADeCo+mkiQBR1sOmwLPNr4r+EmHH3R1382Vq8qpJDHEj+WOfir11FPE3leWeU/TBd t4AkBb3NZFqdmjTRuGlFlyIeldO2vav6BT80GFF5g8+JzRPgwqPWTJul5MGcq5XAAb zR0zeEUH2lleenPJ2CgxrGWRbW9vgWWDQXelNXCmv/0QKjW+BDwWnd2VWFcaZ/FOQr ZL1U8PJ7PMKH1qj+D2GSZ0beCQYOSIqw28EOFQUjd6yNXBgPPDR1zlzcU/gPhvbkQp BaM0m9GXewqVhBG69+FFbBWNCQudVSeT1Lxht1L8NeZd2hu24Ly/odUEBRqfiZu/ly JSiZX9f+BMMuw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAF4ECC6B0A; Tue, 13 Oct 2026 02:36:40 +0000 (UTC) From: Jim Cromie via B4 Relay Date: Mon, 12 Oct 2026 20:37:06 -0600 Subject: [PATCH v12 35/40] dyndbg: fix attempt to modify an RO string Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261012-dd-cmap-part2-clean-v12-35-3c8cc5725def@gmail.com> References: <20261012-dd-cmap-part2-clean-v12-0-3c8cc5725def@gmail.com> In-Reply-To: <20261012-dd-cmap-part2-clean-v12-0-3c8cc5725def@gmail.com> To: Jason Baron , Shuah Khan , Andrew Morton , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Arnd Bergmann , Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Jonathan Corbet , Greg Kroah-Hartman , Nathan Chancellor , Nicolas Schier , Shuah Khan , Randy Dunlap , "Rafael J. Wysocki" , Pavel Machek , Len Brown , Jonathan Corbet , Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , =?utf-8?q?Thomas_Wei=C3=9Fschuh?= Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arch@vger.kernel.org, linux-modules@vger.kernel.org, linux-doc@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-pm@vger.kernel.org, Jim Cromie X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1791858995; l=1248; i=jim.cromie@gmail.com; s=20260203; h=from:subject:message-id; bh=8R/JnNLwabE40COypqEheAmB4g+drvI/q0k+tJjtJCQ=; b=GBe37Vf4wUzMsGdx+j7lUgOKiiXr268cXRFKywDSx1CQp53zOsAS7VdWoQQtJKJ5Fki2H7yi8 UdSHnKSRRHwBj4eFZxWj3so/4V9Pcm0JTA3qllQdSIhPLB2bZEywdRI X-Developer-Key: i=jim.cromie@gmail.com; a=ed25519; pk=C6E5ODlPQo7ZBynATXH9wg7K6HxP0pIXyf4s38Qw0XE= X-Endpoint-Received: by B4 Relay for jim.cromie@gmail.com/20260203 with auth_id=958 X-Original-From: Jim Cromie Reply-To: jim.cromie@gmail.com From: Jim Cromie ddebug_dyndbg_param_cb() passes an RO flags string "+p" to ddebug_exec_queries() when no explicit param value is given, but callee may attempt to modify it. Fix by adding a local mutable var, init'd with that value, and passing it instead. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index efde85c7a9c1..023784dcdc80 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -1634,8 +1634,9 @@ static int ddebug_add_module(struct _ddebug_info *di) /* helper for ddebug_dyndbg_(boot|module)_param_cb */ static int ddebug_dyndbg_param_cb(char *param, char *val, - const char *modname, int on_err) + const char *modname, int on_err) { + char dflt_flags[] = "+p"; char *sep; sep = strchr(param, '.'); @@ -1648,7 +1649,7 @@ static int ddebug_dyndbg_param_cb(char *param, char *val, if (strcmp(param, "dyndbg")) return on_err; /* determined by caller */ - ddebug_exec_queries((val ? val : "+p"), modname); + ddebug_exec_queries((val ? val : dflt_flags), modname); return 0; /* query failure shouldn't stop module load */ } -- 2.56.0