From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f172.google.com (mail-dy1-f172.google.com [74.125.82.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29A9A47F3D8 for ; Tue, 13 Oct 2026 03:42:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791862954; cv=none; b=fofIXIY4LUmDvEnfsSAtNXxjYqLoDvVO0X/bPs85u6oOCtJ06Uhf5bfQ4XOXRIoa5K96sSuu9ox70nShpZ7+6KkyZVEchHKSeeN1CjM1pVzTbewRvRhVzheQGvIG3C6w2pz8SkXkhuEVYCfuiQR7C9LhritEV317172UCy2Gh9E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791862954; c=relaxed/simple; bh=qQtZc/LYpwS1Pn0Pbj2cy59uoKqv6Ln5ZHOMP+Ij/ls=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hprtCcJqsBVSvum9j8y3FfEWrcVtY4jtuFpjSR8sql9SNOpy8AbdZde3j2AQzs+o5wLrAIep5wUT8S38RV4nfeEqi1NFcLGOPm7BrM1LGytRlfnNv5z4sB55UAP1rGSXhipG4w6TTJGRslv1gN4rGQEp3AFT2toBaprBEnKPo94= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Q2kRnEGy; arc=none smtp.client-ip=74.125.82.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Q2kRnEGy" Received: by mail-dy1-f172.google.com with SMTP id 5a478bee46e88-33e6279a1d7so1807429eec.1 for ; Mon, 12 Oct 2026 20:42:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791862952; x=1792467752; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=L6SSHz5Dk/JWNOpPlT4rfoa6eqVGLCdKSUBhsVYqgGQ=; b=Q2kRnEGyDFWcdS2ZxPmW7s+rq35ZtEfMcFORDFvjaZ/ulG2vHAL2pnYOHYLoA5/Evy DnIFiNOW+Jkb+zBFi6w7pKNnSUD6p+5KT4k4F/1pR0bGOOdOlxO+oA7f9S0e3GAMJ1zY wKO6ySobGjUrH6JS8J3py10QmYVf81OxBtH4Jd25Fv/0QLVrQIthjYqKwbCwUgUBiR3n DNX5g9Io0eUPU4Imqh+VLJmKaEMLYxU/r1QjAZh1xxBp4QrL7iZlbIW2QiVBUAlISHr1 qSZoq9GEIMW4j4CLMplpcPw+c7HxvH283M2qRGVTZG9lxmnc/QvTncx9T0j6Q2YwrEnK +WYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791862952; x=1792467752; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=L6SSHz5Dk/JWNOpPlT4rfoa6eqVGLCdKSUBhsVYqgGQ=; b=rQeCAaxPXOcOMobOfe1YHaP3uO9hJ0s5auab31Vh5QeYQ4IHM90KjKBka5p6YDi/pL 9J4lg0skqGv0NYIlJP8aGmkPqCwRMZFtMLLuD/Ss0j1Rsi3UlN0ES0y6yTN1/vX38jk/ KOr4BIwjkOwIQPdQxVlJ3Upxz32T0CtD9X8X3n50EYFv347eJdpqQjZeQNjRRZuiWHUZ KiXsjk30uuXAYs1K5EuIByDOyEwjpCSD4gmCcXRbukIwbnMD8n7WBCCuOgsj9LNu5VNV kv2p0k4MdLil9nbc7oVHG1N5F9zEzJZSGN7pABVu8hvJA/hU56sNZqZ6T98lbDbBhFTZ 5zpw== X-Forwarded-Encrypted: i=1; AKwUvBx9OqqGBJFJJxw8Ns3m3d5waUU4lgOtCTuc+tCLCocjlGXGV6WxOecXPljGJrhogoQvGqMOvy+aEDny55U=@vger.kernel.org X-Gm-Message-State: AFq9FYLMB9iZtHMscPm78pC5iyZpmfKVQnq4IKmedsczsJFz8ytHvBtZ RYJJ08H3m7ItaRrH28BGdQ03hAX5ylPbV+wLAN72fWHivirqCQMUglg/ X-Gm-Gg: AYBFou3TZEZnhM0nXK6ntoh9P57lwlcOHzr1CbQIKKSaz+ZHx+oyccPgMkBW2wDnm9p 7VnSipifXIapZaiZMq39MXd4sew5Jc69wlQ+U3QS5cRyShqhtlPvW2Cjf874cQGhHlKvcda+hck LF7UbA4CdPmFUasbYsTlgZm4lFrkXZYsQD9BJ8qdnEbAY2TmLbKn7myeqqFsEvRNBAhUVlJN5Eb NcJcWh1FcFU9q9IebZCujIuA8X9GPdxYrspAbdbTaXWxP+xV7LINavkaxvi4YA2MBNSALzne8gg zssjoI/aorueJ8SsiMhvjxUzrPBRbL/3hrKFqhq3FIbQIJTq3Dty9X8HuGBnLpx4o/S+cLjfHt+ ewvnJN0fXCaI+bBYjfSdnj333yc/xWQAWCKQt4q3K0QeUv1YBwIkfJvm+Xi99oTtMh6iDHJvCVb JcHXMhsJjgC/LLWgwLx/tfqEYZQ+kCZ7KR/hVxEY5YBvPcvPvbUJAaZ+2sII8D6eyQX9fcLY/TO 1hOo0+nOf50PxgTFUXE9n0/6p/NLFbHz/jYoMNqaEwTvIMbzEuc/0sXSJqB5F0= X-Received: by 2002:a05:7300:e9c6:10b0:35a:c54:f446 with SMTP id 5a478bee46e88-35a0c54fcadmr8535188eec.40.1791862952303; Mon, 12 Oct 2026 20:42:32 -0700 (PDT) Received: from dtor-ws.sjc.corp.google.com ([2a00:79e0:2ebe:8:679a:f35b:7c29:e0f2]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3537cb68e56sm35268677eec.29.2026.10.12.20.42.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2026 20:42:31 -0700 (PDT) From: Dmitry Torokhov Date: Mon, 12 Oct 2026 20:42:21 -0700 Subject: [PATCH 5/9] HID: i2c-hid: Drop redundant report ID validation Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261012-hid-core-report-validation-v1-5-e0dd5cb60b2e@gmail.com> References: <20261012-hid-core-report-validation-v1-0-e0dd5cb60b2e@gmail.com> In-Reply-To: <20261012-hid-core-report-validation-v1-0-e0dd5cb60b2e@gmail.com> To: Marcel Holtmann , Luiz Augusto von Dentz , David Rheinsberg , Frank Praznik , Jiri Kosina , Benjamin Tissoires , Even Xu , Xinpeng Sun , Roderick Colenbrander Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Shashikirana H K X-Mailer: b4 0.17-dev-e56a4 Now that the core HID request handling validates returned report IDs for report retrieval requests centrally, the report ID mismatch check in the I2C-HID transport driver is redundant. Drop it. Assisted-by: LLM Signed-off-by: Dmitry Torokhov --- drivers/hid/i2c-hid/i2c-hid-core.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/hid/i2c-hid/i2c-hid-core.c b/drivers/hid/i2c-hid/i2c-hid-core.c index a8a9854854f5..d8ed7bb8e80c 100644 --- a/drivers/hid/i2c-hid/i2c-hid-core.c +++ b/drivers/hid/i2c-hid/i2c-hid-core.c @@ -311,13 +311,6 @@ static int i2c_hid_get_report(struct i2c_hid *ihid, recv_len = min(recv_len, ret_count - sizeof(__le16)); memcpy(recv_buf, ihid->rawbuf + sizeof(__le16), recv_len); - if (report_id && recv_len != 0 && recv_buf[0] != report_id) { - dev_err(&ihid->client->dev, - "device returned incorrect report (%d vs %d expected)\n", - recv_buf[0], report_id); - return -EINVAL; - } - return recv_len; } -- 2.56.0.385.gd3acb90ef8-goog