mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark <broonie@kernel.org>
To: Brendan Higgins <brendan.higgins@linux.dev>,
	 David Gow <david@davidgow.net>, Rae Moar <raemoar63@gmail.com>,
	 linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com
Cc: linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>
Subject: [PATCH] lib/tests: util_macros: Drop the '.' from the KUnit suite name
Date: Mon, 12 Oct 2026 23:55:53 +0100	[thread overview]
Message-ID: <20261012-kunit-util-macros-name-v1-1-810b401baeb0@kernel.org> (raw)

The util_macros KUnit suite is named "util_macros.h". KUnit test names
are formed as "<suite>.<test>" and a '.' in the suite name makes them
ambiguous, which breaks every consumer that splits on it:

 - kunit.filter_glob= splits on the first '.', so
   kunit.filter_glob=util_macros.h is parsed as suite "util_macros" with
   test glob "h" and matches nothing.

 - kunit.py's --list_tests output parser only accepts "<suite>.<test>"
   names with a single '.', so the suite's tests are dropped from the
   list and the suite name line "util_macros.h" is mistaken for a test
   called "h" in suite "util_macros".

 - As a result kunit.py --run_isolated=suite boots a kernel with
   kunit.filter_glob=util_macros, which runs nothing and reports an
   error, while the suite's actual tests are never run.

Rename the suite to "util_macros" to match the other lib/tests suites.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
Cc: linux-kernel@vger.kernel.org
To: Brendan Higgins <brendan.higgins@linux.dev>
To: David Gow <david@davidgow.net>
To: Rae Moar <raemoar63@gmail.com>
To: linux-kselftest@vger.kernel.org
To: kunit-dev@googlegroups.com
---
 lib/tests/util_macros_kunit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/tests/util_macros_kunit.c b/lib/tests/util_macros_kunit.c
index 94cc9f0de50a..73652a6872c3 100644
--- a/lib/tests/util_macros_kunit.c
+++ b/lib/tests/util_macros_kunit.c
@@ -229,7 +229,7 @@ static struct kunit_case __refdata util_macros_test_cases[] = {
 };
 
 static struct kunit_suite util_macros_test_suite = {
-	.name = "util_macros.h",
+	.name = "util_macros",
 	.test_cases = util_macros_test_cases,
 };
 

---
base-commit: 24a19b953e2a3d0ea5a8c4951a0ab8f32720c907
base-tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
change-id: 20261012-kunit-util-macros-name-7f490d9f0ffd

Best regards,
--  
Mark Brown <broonie@kernel.org>


                 reply	other threads:[~2026-10-12 22:58 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261012-kunit-util-macros-name-v1-1-810b401baeb0@kernel.org \
    --to=broonie@kernel.org \
    --cc=brendan.higgins@linux.dev \
    --cc=david@davidgow.net \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=raemoar63@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®