From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCB0447CC8A for ; Mon, 12 Oct 2026 09:55:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791798926; cv=none; b=jyneFV4njagUgTM4G+eMYn/L4OUUCxnx4jhhk8MUZUSnAQsmKJ219PHWp5vHP7CPsAtSxEPst2i5CURHhgrS74cKlGHzLgt4LmfYiMnbjgjZxQHKmDZL8+e0jpVgGSI3rpDmXIWJxA4DKOd/TuHILBRQPzMSNUiqThgymiIqFCw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791798926; c=relaxed/simple; bh=BnrYo/A6G2OaUvK9kvg2KfCzfxVlIgzJGfpX6upOnUk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=t/PfOPvlfyFSFs6wxfzdJW1FHGSJdGNXvAq5EWOk+omzofhGHSJzWkVFPtZBiQadtdzU1mXFwx9+ZdeO4jhVjtUkod3yl94FqzEN8Fg7L+/ypNbncs1GtkDnZcaJSpy2aO+Bd3YMevO42Z4YRjTEMLCmwnbJjgMgDttLgAnYqe4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=OCErpna2; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="OCErpna2" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-48c4be28b82so1617107f8f.2 for ; Mon, 12 Oct 2026 02:55:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1791798917; x=1792403717; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=YT1SExoYLuIMwneaSCPvUsBJ4hnC+2ocE7ZXG4QBttQ=; b=OCErpna2ECroNC3rlatBilK0R68Ons075WiIqwHU2rgk8R0PvF+wRB68DlPzgFh4wu 7fvA+Dbr1kVuw/3FkIfYOl8h2claD6YsU7iOSK9pju6WbpjpAWX19gfetwA2tW7F0NPW mxpQ47LeJjjR+flJ8W2JBSVe1RBuZaAsh8ErYMqzgYkMme2WuuQv64OtZF3E1iSaAMNS IC3h7vE5d7ji2K9cFsqdD/bwa6pvpmgQQqu0zJ5gBoaOyN+pKLRx6zyRs+/VPC48UuPD eWfIwq5w+x+bg+lKK20uv0gxcCoXa5D92Ub7ivWHuH8mW2IPMoFToUFpJYPiEfh0ZUxN rkCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791798917; x=1792403717; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=YT1SExoYLuIMwneaSCPvUsBJ4hnC+2ocE7ZXG4QBttQ=; b=sfxEbVp+hAB4An3hW8yZ7p9n2FuzRCcDgucXnQamJuLoeba8LtdZQjSBsG7AADLNip NHrc+J6EgBPe8+Ef6f/WJdfer0gTcj6wAW9X30bNUkBHAcqTfRqfNkFdsPdeh+/w2fnJ TQ+SMDtk2NcIL/IDd6jiG3To6se8s8YtuTDDBNP8jx9IkZt7lY1TfSh7d+wNMRDZYVuU wm2F8yfEKusfDP95oEBgSj8fYDCojnxSu3EcFqEgE/f6DpIevMsDc3hTJqkc/B4XQeGd 5q/OdOyIPyNHV9AU1FeT//xb3GH4M2dx5nQaTs2tjgK4zXP/4uNo2VrsAE8BIY6dwXHw dD6g== X-Gm-Message-State: AFq9FYJlmqWmY+jA9d3i0kFs1kcTL9RBVx0GlEn2bD7RRSnJeefOxRrr vM49vTmQPpF8Nt8eeSEhPZhK0iU4ygX7sH5CYgjIMAg3jGy2LJUVWRyp1EdrNIQfcozkJxiv5OA vkZySHjo= X-Gm-Gg: AYBFou3gJWZwr8lD9g27wyxBmoTZqkkY4iDdJskXd1RG45pfmq/gcTCob69jyX+2C2P cVRQlqo4wixUrRUvbuQKyYZbXoCHr4kViE/ZLuLMWPlu1uCTuFdyFgAGFPhYgopD01pQ61H9iOS kZjJeS0RIc0rLeGjoATD93pAIQi3i2yYOp0gYuqr81pLOyQOGNxGQdaVermPaCH9aZSGngeb6b5 a3HkRZaKG5NHKba+jLKLlROa3QnTpAw5X934ld7Pmas3JsrJ/m+TrLNJt/EJaCG1IO5jjS6pucZ N68FKnoTgnVoIZzZesPCsZ2Lg4LTePtpTt9JZcrBbo6rNQY0KbzOXsNXj6m5iEXLXfaKxbX9W6G mshDd/G6mTB3/0xPSOM+vG1tFgXz2lPjCp2u86+BB4ORnp0Lvp393PfRUhaGszpx4I+WUvXnc78 jVhmfYSHHTYzsBCELlM3LBttixH31c+lpkZ1UiAqYHocZVpCq8srDF/+8dfbFsfGb2wEGvplEGG h1aprEtGv47Xcic9mos3w== X-Received: by 2002:a05:6000:2505:b0:487:27f9:840 with SMTP id ffacd0b85a97d-48dbace65bcmr17485319f8f.53.1791798916694; Mon, 12 Oct 2026 02:55:16 -0700 (PDT) Received: from localhost.localdomain ([2a00:6d43:105:c401:e307:1a37:2e76:ce91]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48db98c2800sm18539103f8f.26.2026.10.12.02.55.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2026 02:55:15 -0700 (PDT) From: Marco Crivellari To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Cc: Tejun Heo , Lai Jiangshan , Frederic Weisbecker , Sebastian Andrzej Siewior , Marco Crivellari , Michal Hocko , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Ethan Nelson-Moore , linux-usb@vger.kernel.org Subject: [PATCH net-next v4 6/6] net: usb: r8152: Move long delayed work on system_dfl_long_wq Date: Mon, 12 Oct 2026 11:54:45 +0200 Message-ID: <20261012095452.135828-7-marco.crivellari@suse.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261012095452.135828-1-marco.crivellari@suse.com> References: <20261012095452.135828-1-marco.crivellari@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Currently the code enqueue work items using {queue|mod}_delayed_work(), using system_long_wq. This workqueue should be used when long works are expected and it is a per-cpu workqueue. The function(s) end up calling __queue_delayed_work(), which set a global timer that could fire anywhere, enqueuing the work where the timer fired. Unbound works could benefit from scheduler task placement, to optimize performance and power consumption. Long work shouldn't stick to a single CPU. Recently, a new unbound workqueue specific for long running work has been added:     c116737e972e ("workqueue: Add system_dfl_long_wq for long unbound works") Since the workqueue work doesn't rely on per-cpu variables, there is no obvious reason that justify the use of a per-cpu workqueue. So change system_long_wq with system_dfl_long_wq so that the work may benefit from scheduler task placement. Cc: Ethan Nelson-Moore Cc: linux-usb@vger.kernel.org Signed-off-by: Marco Crivellari --- drivers/net/usb/r8152.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index f61686433031..f6af66f294db 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/net/usb/r8152.c @@ -7072,7 +7072,8 @@ static void rtl_hw_phy_work_func_t(struct work_struct *work) /* Delay execution in case request_firmware() is not ready yet. */ - queue_delayed_work(system_long_wq, &tp->hw_phy_work, HZ * 10); + queue_delayed_work(system_dfl_long_wq, &tp->hw_phy_work, + HZ * 10); goto ignore_once; } @@ -8840,7 +8841,7 @@ static int rtl8152_reset_resume(struct usb_interface *intf) clear_bit(SELECTIVE_SUSPEND, &tp->flags); rtl_reset_ocp_base(tp); tp->rtl_ops.init(tp); - queue_delayed_work(system_long_wq, &tp->hw_phy_work, 0); + queue_delayed_work(system_dfl_long_wq, &tp->hw_phy_work, 0); set_ethernet_addr(tp, true); return rtl8152_resume(intf); } @@ -10295,7 +10296,7 @@ static int rtl8152_probe_once(struct usb_interface *intf, /* Retry in case request_firmware() is not ready yet. */ tp->rtl_fw.retry = true; #endif - queue_delayed_work(system_long_wq, &tp->hw_phy_work, 0); + queue_delayed_work(system_dfl_long_wq, &tp->hw_phy_work, 0); set_ethernet_addr(tp, false); usb_set_intfdata(intf, tp); -- 2.55.0