From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6F6DD41B355 for ; Mon, 12 Oct 2026 13:00:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791810009; cv=none; b=mCxMPqNeqkznNywA+oDTt4ftpghMrYlJgIzP0JF3B6W4l+7Ye3ddglIOsrliSqlPCGhgszHI4s3llTEDof3nCsJO9ogarVcyPheYBQXBdOBWeflNsiGr2a67FC5UPCdpD9hAQadKqbI281bEsdBaqa3lWfriHgfT8OLp/V8ikMk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791810009; c=relaxed/simple; bh=0XK4Sh6FpW40ECLF40/dTs4Z7JBcexbzlxyt6d0Q/SE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=p7nKg5wwUkBpWeEeL8bMauG+YJV7UF5+fwX5xGjOgBKZZA4Nth24V4jMVMUeTywyYRA68AnD8M8yN+E4+iVUWmSnpsa+UoHhR+pQZIt/SSc7cYPzIaUwK6jwVzdCUWgVRErtuGVxXOGVXJh3WDSTXeAspvO/AX7fGkT17qxo1nI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=cUPkWs2y; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="cUPkWs2y" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 685B61A00; Mon, 12 Oct 2026 06:00:02 -0700 (PDT) Received: from e120398-lin.trondheim.arm.com (e120398-lin.trondheim.arm.com [10.42.46.160]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 71D643F66F; Mon, 12 Oct 2026 06:00:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1791810005; bh=0XK4Sh6FpW40ECLF40/dTs4Z7JBcexbzlxyt6d0Q/SE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cUPkWs2y+W9Nvi5qiDXFR/paUUe3abraXdfy/Ay3i24ZHy/QnRAzMf024GH+tCheh eTG9AkG+W4TdZa9wOS/vqNxNA/hNrN/dY01s5O6/Nx0W6IbnPr7U1qc/hoT6BYokq9 RvLZ+dkAvJQZWZr3gLQUCJG92H2A4DXdOBbKBVqk= From: Ketil Johnsen To: Boris Brezillon , Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Daniel Almeida , Alice Ryhl Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ketil Johnsen Subject: [PATCH v4 04/12] drm/panthor: Don't allocate protm_suspend_buf Date: Mon, 12 Oct 2026 14:59:32 +0200 Message-ID: <20261012125940.3291951-5-ketil.johnsen@arm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261012125940.3291951-1-ketil.johnsen@arm.com> References: <20261012125940.3291951-1-ketil.johnsen@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The PROTM suspend buffer is only needed if the group is going to use PROTM in the first place, so let's not assume we need one until we're being asked to. Reviewed-by: Boris Brezillon Reviewed-by: Steven Price Reviewed-by: Liviu Dudau Signed-off-by: Ketil Johnsen --- drivers/gpu/drm/panthor/panthor_sched.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/panthor/panthor_sched.c index 3bd6be9407097..db801705f0d27 100644 --- a/drivers/gpu/drm/panthor/panthor_sched.c +++ b/drivers/gpu/drm/panthor/panthor_sched.c @@ -3641,9 +3641,11 @@ static void add_group_kbo_sizes(struct panthor_device *ptdev, if (drm_WARN_ON(&ptdev->base, ptdev != group->ptdev)) return; - group->fdinfo.kbo_sizes += group->suspend_buf->obj->size; - group->fdinfo.kbo_sizes += group->protm_suspend_buf->obj->size; group->fdinfo.kbo_sizes += group->syncobjs->obj->size; + group->fdinfo.kbo_sizes += group->suspend_buf->obj->size; + + if (group->protm_suspend_buf) + group->fdinfo.kbo_sizes += group->protm_suspend_buf->obj->size; for (i = 0; i < group->queue_count; i++) { queue = group->queues[i]; @@ -3724,14 +3726,6 @@ int panthor_group_create(struct drm_file *file, goto err_put_group; } - suspend_size = csg_iface->control->protm_suspend_size; - group->protm_suspend_buf = panthor_fw_alloc_suspend_buf_mem(ptdev, suspend_size); - if (IS_ERR(group->protm_suspend_buf)) { - ret = PTR_ERR(group->protm_suspend_buf); - group->protm_suspend_buf = NULL; - goto err_put_group; - } - group->syncobjs = panthor_kernel_bo_create(ptdev, group->vm, group_args->queues.count * sizeof(struct panthor_syncobj_64b), -- 2.43.0