From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DF8348F01E for ; Mon, 12 Oct 2026 14:13:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791814387; cv=none; b=p2FcSjwMIJxIbBtsdkMJhFX3hdaUa+1ynPOj+wUZSUk75yUn5yR5G+/7f8aTdQIEOsgIYolDEqsX6J1Gw8PirUQPXoNqKVm6qxCFuGYN97fu3okYa4KktHiZTGyqgbxiAsJsxeJMbkONQk16UZt8z/1NiIEpWYuOVUHiV1YMQbM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791814387; c=relaxed/simple; bh=Op9mdkaqB5CNS94ylwnFmEPh8O+aB/lXmsYsw/4hf8I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BL4cwSBnbyj1mxGOVnLd4rhFlSsGUgZXURjEkBS/oJP71vjJ1db2o14uvN/ZsqD1XkDSOh8jDeuRIxgUSDd0n2yEy7o8IxmQ5w+itdkrcAY9u8I/55HmeXi1LCAG9N+cHgmlOCF5IhlUul6nTo3fuz50xH/rAmzISo2aCqoLqSc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GlHLtFv7; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GlHLtFv7" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-48b0ef9c76eso1619351f8f.0 for ; Mon, 12 Oct 2026 07:13:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791814383; x=1792419183; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=FEGgdcLnqcVqT4VDy0LsmeHP+tq7RUbfRCvfJ7zm1f4=; b=GlHLtFv7jxKrQRsMJLjlCynrQxeG6HHCWeaaKqrzsIvlE8frTFyGach8ZCvdOlObn7 P48+TnIioT1Fvr0sO1jNs/6xIQN9bHAOF0KjcmUjbtHxZbzVU/DHfWK9dgpytct3+Ec7 okHho/d/YrcgX1vUukbsZ4lE8hgEO0zkUih1UkCmmjEsBxXCHT49DEnDU9sSbeVBV7C4 sJ7Bs+kPoCBHT2wjoUOnEACiCIrtw4XdD7VgiSXmF7Z6n9n70KVhOwNzxcC6C/VbekUN Dbp0mkG2mi+VmwjUtHidnHcQJGz+Hjt0h8wTvskTaRWwrtn7VCMM7NMrruwUDiU1J7Si 7Hqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791814383; x=1792419183; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=FEGgdcLnqcVqT4VDy0LsmeHP+tq7RUbfRCvfJ7zm1f4=; b=UboTrmVVtMeEP1H7/3ngbNmDuPClDh6OifFlg7CcHlIEM8sFepER8rSE5RY4E3ovEb HFLdXzaIsX3Pdbttx6NXuCd1ft5ip2iNFLZO3sqHTeuLH5J+aiynWo3cSZk7fJIQHQSQ MSa7JPk0NDguIte4pUVdog8ITt6JHyImMOYTkFscQ/en80cBEzER7tevl2eFiyRipiIH qygaqUAgmvP9V6NoIDjSMLKWYENFTxLH/jIIrigC6l/8m4vZ4dG5ty4/KDMFFgl2n5GI 3HWTa3pIvVZnaiy0UoBS2+tVu3XgtBaLSizK2534uzKmV5kDPAHfmvgJ5DqaKS6jezIp ilzw== X-Forwarded-Encrypted: i=1; AKwUvBxzYjAinS69j2gBeHoPBCKa129vLiLe5w0/eXPX28mdFGvqzuJuu37y+cTYuFlTaT10nLxfumTzIkCDA8s=@vger.kernel.org X-Gm-Message-State: AFq9FYK3ii88M68xE/ezxmKxq6UFgXe2ak74+iCojGXROmho3CNJmF75 oHm13Oc/PjB9QKBgcrxibMZgJXSvaT8x5YTX68FtDI7mzp84AcxF25Nbn9R75s2f X-Gm-Gg: AYBFou1MIYEWzqSKWE4XTHefOjzKYzDSO0UPS1otby+IvV0AWw3ThZPGyVL6B2INMPR 0Mybxww7x+Fow5JgnvlSpVf+VVhQhxRzj9JzvBNqsHgoJDQ0SCU91VX9a5Tiawy2PKMMFhGbARy MPIIbFK9xmH/6dF/zD1G9Z/kNFwYVk87ByQja3MwIQfkrFA1wHMv/XfI2X9YPr50KAeZ48CrJg3 iLchFGaa+bQg3kESvKsyB/RUDyTfMP2EDeZBGd9asBF4q+TfXXq4cKZyb1qyRbSUujkMmkdLm0H akPb1mawCn+RW4sXwoiPqBg6Ocdz8o756H66xFVR1O09PCqBtHyVEY6rAOujzSrsRcZcl2kjmsK h41vCrebiYYCGR/1Nyc7Q+aWLTiK71NnIabGFRqJyJZPH6aN2+nP/Zj4lmiKl1AkjOWluGRPsye ZF3NLcvHQeWw8bXWJxX6vP4+8f7BqBAM5+gpZPNPtH7A+nQrYUs4XQQaLMwbMbAcgeEzdwE8UO6 1shoJDycqi8SGKcZG6xdAHW7VOA4BM= X-Received: by 2002:a05:600c:8208:b0:4a0:1b14:d00c with SMTP id 5b1f17b1804b1-4a18e446f55mr177700555e9.3.1791814383286; Mon, 12 Oct 2026 07:13:03 -0700 (PDT) Received: from andreayoga.wind3.hub ([151.76.59.204]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48db9ac02cfsm18703035f8f.39.2026.10.12.07.13.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2026 07:13:02 -0700 (PDT) From: Andrea Parri To: Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni Cc: Andrea Parri , Damien Le Moal , Keith Busch , Manivannan Sadhasivam , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH 4/5] nvmet: pci-epf: report transport errors in command completions Date: Mon, 12 Oct 2026 16:12:31 +0200 Message-ID: <20261012141239.156408-5-parri.andrea@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261012141239.156408-1-parri.andrea@gmail.com> References: <20261012141239.156408-1-parri.andrea@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When the PCI endpoint target fails a command itself, the host receives a successful completion. This happens for a data length above MDTS, malformed PRPs or SGLs, a buffer allocation failure, an SQ that is not live, and a failed DMA of the command data. A write whose data cannot be fetched from the host is thus reported as written, though nothing was executed. Each of these paths sets iod->status and calls nvmet_pci_epf_complete_iod(), which then reloads iod->status from iod->cqe.status. The nvmet core only fills that field when it completes the request, which these paths never do, so it is still zero and nvmet_pci_epf_cq_work() posts a success status to the host. Drop the reload. Every path already sets iod->status before completion: nvmet_pci_epf_queue_response() copies it from the request's CQE, and the transport error paths set it themselves. Found by code inspection. Build-tested only (x86_64, W=1): no PCI endpoint hardware was available to run it. Fixes: 0faa0fe6f90e ("nvmet: New NVMe PCI endpoint function target driver") Cc: stable@vger.kernel.org Assisted-by: LLM Signed-off-by: Andrea Parri --- drivers/nvme/target/pci-epf.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/nvme/target/pci-epf.c b/drivers/nvme/target/pci-epf.c index c683450df4227..4c5fff232fb99 100644 --- a/drivers/nvme/target/pci-epf.c +++ b/drivers/nvme/target/pci-epf.c @@ -1152,7 +1152,6 @@ static void nvmet_pci_epf_complete_iod(struct nvmet_pci_epf_iod *iod) unsigned long flags; /* Print an error message for failed commands, except AENs. */ - iod->status = le16_to_cpu(iod->cqe.status) >> 1; if (iod->status && iod->cmd.common.opcode != nvme_admin_async_event) dev_err(iod->ctrl->dev, "CQ[%d]: Command %s (0x%x) status 0x%0x\n", -- 2.53.0