From: Kayra Cizmeci <kayracizmeci@gmail.com>
To: vincent.guittot@linaro.org
Cc: bsegall@google.com, christian.loehle@arm.com,
dietmar.eggemann@arm.com, elif.topuz@arm.com,
juri.lelli@redhat.com, kayracizmeci@gmail.com,
kprateek.nayak@amd.com, linux-kernel@vger.kernel.org,
mgorman@suse.de, mingo@kernel.org, mingo@redhat.com,
peterz@infradead.org, rostedt@goodmis.org, sh@gentwo.org,
vschneid@redhat.com
Subject: Re: [PATCH] sched/eevdf: Fix vprot across reweighting
Date: Mon, 12 Oct 2026 18:01:20 +0300 [thread overview]
Message-ID: <20261012150121.6516-1-kayracizmeci@gmail.com> (raw)
In-Reply-To: <CAKfTPtDDWo4n_AS6fSryz3NenDvKw04shmGM3wcv_MF-teDHGQ@mail.gmail.com>
I send one mail, one more to reply comes. Ah.. I love it tho :-)
> Before 819224e506bc ("sched/fair: Remove dead code on
> enqueue_task_fair()"), the reweight_eevdf() was not called for curr so
> the false was always true. If we can finally have enqueue curr then we
> should skip this case
Yeah. The beast I created kills me. Pretty nice.
On sched_change_begin(), cfs_rq->curr is set to NULL. So while entering enqueue_task_fair(), curr is false.
on_rq is false too. But the tasks weight is changed and vprot never gets touched so it got wrong. Then on set_next_task_fair(),
the task is curr again.
next prev parent reply other threads:[~2026-10-12 15:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-03 11:46 Kayra Cizmeci
2026-10-11 7:13 ` Christian Loehle
2026-10-11 10:06 ` Kayra Cizmeci
2026-10-12 4:39 ` K Prateek Nayak
2026-10-12 13:40 ` Vincent Guittot
2026-10-12 13:59 ` Kayra Cizmeci
2026-10-12 14:14 ` Vincent Guittot
2026-10-12 15:01 ` Kayra Cizmeci [this message]
2026-10-12 19:00 ` Kayra Cizmeci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261012150121.6516-1-kayracizmeci@gmail.com \
--to=kayracizmeci@gmail.com \
--cc=bsegall@google.com \
--cc=christian.loehle@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=elif.topuz@arm.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sh@gentwo.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®