From: John Singleton <johnsingleton@google.com>
To: Hans de Goede <hansg@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andy Shevchenko <andy@kernel.org>
Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
John Singleton <johnsingleton@google.com>
Subject: [PATCH 2/3] staging: media: atomisp: Remove extraneous dev_dbg
Date: Mon, 12 Oct 2026 16:13:21 +0000 [thread overview]
Message-ID: <20261012161322.930099-2-johnsingleton@google.com> (raw)
In-Reply-To: <20261012161322.930099-1-johnsingleton@google.com>
Remove dev_dbg calls that (per checkpatch) are duplicative
wrt ftrace.
Signed-off-by: John Singleton <johnsingleton@google.com>
---
drivers/staging/media/atomisp/pci/atomisp_cmd.c | 2 --
drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 4 ----
2 files changed, 6 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
index 6cd500d9fd26..a7c28c261320 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
@@ -262,8 +262,6 @@ int atomisp_reset(struct atomisp_device *isp)
/* Reset ISP by power-cycling it */
int ret = 0;
- dev_dbg(isp->dev, "%s\n", __func__);
-
ret = atomisp_power_off(isp->dev);
if (ret < 0)
dev_err(isp->dev, "atomisp_power_off failed, %d\n", ret);
diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
index 812230397409..d83c967fd125 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
@@ -345,8 +345,6 @@ static int atomisp_save_iunit_reg(struct atomisp_device *isp)
{
struct pci_dev *pdev = to_pci_dev(isp->dev);
- dev_dbg(isp->dev, "%s\n", __func__);
-
pci_read_config_word(pdev, PCI_COMMAND, &isp->saved_regs.pcicmdsts);
/* isp->saved_regs.ispmmadr is set from the atomisp_pci_probe() */
pci_read_config_dword(pdev, PCI_MSI_CAPID, &isp->saved_regs.msicap);
@@ -400,8 +398,6 @@ static int atomisp_restore_iunit_reg(struct atomisp_device *isp)
{
struct pci_dev *pdev = to_pci_dev(isp->dev);
- dev_dbg(isp->dev, "%s\n", __func__);
-
pci_write_config_word(pdev, PCI_COMMAND, isp->saved_regs.pcicmdsts);
pci_write_config_dword(pdev, PCI_BASE_ADDRESS_0, isp->saved_regs.ispmmadr);
pci_write_config_dword(pdev, PCI_MSI_CAPID, isp->saved_regs.msicap);
--
2.56.0.385.gd3acb90ef8-goog
next prev parent reply other threads:[~2026-10-12 16:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 16:13 [PATCH 1/3] staging: media: atomisp: Make pmic_name array const John Singleton
2026-10-12 16:13 ` John Singleton [this message]
2026-10-12 19:05 ` [PATCH 2/3] staging: media: atomisp: Remove extraneous dev_dbg Andy Shevchenko
2026-10-12 16:13 ` [PATCH 3/3] staging: media: atomisp: Fix parameter indentation and block comments John Singleton
2026-10-12 19:04 ` Andy Shevchenko
2026-10-12 19:07 ` [PATCH 1/3] staging: media: atomisp: Make pmic_name array const Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261012161322.930099-2-johnsingleton@google.com \
--to=johnsingleton@google.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®