From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f198.google.com (mail-dy1-f198.google.com [74.125.82.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC7874BF95A for ; Mon, 12 Oct 2026 17:43:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.198 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791826986; cv=none; b=exJDSXmA1RccOU9E7f05M5wVin4sKPCgxm3OF8hUhhfyL9rHRKSNCWpYUaD9UgQ+YJWzvgXY+1wFkOKcO9C8ZDofHGqaQa+8pvCVAwE2fMQpgrYeOBSye23sDB6MW1vwcdXNKI4pMgtYwU1DgmEDqU9hl7AtyRyrduJuV46DlAA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791826986; c=relaxed/simple; bh=w09JRa+8f6pKEl30DKJQ5yMAIvWJUIEbrFF0HQcgelU=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=e1yScp5DuMlIlrAeYBfqSrkc1v9N9d4IAIvnR/yuKm+qiyS4qD/h0QAijJIFJjfbdGFK+sQUE3FEa8ZihusVQSc61CU99jIDZAtAt4Pzs3rHnhk7cpKkei5b5haZCRQs9YydLllYvPugcZ0qN9D3k9L7Lyv+sbqnmpU3g+sovWM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--almasrymina.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=S1tBKpJZ; arc=none smtp.client-ip=74.125.82.198 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--almasrymina.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="S1tBKpJZ" Received: by mail-dy1-f198.google.com with SMTP id 5a478bee46e88-3548cdfd2fbso3399658eec.1 for ; Mon, 12 Oct 2026 10:43:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1791826984; x=1792431784; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:mime-version:date:from :to:cc:subject:date:message-id:reply-to:content-type; bh=3iJ1fd8MwlejaVJSs6HGpqE749ZNI8lIjAO4rDvQDfA=; b=S1tBKpJZr1sPP7TTsVyb7vPFN9irDROHI8VY4dGfBMdrDkI13ajaqpywDiVMCojI5g a2zkzWT/J11D7UoUGY70CZ2QL+UC6XttvWWd+12ubnQ5it7nHHNi835t99h+2Bv60uCW PijLs/XZhWHmjeG55ASwpS5S1sfhy8/WfT3P7gm9Jlos0aMooA2u3xP7uXXrYfx2BBpw HyQLBosSyD4OwxUvZHAWqpoB8OyQTNeSGDPNYd6Ddj/9uGG9E0BYJH6m22JUpk+9iGiM NRRg4vbPJy7G0YI9E4VldTHbht7SWLayh0ytclnZOhvlzmbDFR0IyVzkSdcEs+DT1YsL U7ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791826984; x=1792431784; h=content-type:cc:to:from:subject:message-id:mime-version:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=3iJ1fd8MwlejaVJSs6HGpqE749ZNI8lIjAO4rDvQDfA=; b=fIE/OGChSB7mi/fMeyhh7XdV0DuT8F5yeppSLlyy/ITNYRIjPAa/e+AgqWjY7D+Zpy 0KmLETnQfbmPq1es4pG5J/K452OVj29ibCqgl4408phcTnLIefJJyT0vPQy5k2/Hz3td nZCkgDv0Eyzh71vTFPOrscHsAzzRqTBS2t5/9/n5NHCeYfmXCWTwyPbzdjYr+DGAxfQP nR7G8BzdkJNFoC7TRRZzcj9JGz+KvgGNFYFlEV5bj2JeVvCKVIKBF5PArCBpYjmhokXs AUETAP+I24x/jp+UxzGbwIjEu7HmhrBnA7h3nxvSfZ0vPg5CNywblEVvE9FVpxUpNuln OUtA== X-Forwarded-Encrypted: i=1; AKwUvBxfotWqoMSnG4kqWewpSrTUwJ+CGDqNvp7gbyxGjeROwCIgrA3dyyHxbaDiwnuJ79WUXEZKp7Cr1XH3aU4=@vger.kernel.org X-Gm-Message-State: AFq9FYK/0m/dVR4X3nJRToCZqLqB32dP1wTTe59vgIi+tkgmn50bmiDA RAvOGSb1pC5X4sBXRn+047gz+BQVJ+80xrOJf5j2NY975uJRwt2OB26X6XI1TNtYjVh0P3v9h51 O8q0+ZYV6Jamlpmc4mUOg6t4Clw== X-Received: from dybfc20.prod.google.com ([2002:a05:7300:3e94:b0:35a:6ed3:3ee9]) (user=almasrymina job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7300:de49:b0:35b:b3fa:40f7 with SMTP id 5a478bee46e88-35bb3fa4218mr1447041eec.38.1791826981179; Mon, 12 Oct 2026 10:43:01 -0700 (PDT) Date: Mon, 12 Oct 2026 17:42:56 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.56.0.385.gd3acb90ef8-goog Message-ID: <20261012174300.2338784-1-almasrymina@google.com> Subject: [PATCH net v2 0/4] net: devmem: fix RX and TX binding teardown on device unregistration From: Mina Almasry To: Jakub Kicinski , David Wei , Pavel Begunkov , Mina Almasry , Taehee Yoo , Stanislav Fomichev , Paolo Abeni , Kaiyuan Zhang , Bobby Eshleman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Simon Horman , Shuah Khan , Sumit Semwal , "=?UTF-8?q?Christian=20K=C3=B6nig?=" , Nikolay Aleksandrov , Daniel Borkmann , Tariq Toukan , Kaifeng Wang Content-Type: text/plain; charset="UTF-8" Fix two device-unregistration lifecycle bugs in devmem TCP bindings and add netdevsim support plus selftests covering both RX and TX device unregistration: 1. net: devmem: unmap dma_buf synchronously on queue uninstall Synchronously unmap and detach binding->attachment under binding->lock when the last RX queue is uninstalled in mp_dmabuf_devmem_uninstall(), and unmap RX bindings that were already unbound on NETDEV_UNREGISTER, preventing slab-use-after-free in dma_unmap_sg_attrs() when the binding is freed after dma_dev. 2. net: devmem: detach TX bindings on NETDEV_UNREGISTER Extend net_devmem_dev_unregister() to fully detach and unmap TX bindings when binding->dev unregisters, or clear binding->vdev alone when only a virtual device unregisters while binding->dev lives. 3. netdevsim: support devmem RX and TX bindings Enable PP_FLAG_DMA_MAP | PP_FLAG_ALLOW_UNREADABLE_NETMEM, 64-bit DMA mask on nsim_bus_dev, and NETMEM_TX_DMA on netdevsim so devmem RX/TX bindings can be exercised in software selftests. 4. selftests: net: add devmem RX and TX netdev unregister tests Add devmem_bind_rx_unregister_check and devmem_bind_tx_unregister_check to tools/testing/selftests/net/nl_netdev.py. Cc: Tariq Toukan Cc: Kaifeng Wang --- v2: - 1/4: Don't unmap when a leased queue is unleased. Keep bindings in net_devmem_dmabuf_bindings until freed, hidden from TX lookups by an xarray mark, and unmap unbound RX bindings on NETDEV_UNREGISTER. Update the binding->lock and binding->ref comments. (Sashiko) - 2/4: Detach TX bindings from the same net_devmem_lock-protected walk, which now also covers unbound TX bindings, and clear the LIVE mark instead of erasing the ID. The walk no longer uses RCU or takes binding references (Stanislav). - Link to v1: https://lore.kernel.org/netdev/20261010025532.839559-1-almasrymina@google.com/ Mina Almasry (4): net: devmem: unmap dma_buf synchronously on queue uninstall net: devmem: detach TX bindings on NETDEV_UNREGISTER netdevsim: support devmem RX and TX bindings selftests: net: add devmem RX and TX netdev unregister tests drivers/net/netdevsim/bus.c | 1 + drivers/net/netdevsim/netdev.c | 21 ++-- net/core/devmem.c | 121 ++++++++++++++++++++--- net/core/devmem.h | 10 +- net/core/netdev-genl.c | 1 + tools/testing/selftests/net/nl_netdev.py | 108 +++++++++++++++++++- 6 files changed, 236 insertions(+), 26 deletions(-) base-commit: 4f6ac74fa594a918d41255c941256e1d51592d3b -- 2.56.0.385.gd3acb90ef8-goog