From: Jamie Nguyen <jamien@nvidia.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Len Brown <lenb@kernel.org>, <linux-acpi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ACPI: sysfs: Expose BDAT data region
Date: Mon, 12 Oct 2026 11:51:48 -0700 [thread overview]
Message-ID: <20261012185148.3192127-1-jamien@nvidia.com> (raw)
In-Reply-To: <CAJZ5v0ghc7Ks=nMNwtvm9727NbUQb0XDEu4GrXiEcaDELgRk+A@mail.gmail.com>
On Mon, Oct 12, 2026 at 11:15 AM Rafael J. Wysocki <rafael@kernel.org> wrote:
> Please see the Sashiko feedback on this patch:
>
> https://sashiko.dev/#/patchset/20261009232955.866131-1-jamien%40nvidia.com
>
> and let me know what you think about it.
I agree with the Sashiko findings, and it looks like BERT and CCEL have
the same problem, going back to commit 7dae6326ed76 ("ACPI / sysfs:
Extend ACPI sysfs to provide access to boot error region").
I'll send a v2 with a preparatory patch that moves sysfs_create_bin_file()
and the kfree() on failure into acpi_table_data_init(), so it is fixed for
all three tables, with the BDAT patch on top.
The other concern in the report, the direct returns in the
acpi_tables_sysfs_init() loop, was there before this patch, so I'd rather
handle it separately if that's okay.
Jamie
next prev parent reply other threads:[~2026-10-12 18:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 23:29 Jamie Nguyen
2026-10-12 18:15 ` Rafael J. Wysocki (Intel)
2026-10-12 18:51 ` Jamie Nguyen [this message]
2026-10-12 18:57 ` Rafael J. Wysocki (Intel)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261012185148.3192127-1-jamien@nvidia.com \
--to=jamien@nvidia.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®