mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Varsh Satti <varsh@varram.me>
Cc: Rickey Bartlett <subtexel@gmail.com>,
	Nirmal Patel <nirmal.patel@linux.intel.com>,
	Jonathan Derrick <jonathan.derrick@linux.dev>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Krzysztof Wilczynski <kwilczynski@kernel.org>,
	Kai-Heng Feng <kai.heng.feng@canonical.com>,
	Keith Busch <kbusch@kernel.org>,
	Manivannan Sadhasivam <mani@kernel.org>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: vmd: Flush initiator posted writes before demuxing interrupts on Meteor Lake
Date: Mon, 12 Oct 2026 15:19:10 -0500	[thread overview]
Message-ID: <20261012201910.GA1379657@bhelgaas> (raw)
In-Reply-To: <20261012194011.48215-1-varsh@varram.me>

On Mon, Oct 12, 2026 at 02:40:11PM -0500, Varsh Satti wrote:
> On Mon, Aug 24, 2026 at 09:32:20PM -0700, Rickey Bartlett wrote:
> > Meteor Lake VMD (8086:7d0b) is affected by erratum MTL016: the VMD can
> > signal its MSI before the posted writes carrying a child device's DMA
> > data have landed in memory.
> 
> Arrow Lake-H is affected too. It uses the same VMD device ID
> (8086:7d0b), so the existing match already covers it.
> 
> Hardware: ASUS ROG Zephyrus G16 GU605CP (BIOS GU605CP.307), Core Ultra 9
> 285H, with a WD PC SN5000S (firmware 34230100) as the only device behind
> the VMD.
> 
> Without the patch, on 7.2.9, I got 13 "timeout, completion polled"
> events in about an hour of desktop use. Each one froze the desktop for
> up to 30 seconds. Disabling APST and ASPM
> (nvme_core.default_ps_max_latency_us=0 pcie_aspm=off) did not help: I
> still got 7 in a 10 minute boot.
> 
> With the patch backported to 7.2.9, there were no timeouts in 13+ hours
> of normal use (~340k reads). Average read latency went from 77 ms to
> 0.49 ms. Apart from context, the only change the backport needed was
> adding struct vmd_dev::features, which 7.2 doesn't have.
> 
> Since this fixes 30 second stalls on laptops that are already shipping,
> would it be suitable for stable?

Yes, I think so.  I added stable tags to both:

  6fc5bcb43436 ("PCI: vmd: Flush DMA writes before handling MSI on Meteor Lake")
  78b25e75d082 ("PCI: vmd: Flush DMA writes before handling MSI on Arrow Lake")

The 8086:7d0b Arrow Lake-H ID is actually covered by the Meteor Lake
patch.

> Tested-by: Varsh Satti <varsh@varram.me>

      reply	other threads:[~2026-10-12 20:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-25  4:32 Rickey Bartlett
2026-09-02 12:28 ` Manivannan Sadhasivam
2026-09-08 23:10 ` Bjorn Helgaas
2026-09-09  1:53 ` Keith Busch
2026-09-09  3:00   ` Rickey Bartlett
2026-10-01 17:08 ` Bjorn Helgaas
2026-10-03  3:40   ` Rickey Bartlett
2026-10-05 23:39     ` Bjorn Helgaas
2026-10-12 19:40 ` Varsh Satti
2026-10-12 20:19   ` Bjorn Helgaas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261012201910.GA1379657@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=jonathan.derrick@linux.dev \
    --cc=kai.heng.feng@canonical.com \
    --cc=kbusch@kernel.org \
    --cc=kwilczynski@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=mani@kernel.org \
    --cc=nirmal.patel@linux.intel.com \
    --cc=subtexel@gmail.com \
    --cc=varsh@varram.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®