From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68DE03DAAA0; Mon, 12 Oct 2026 21:41:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791841281; cv=none; b=nKfkMFla9a4PQGgTBlqPGJa1ZonbWcZRPMXOv/bmN9KrJLmQgn9GKJawXPISSdFP103PXDzkPZDtUA08Bt13kAJzhTsi4naRJmIcZMZXMH3audNFyvIyUry/5D5pWxWsdNrdCRHp/whh4K/CU6iVNmVu6WoY90BciVvxwgLhcSg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791841281; c=relaxed/simple; bh=FX6S1QZ4xR5qAw23oNd2jsRpyqj3JES0gYmStuLzVT4=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=bFEb9O2NV+gz7ZxW/NwQPZgUK872Ref4JwHiiqOHZFkeSIAxo5JBJ9Z+Up9SDH9dpAs4kmd8U+OXskmO7fkqOF+Ldgdg6Qx+sno75DcAoWv85LAI0b0Z4dgNXz5W2DH6dPiAAixrmzF94oGjvpNQkdm1/3WfFVapHhSf6XJR3qM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Qat2e1qx; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Qat2e1qx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 013321F0089B; Mon, 12 Oct 2026 21:41:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791841280; bh=uclfDJqxVRuBwPN4wlb2dOjibX2hswNkqttKPgsmqvA=; h=Date:From:To:Cc:Subject:In-Reply-To; b=Qat2e1qx51JO0792wtYeHxWk+FmgNB/Bi97OyrQ7D97Gbxd9Ml6M3DCiXiJ29YchU qYjb+kePH+/6FWQDi5SlEpt748N8Se/nO4nIAdqaPG9gLEYXZK0E65CmwZ6tapvBlU eH+a0BadNVUm8Y+b9DIT+OJUnRzJlg5YyhcXuji57Fq5HcVdS60RyC/Mj5jwio6/KK qPXkYUoYQG/U9wmY1uGCk+TakPSSB9or8KrTGf+pRfXHozEYFIBqUlEHbhw81doaGy D68IldSl2EmOIqlyZme77lZXTPpAqZZ9RnWOIvU/pVkEmN7RqB5qG/qEYft3jX5Pyh jJvtXPS/AZ5Kg== Date: Mon, 12 Oct 2026 16:41:18 -0500 From: Bjorn Helgaas To: Imre Kaloz Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, Andreas Larsson , sparclinux@vger.kernel.org, "David S. Miller" , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] PCI: Avoid D3 on PLX PEX 8532/8533/8548 downstream ports Message-ID: <20261012214118.GA1398471@bhelgaas> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260927105609.8813-1-kaloz@kernel.org> On Sun, Sep 27, 2026 at 12:56:09PM +0200, Imre Kaloz wrote: > Runtime PM suspends an idle downstream port of a PLX/Broadcom PEX > 8532/8533/8548 switch to D3hot, but that takes the whole switch down > with it: any device behind another port of the same switch then > faults with a fatal bus error on its next access, e.g. mptsas probe > on a Sun Ultra 45. > > This surfaced on sparc64 once commit a5fb3ff63287 ("PCI: Allow PCI > bridges to go to D3Hot on all non-x86") let bridges enter D3hot. Keep > these downstream ports out of D3 by setting PCI_DEV_FLAGS_NO_D3. > > Fixes: a5fb3ff63287 ("PCI: Allow PCI bridges to go to D3Hot on all non-x86") > Cc: stable@vger.kernel.org > Signed-off-by: Imre Kaloz Applied to pci/pm for v7.4, thanks! > --- > drivers/pci/quirks.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > index de9bbccda21f..a3c9250182a6 100644 > --- a/drivers/pci/quirks.c > +++ b/drivers/pci/quirks.c > @@ -2381,6 +2381,24 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9050, > DECLARE_PCI_FIXUP_HEADER(0x1402, 0x2000, quirk_plx_pci9050); > DECLARE_PCI_FIXUP_HEADER(0x1402, 0x2600, quirk_plx_pci9050); > > +/* > + * An idle downstream port of a PLX/Broadcom PEX 8532/8533/8548 switch > + * autosuspends into D3hot, and that takes the whole switch down with > + * it -- any device behind another port of the same switch then sees a > + * fatal, non-recoverable bus fault on its next access. Keep these > + * ports out of D3 entirely. > + */ > +static void quirk_plx_pex_no_d3(struct pci_dev *dev) > +{ > + if (pci_pcie_type(dev) == PCI_EXP_TYPE_DOWNSTREAM) { > + dev->dev_flags |= PCI_DEV_FLAGS_NO_D3; > + pci_info(dev, "avoiding D3 on this downstream port\n"); > + } > +} > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_PLX, 0x8532, quirk_plx_pex_no_d3); > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_PLX, 0x8533, quirk_plx_pex_no_d3); > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_PLX, 0x8548, quirk_plx_pex_no_d3); > + > static void quirk_netmos(struct pci_dev *dev) > { > unsigned int num_parallel = (dev->subsystem_device & 0xf0) >> 4; > > base-commit: fe2ec83746e501645709761605c2464a44fd2929 > -- > 2.47.3 >