From: "Rareș-Mihai Vladu" <vladurares@gmail.com>
To: Hans de Goede <hansg@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: "Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
"Rareș-Mihai Vladu" <vladurares@gmail.com>
Subject: [PATCH 0/4] media: atomisp: remove the circbuf library
Date: Mon, 12 Oct 2026 23:07:49 +0000 [thread overview]
Message-ID: <20261012230754.1914517-1-vladurares@gmail.com> (raw)
Thanks to Andy for suggesting, in review of my earlier typedef
patch [1], that I look at converting the custom circbuf code to
circ_buf or kfifo.
While looking into it, it turned out that the circbuf API is only
used by the local queue path, and ia_css_queue_local_init() has no
callers, so that path is unused. The remote queues only need the
descriptor and element layout shared with the SP firmware and a few
small helpers.
So this series removes the unused local path, moves those few pieces
into ia_css_queue_comm.h and drops base/circbuf/. Please let me know
if you would prefer a different approach and I will rework it.
Patch 3 only moves code, apart from dropping OP___assert(), so I did
not touch the existing style issues there.
Compile-tested only, as I don't have the hardware.
This supersedes the typedef patch [1].
[1] https://lore.kernel.org/all/20260918214132.1135549-1-vladurares@gmail.com/
Rareș-Mihai Vladu (4):
media: atomisp: sh_css_mipi: include assert_support.h directly
media: atomisp: queue: remove unused local queue support
media: atomisp: queue: move circbuf types and helpers to queue_comm.h
media: atomisp: remove unused circbuf library
drivers/staging/media/atomisp/Makefile | 2 -
.../base/circbuf/interface/ia_css_circbuf.h | 363 ------------------
.../circbuf/interface/ia_css_circbuf_comm.h | 56 ---
.../circbuf/interface/ia_css_circbuf_desc.h | 160 --------
.../atomisp/pci/base/circbuf/src/circbuf.c | 312 ---------------
.../runtime/queue/interface/ia_css_queue.h | 29 --
.../queue/interface/ia_css_queue_comm.h | 139 ++++++-
.../atomisp/pci/runtime/queue/src/queue.c | 112 +-----
.../pci/runtime/queue/src/queue_access.c | 1 -
.../pci/runtime/queue/src/queue_access.h | 4 +-
.../media/atomisp/pci/sh_css_internal.h | 2 +-
.../staging/media/atomisp/pci/sh_css_mipi.c | 1 +
12 files changed, 148 insertions(+), 1033 deletions(-)
delete mode 100644 drivers/staging/media/atomisp/pci/base/circbuf/interface/ia_css_circbuf.h
delete mode 100644 drivers/staging/media/atomisp/pci/base/circbuf/interface/ia_css_circbuf_comm.h
delete mode 100644 drivers/staging/media/atomisp/pci/base/circbuf/interface/ia_css_circbuf_desc.h
delete mode 100644 drivers/staging/media/atomisp/pci/base/circbuf/src/circbuf.c
--
2.43.0
next reply other threads:[~2026-10-12 23:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 23:07 Rareș-Mihai Vladu [this message]
2026-10-12 23:07 ` [PATCH 1/4] media: atomisp: sh_css_mipi: include assert_support.h directly Rareș-Mihai Vladu
2026-10-13 16:06 ` Andy Shevchenko
2026-10-12 23:07 ` [PATCH 2/4] media: atomisp: queue: remove unused local queue support Rareș-Mihai Vladu
2026-10-13 16:14 ` Andy Shevchenko
2026-10-12 23:07 ` [PATCH 3/4] media: atomisp: queue: move circbuf types and helpers to queue_comm.h Rareș-Mihai Vladu
2026-10-13 16:20 ` Andy Shevchenko
2026-10-12 23:07 ` [PATCH 4/4] media: atomisp: remove unused circbuf library Rareș-Mihai Vladu
2026-10-13 16:21 ` Andy Shevchenko
2026-10-13 7:38 ` [PATCH 0/4] media: atomisp: remove the " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261012230754.1914517-1-vladurares@gmail.com \
--to=vladurares@gmail.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®