From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ian Rogers <irogers@google.com>, Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
James Clark <james.clark@linaro.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-perf-users@vger.kernel.org
Subject: [PATCH v4 00/10] perf symbol: Properly seto DSO binary/symtab types
Date: Mon, 12 Oct 2026 16:46:44 -0700 [thread overview]
Message-ID: <20261012234654.60666-1-namhyung@kernel.org> (raw)
Hello,
Currently we have 3 types for a DSO.
* binary type: determines where to read binary instruction or data of the
DSO. Basically used by annotate. Some (special) DSOs like kallsyms or
JIT may not have the data though.
* symtab type: determines where to read symbol tables. Set when symbols
in the DSO are loaded.
* debug info type: determines where to read debug info. Used by srcline,
DWARF unwinding, data type profiling and so on. Often debug info is
saved in a separate file.
Some DSOs may have the same type for 3 and others can have all different.
Previously it generally assumed binary type would be same as symtab type
but now I think we should not and only set the binary type as it's used.
Also it should make sure that symtab type is set properly after loading
symbols in the DSO.
Probably this patchset won't make any practical difference in runtime
behaviors but I think it's good to track them accurately.
v4 changes)
* add Ian's Reviewed-by tags
* make sure to grab _dso__data_open_lock only once
* check open file count before closing the cache
* clear errno so that it won't have a stale value
v3: https://lore.kernel.org/r/20261012052601.13920-1-namhyung@kernel.org
* set KALLSYM type for split kallsyms DSOs
* take dso lock in dso__find_binary_type()
* handle EMFILE failures in dso__find_binary_type()
* drop the libbfd change as it need a separate patchset
* lookup binary type in dso__e_machine_endian()
* get rid of machine_or_dso_e_machine() due to a lock problem
* fixed a bug symbol__disassemble() for BPF and kcore
v2: https://lore.kernel.org/r/20261006234315.920817-1-namhyung@kernel.org
* add dso__find_binary_type() for checking ".text" section
* make perf annotate use the dso's binary type directly
v1: https://lore.kernel.org/r/20261005063411.114244-1-namhyung@kernel.org
Thanks,
Namhyung
Namhyung Kim (10):
perf tools: Remove redundant dso data init
perf tools: Try linked debug files for DSO debug info
perf symbol: Update symtab type of vmlinux from build-id cache
perf symbol: Set binary/symtab type for split kallsyms
perf symbol: Get rid of machine_or_dso_e_machine()
perf tools: Factor out dso__find_binary_type()
perf symbol: Set binary type for JIT map DSOs
perf symbol: Do not set binary type from symtab type
perf annotate: Simplify symbol__disassemble() with dso binary_type
perf test: Fix dso data tests
tools/perf/tests/dso-data.c | 7 ++
tools/perf/util/disasm.c | 124 ++++++-------------------------
tools/perf/util/dso.c | 143 ++++++++++++++++++++++++++++++++----
tools/perf/util/dso.h | 13 ++++
tools/perf/util/symbol.c | 50 ++++---------
5 files changed, 187 insertions(+), 150 deletions(-)
--
2.56.0.385.gd3acb90ef8-goog
next reply other threads:[~2026-10-12 23:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 23:46 Namhyung Kim [this message]
2026-10-12 23:46 ` [PATCH v4 01/10] perf tools: Remove redundant dso data init Namhyung Kim
2026-10-12 23:46 ` [PATCH v4 02/10] perf tools: Try linked debug files for DSO debug info Namhyung Kim
2026-10-12 23:46 ` [PATCH v4 03/10] perf symbol: Update symtab type of vmlinux from build-id cache Namhyung Kim
2026-10-12 23:46 ` [PATCH v4 04/10] perf symbol: Set binary/symtab type for split kallsyms Namhyung Kim
2026-10-12 23:46 ` [PATCH v4 05/10] perf symbol: Get rid of machine_or_dso_e_machine() Namhyung Kim
2026-10-12 23:46 ` [PATCH v4 06/10] perf tools: Factor out dso__find_binary_type() Namhyung Kim
2026-10-12 23:46 ` [PATCH v4 07/10] perf symbol: Set binary type for JIT map DSOs Namhyung Kim
2026-10-12 23:46 ` [PATCH v4 08/10] perf symbol: Do not set binary type from symtab type Namhyung Kim
2026-10-12 23:46 ` [PATCH v4 09/10] perf annotate: Simplify symbol__disassemble() with dso binary_type Namhyung Kim
2026-10-12 23:46 ` [PATCH v4 10/10] perf test: Fix dso data tests Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261012234654.60666-1-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®