From: Ian Rogers <irogers@google.com>
To: acme@kernel.org, namhyung@kernel.org
Cc: irogers@google.com, 9erthalion6@gmail.com,
adrian.hunter@intel.com, james.clark@linaro.org,
jolsa@kernel.org, leo.yan@arm.com, linux-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org, mingo@redhat.com,
peterz@infradead.org
Subject: [PATCH v4 0/3] perf test: Per-test timeouts, JUnit XML compliance, and snippet improvements
Date: Mon, 12 Oct 2026 16:47:21 -0700 [thread overview]
Message-ID: <20261012234724.721224-1-irogers@google.com> (raw)
In-Reply-To: <20260929025345.88829-1-irogers@google.com>
This series adds per-test timeout support to 'perf test', improves JUnit
XML output to validate against strict JUnit schemas, and refines the
verbose=1 failure snippet output when tests fail with a signal or time
out:
1. Add a per-test timeout (default 60s, configurable via '-t'/'--timeout',
0 to disable, disabled with '-F'/'--dont-fork'). Forked tests run in
their own process groups and the existing polling loops in
finish_test() and finish_tests_parallel() check elapsed runtimes,
sending SIGTERM on timeout and escalating to SIGKILL after 1 second.
Timed out tests are reported as 'TIMEOUT!', listed in the summary,
and recorded as '<error message="TIMEOUT" type="timeout">' in JUnit
XML output.
2. Update 'perf test -j' output to validate cleanly against both the
Apache Ant/Windy Road JUnit schema (JUnit.xsd) and the Jenkins
xUnit/Maven Surefire schema (junit-10.xsd), including required
'<testsuite>' attributes, '<properties>' from uname, '<system-out/>'
and '<system-err/>', self-closing tags, apostrophe escaping, and
UTF-8/XML 1.0 codepoint validation.
3. Improve verbose=1 failure snippet selection in
print_test_failure_snippet() to skip blank and stack trace lines
when selecting context and scanning backwards from the end of the
log, and prioritize the test output line immediately preceding
'---- unexpected signal' so trailing test progress is shown instead
of outermost stack frames.
v4:
- Drop the ITIMER_REAL timer and SIGALRM handler in patch 1, relying on
the existing 10ms/100ms polling loops in finish_test() and
finish_tests_parallel() to detect timeouts.
- Only fall back to kill(pid, sig) when kill(-pid, sig) fails, and
ignore SIGTERM/SIGINT while waiting for subprocesses in
run_test_child().
- Add patch 3 to avoid stack trace noise in verbose=1 failure snippets.
v3:
- Block SIGINT/SIGTERM while a test process may be reaped and until its
pid is cleared, and skip already reaped tests in the signal path.
v2:
- Reset SIGALRM to SIG_DFL in the forked test child.
- Replace the blocking waitpid(-1) loop with a bounded, non-blocking
wait that only runs when interrupted by SIGTERM/SIGINT.
- Ensure the SIGKILL escalation reaches the whole process group before
the zombie is reaped.
- Factor out timespec_diff_secs() and TEST_KILL_GRACE_SECS.
Ian Rogers (3):
perf test: Add per-test timeout support
perf test: Improve JUnit XML schema compliance and completeness
perf test: Avoid stack trace noise in verbose=1 failure snippets
tools/perf/Documentation/perf-test.txt | 12 +-
tools/perf/tests/builtin-test.c | 668 +++++++++++++++++++------
tools/perf/tests/tests.h | 7 +-
3 files changed, 543 insertions(+), 144 deletions(-)
--
2.56.0.385.gd3acb90ef8-goog
next prev parent reply other threads:[~2026-10-12 23:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 21:01 [PATCH v1 1/2] perf test: Add per-test timeout support Ian Rogers
2026-09-28 21:01 ` [PATCH v1 2/2] perf test: Improve JUnit XML schema compliance and completeness Ian Rogers
2026-09-29 1:18 ` [PATCH v2 1/2] perf test: Add per-test timeout support Ian Rogers
2026-09-29 1:18 ` [PATCH v2 2/2] perf test: Improve JUnit XML schema compliance and completeness Ian Rogers
2026-09-29 2:53 ` [PATCH v3 1/2] perf test: Add per-test timeout support Ian Rogers
2026-09-29 2:53 ` [PATCH v3 2/2] perf test: Improve JUnit XML schema compliance and completeness Ian Rogers
2026-10-05 22:44 ` [PATCH v3 1/2] perf test: Add per-test timeout support Namhyung Kim
2026-10-12 21:57 ` Ian Rogers
2026-10-12 23:47 ` Ian Rogers [this message]
2026-10-12 23:47 ` [PATCH v4 1/3] " Ian Rogers
2026-10-12 23:47 ` [PATCH v4 2/3] perf test: Improve JUnit XML schema compliance and completeness Ian Rogers
2026-10-12 23:47 ` [PATCH v4 3/3] perf test: Avoid stack trace noise in verbose=1 failure snippets Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261012234724.721224-1-irogers@google.com \
--to=irogers@google.com \
--cc=9erthalion6@gmail.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=leo.yan@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®