From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B89DC4D0A11; Tue, 13 Oct 2026 09:46:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791884785; cv=none; b=aTm9sYP0OiN4GeNaZyr+Wjto0r7GtnOD7oKlqqc9CQ7nFc4OGektv0kkDzb3JL314EfB6oEiAKqo/r8zMnM3NEevxjjnltjeCnEHm9YrW4X9O+w2DgiF4mb5Fuutc+OU0MS/U+ULZSsWNpmiN1l75s1v2r/V1UGrhvZzaboc6RM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791884785; c=relaxed/simple; bh=Dvxi4UcnV8EfMkMwlagrsaj+FJ236sNPUc/9icWdcFk=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=cLEuJimafMkA28SM5bCcUgHABSvJZBK2vGmysrubXRT667PikRCGfTZnOk61Y5XbvtjHSwzDY1Bt2kRql6pkfgWciHo4wfn99LC7TkB7TPK4J9SEPW9eNtmNUYYTxtmlDffGdzN9ALDazvLWlNZXRMAIwEs7McFXs261ivpAjNM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=fpMCc4pA; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="fpMCc4pA" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 75711169C; Tue, 13 Oct 2026 02:46:15 -0700 (PDT) Received: from e129823.arm.com (e129823.arm.com [10.2.213.3]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 35DA83F7B4; Tue, 13 Oct 2026 02:46:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1791884778; bh=Dvxi4UcnV8EfMkMwlagrsaj+FJ236sNPUc/9icWdcFk=; h=From:Subject:Date:To:Cc:From; b=fpMCc4pADCI0HrdE+ZF9uvoVHRBECnNlp2ZP7hfrVwJxvzQOaG4GipyUglyz/Smk8 wGcZ1FdG7swfYPiEJe1TGJYfewAT5qP2vAN91b8fcSHQahPB+wkvpE5U+Y/NMrZQLr q4iIkQLF47fM4CHscSQglHFA8C7l2ZMktS7Fm8I0= From: Yeoreum Yun Subject: [PATCH v6 0/3] kselftest: mm: remove HPAGE_SIZE and HPAGE_SHIFT macro Date: Tue, 13 Oct 2026 10:46:03 +0100 Message-Id: <20261013-fix_hpage_macro-v6-0-2c52d0484de3@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIANv9zWoC/23PywrCMBAF0F8pWRuZNkk1rvwPkTIk0zaLPkgkK KX/blrEB3V5hzl3mIkF8o4CO2UT8xRdcEOfQrnLmGmxb4g7mzIroChBg+a1u1ftiA1VHRo/cIt QaiSQCgqW1OgprayNl2vKrQu3wT/WA1Es01dXLjddUXDgRqMAhZBboc/ou70ZOrY0Rfmli3yr5 aItoaxNaUjUv1q9dQ5//ogqaSXF4YgkFVr70fM8PwEGfqPsKAEAAA== To: Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Usama Arif , Kiryl Shutsemau , Peter Xu , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Andrew Morton , David Hildenbrand , Shuah Khan , Jason Gunthorpe , Leon Romanovsky , Sarthak Sharma , Yeoreum Yun X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=5863; i=yeoreum.yun@arm.com; h=from:subject:message-id; bh=Dvxi4UcnV8EfMkMwlagrsaj+FJ236sNPUc/9icWdcFk=; b=owEB7QES/pANAwAKAW3Vw9FaxTEzAcsmYgBqzf3k5yZXNxhcjn69gl72vzxL2PDv8otU5cYDj pJUiOBTpKWJAbMEAAEKAB0WIQQtg+CS3QUzuFh1pJ1t1cPRWsUxMwUCas395AAKCRBt1cPRWsUx M1glC/9Senkz41a/iONu85NMt4pbyr3nsZaJ1YqwpUDkc8RJPaX3JXZvXWqkSyGQFDscQq8fR7s GiMDFWQNqEcHKhKUbPOgMAbJKWChoGTpGg+Vorvor2Yn0u7k4htFeGX/AJAUGlezOEy6y/BCKjd 5SI8H5sYvALoDb2ZhhC87xcgFvkc7I9WHs4qvjhwO88Y4PRffkuPGWBHix41o1rMTMNXE0pumni sLUA3vOm8pNMWWNlp7puZZonQhCeySD5tUdCRLr1/JpNcPpDeF4H0BYHHd8Dy6bUF45lII27y7E cYitYQmOvoptgSpEqSJ2HFURKDDnB4hZU4VO0uJD2gUxM2pyUDjqfXLa6fXXIQjUeubeckKZRz1 gDhKeqy+lEkvX935rxXjv2GWWoYOelcDn8ESXWrA4rSOboQnJKcPPyZQupv0UDphAsbl+b1426a M9BVMwlze4wiMSZ1bB+ai5LJSrTpll7GcuVY4J60kHoZYokPHSJQYuSX08sreCpcQoG6Q= X-Developer-Key: i=yeoreum.yun@arm.com; a=openpgp; fpr=2D83E092DD0533B85875A49D6DD5C3D15AC53133 HPAGE_SIZE and HPAGE_SHIFT macro is written based on the 4KB PAGE_SIZE. When this macro is used in some test, test result would be strange in the system where PAGE_SIZE is more then 4KB. Here is the example with transhuge-stress test with 16KB PAGE_SIZE: transhuge-stress: allocate 61073 transhuge pages, using 122146 MiB virtual memory and 1908 MiB of ram 3.292 s/loop, 0.054 ms/page, 37106.002 MiB/s 2566 succeed, 58507 failed, 2566 different pages 0.591 s/loop, 0.010 ms/page, 206850.792 MiB/s 0 succeed, 61073 failed, 0 different pages 0.527 s/loop, 0.009 ms/page, 231895.107 MiB/s 0 succeed, 61073 failed, 0 different pages 3.292 s/loop, 0.054 ms/page, 37106.002 MiB/s 2566 succeed, 58507 failed, 2566 different pages 0.591 s/loop, 0.010 ms/page, 206850.792 MiB/s 0 succeed, 61073 failed, 0 different pages 0.527 s/loop, 0.009 ms/page, 231895.107 MiB/s 0 succeed, 61073 failed, 0 different pages 0.527 s/loop, 0.009 ms/page, 231839.704 MiB/s 0 succeed, 61073 failed, 0 different pages 0.528 s/loop, 0.009 ms/page, 231544.782 MiB/s 0 succeed, 61073 failed, 0 different pages 0.528 s/loop, 0.009 ms/page, 231462.074 MiB/s 0 succeed, 61073 failed, 0 different pages 0.527 s/loop, 0.009 ms/page, 231770.300 MiB/s 0 succeed, 61073 failed, 0 different pages ... ok 1 Completed To address this, remove the HPAGE_SIZE and HPAGE_SHIFT macro, introduce pmd_pshift() and rename read_pmd_pagesize() to pmd_psize() to keep consistency with psize() and pshift(). Also, run the KSM_MERGE_TIME_HUGE_PAGES test with a size of 512 MiB, which is the least common multiple of the PMD sizes for 4 KiB, 16 KiB, and 64 KiB base pages. Since allocate_transhuge() allocates mappings in PMD-sized units, the test may fail with the previous size of 100 MiB, which is not a multiple of the PMD size when the base page size is 16 KiB or 64 KiB. After this patch, output of transhuge-stress: transhuge-stress: allocate 3817 transhuge pages, using 122146 MiB virtual memory and 119 MiB of ram 2.558 s/loop, 0.670 ms/page, 47755.759 MiB/s 2585 succeed, 1232 failed, 2585 different pages 2.640 s/loop, 0.692 ms/page, 46268.432 MiB/s 2585 succeed, 1232 failed, 2585 different pages 2.635 s/loop, 0.690 ms/page, 46360.298 MiB/s 2585 succeed, 1232 failed, 2585 different pages 2.782 s/loop, 0.729 ms/page, 43899.795 MiB/s 2616 succeed, 1201 failed, 2616 different pages 2.692 s/loop, 0.705 ms/page, 45380.876 MiB/s 2627 succeed, 1190 failed, 2627 different pages 2.612 s/loop, 0.684 ms/page, 46765.812 MiB/s 2628 succeed, 1189 failed, 2628 different pages 2.683 s/loop, 0.703 ms/page, 45520.990 MiB/s 2630 succeed, 1187 failed, 2630 different pages 2.727 s/loop, 0.714 ms/page, 44789.321 MiB/s 2631 succeed, 1186 failed, 2631 different pages ... ok 1 Completed Additionally, introduce size_to_shift() for future users that need to obtain shift of a huge-page which is other than pmd_psize(). Patch History ============= Changes in v6: - add r-b tags. - small change for declaration order. - Link to v5: https://lore.kernel.org/r/20261009-fix_hpage_macro-v5-0-54378ae45add@arm.com Changes in v5: - rebase to mm/mm-unstable - Link to v4: https://lore.kernel.org/r/20260921-fix_hpage_macro-v4-0-cdea4fc6ce3f@arm.com Changes in v4: - make size_to_shift() as inline function. - initialise __pmd_psize and __pmd_pshift with -1ull. - Link to v3: https://lore.kernel.org/r/20260914-fix_hpage_macro-v3-0-c9a305a01d39@arm.com Change in v3: - rename read_pmd_pagesize() to pmd_psize() - introduce size_to_shift() - Link to v2: https://lore.kernel.org/all/20260907081509.924979-1-yeoreum.yun@arm.com/ Chnage in v2: - rename hpage_* to pmd_page_* - Link to v1: https://lore.kernel.org/all/20260902175611.1241118-1-yeoreum.yun@arm.com/#t --- Yeoreum Yun (3): kselftest: mm: rename read_pmd_pagesize() to pmd_psize() kselftest: mm: remove HPAGE_SIZE and HPAGE_SHIFT macro kselftest: mm: introduce size_to_shift() helper tools/testing/selftests/mm/cow.c | 2 +- tools/testing/selftests/mm/folio_split_race_test.c | 2 +- tools/testing/selftests/mm/guard-regions.c | 10 ++++-- tools/testing/selftests/mm/hmm-tests.c | 22 ++++++------ tools/testing/selftests/mm/khugepaged.c | 2 +- tools/testing/selftests/mm/khugepaged_race.c | 2 +- tools/testing/selftests/mm/khugepaged_sync_check.c | 2 +- tools/testing/selftests/mm/ksm_tests.c | 16 +++++---- tools/testing/selftests/mm/migration.c | 4 +-- tools/testing/selftests/mm/mkdirty.c | 2 +- tools/testing/selftests/mm/pagemap_ioctl.c | 2 +- tools/testing/selftests/mm/prctl_thp_disable.c | 4 +-- tools/testing/selftests/mm/process_madv.c | 2 +- tools/testing/selftests/mm/run_vmtests.sh | 4 +-- tools/testing/selftests/mm/soft-dirty.c | 2 +- tools/testing/selftests/mm/split_huge_page_test.c | 2 +- tools/testing/selftests/mm/transhuge-stress.c | 25 +++++++------ tools/testing/selftests/mm/uffd-common.c | 6 ++-- tools/testing/selftests/mm/uffd-unit-tests.c | 8 ++--- tools/testing/selftests/mm/uffd-wp-mremap.c | 2 +- tools/testing/selftests/mm/vm_util.c | 42 ++++++++++++++++++---- tools/testing/selftests/mm/vm_util.h | 23 ++++++++---- 22 files changed, 119 insertions(+), 67 deletions(-) --- base-commit: 7186f1bd21b9094cc063c10f8492fd135522d3cb change-id: 20260909-fix_hpage_macro-da069ae04502 Best regards, -- Sincerely, Yeoreum Yun