From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51B4A52B1D4 for ; Tue, 13 Oct 2026 15:17:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791904677; cv=none; b=nzaDDfp/o3rB/u+4aCdl+7JcqrAgr7KCSp3VwOpckCcFrraQ/WH+ogJx+1Mj1HBivXdNksw3ee73CeAfCHackDqfqO3Mw7RJfpbk1iXDZ/MP68cQCm/RITx941Tib6LVFlVqyaaQ85Xei/zZBiCrZPvr4xM51NvlDXss4ew1nR4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791904677; c=relaxed/simple; bh=/Pg/lA+PGGTUTaRSb2VAfe+AADNa7ZquSZST8Ot6lWI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JbnrsG1f5eRelmmT2iObpMdeG+dFBxyATWC0cFIg07305h//GLtvXGni+CCwxiiGKQxIuAVKctVJZUYddx6g9dqS+PRq9Yne11sGIi5HhO+65zV7IFGKdilIlDZx7xZTunzpgrcbJf1nhaG2CSdeuUgtDSz+WhsNgksotz2B0kc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=raspberrypi.com; spf=pass smtp.mailfrom=raspberrypi.com; dkim=pass (2048-bit key) header.d=raspberrypi.com header.i=@raspberrypi.com header.b=hIDLkT/L; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=raspberrypi.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=raspberrypi.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="hIDLkT/L" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4a01933b584so27653095e9.0 for ; Tue, 13 Oct 2026 08:17:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1791904672; x=1792509472; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1awOQo0azi8UyO4z3KRKovMgsi0c6QrgcvRhbUh0t1Y=; b=hIDLkT/L0Wnt4t9H3MJQkrIxFoT1xAtvPyarz3NLcZ+TqioNMsHEM1gGT/PnaCx8ct bQZjRhnbjhWi+QAwfIqEj4uz4n1A5dgna2fhfEEMgci8+r5X9HDpwMeuxp5ELSCnG/0G ejdKscrULw+HYGrHD60UME4XJQrBJI9tJ3lZCy/kM3ezxSelxRwhoslIDDOIdTWs57jd atJlyNk5t9TDW/AkGO4csR3sduiQ/rk77//EhFcjpsseUpVHeaUNdAEsSLaBw+87NZ0E bxedCG247AEZBtFNVKwjRFJ5wf4Ix1bODR68BVGmbny2rDQwvZyG9H0Y4LuuR4jyj0nH k7AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791904672; x=1792509472; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1awOQo0azi8UyO4z3KRKovMgsi0c6QrgcvRhbUh0t1Y=; b=Zt8bZc4wVkiNE8TV9PMTUnEBiJhJq5Muo0IycxfXOsa74VPwVa+FTekrhHFT5jUv9U uynhT5iwRJDqwaT7chNIXZRSjMh/2brZnUuE4Pi5Mg1GX3SGGCdMWL573C+BU5yQYlum +bj6jSv6SJW9FCgM3r+hvBsgpjBt2ljEhpP9gf4sNaIOtm4qV5gxm89OAfswz9tTBtiS PDNXEci+gkb8uE4dnnU5LovsJ0wgZImXKcpyg9MZf6eHZJYgf+PnTsJEB4/PmrKVbgyP QtztfLXgy8qKISegED1sHEzD6VjMklRDeBw/K6EZ3+zUxWlfS8GipFXz9U77Bl++FBmU ZaAw== X-Forwarded-Encrypted: i=1; AKwUvByQSNDTOzzhtiAwLmH+p7LuyppsqGH6rsQMP8zh1VCSpvmScCSiJTjqAqBbBrCj+CpxOCgxf55QTs3JiV4=@vger.kernel.org X-Gm-Message-State: AFq9FYIOl679XN/4nWo2WVoYk41O/43yiL4h0BNToR0VuOJ4cyP3kDv7 hxX8Q1cgK+lzQoiai+A70TOskWCLO1142e0AVxBFRY/QLDewZTWbgHcBFn3dI9is9MM= X-Gm-Gg: AYBFou1Jby3WP2UGk/Mv9zmvbuORM4EIhPgI3FIsLP6U4lX0n9N2VxSYlPGHA+liPIy ULqw9Fbt0DPrPBStfZICaP6SLzHAxCnd9IHGxZjAvmAU3xrUA1dZk/Ag8wXotBE2jnnCaSFo0XX iopmD4wHD+NDSKYzY+Q3R0dean4odF8cusVFONgwrFTjySr1ENyK2PYUyYtZqlBCMXdGwUXsCEN KoD+Zo7H4jLPSdzgSDUdvt0MhOZLQcqBfSfpqseAprJLdqHXLhzZULf/VmJuYXmI5ftc3OBV0Dd Y+nt5eDDTHwBhwke/SChhftVaae5tjuXkANIPFYbVYvIR4BMFXgGiAo4C4htjVu6vp6PEQmUrne kePyXw6x4+v95ES6v9d5X0r7ZShTSNgnFvJzMdTBIbNpXwq1lOOg3ZIHAq/kmRTHB7x8bDHk0x1 TfveCsN2LwXTa7CIqqd4KXKWFE0iabhWygONBoVcb5Gy5JSmSxU7Vrl7UOunNIctjB9VUU5g5n3 dY3LIeNgU0SeAxRUCsJBfAt9aV7dPwJUmhgCBSnjq8NAwBpyQ== X-Received: by 2002:a05:600c:1e0f:b0:4a0:1f51:ba2d with SMTP id 5b1f17b1804b1-4a18e4adcbamr242423375e9.22.1791904672279; Tue, 13 Oct 2026 08:17:52 -0700 (PDT) Received: from [127.0.1.1] ([2a00:1098:3142:e::8]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-48de0aaabb8sm6529743f8f.15.2026.10.13.08.17.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Oct 2026 08:17:51 -0700 (PDT) From: Dave Stevenson Date: Tue, 13 Oct 2026 16:17:11 +0100 Subject: [PATCH v2 12/13] media: sony-starvis2: Only update bits for window mode Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261013-media-starvis2-v2-12-3670722d250a@raspberrypi.com> References: <20261013-media-starvis2-v2-0-3670722d250a@raspberrypi.com> In-Reply-To: <20261013-media-starvis2-v2-0-3670722d250a@raspberrypi.com> To: Sakari Ailus , Jai Luthra , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Laurent Pinchart , Alexander Shiyan , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Dave Stevenson X-Mailer: b4 0.14.1 IMX585 requires bit 4 of the WINMODE register (0x3018) to be set, whilst the bottom nibble selects between all-pixel and window mode. Switch to using cci_update_bits so that only the bottom nibble is updated, thereby working on all supported Starvis2 sensors. Signed-off-by: Dave Stevenson --- drivers/media/i2c/sony-starvis2.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/sony-starvis2.c b/drivers/media/i2c/sony-starvis2.c index 1a2a5d45bcc5..1ce2b86c57ac 100644 --- a/drivers/media/i2c/sony-starvis2.c +++ b/drivers/media/i2c/sony-starvis2.c @@ -88,6 +88,7 @@ /* Crop */ #define STARVIS2_REG_WINMODE CCI_REG8(0x3018) +#define STARVIS2_REG_WINMODE_MASK 0x0f #define STARVIS2_REG_PIX_HST CCI_REG16_LE(0x303c) #define STARVIS2_REG_PIX_HWIDTH CCI_REG16_LE(0x303e) #define STARVIS2_REG_PIX_VST CCI_REG16_LE(0x3044) @@ -1455,7 +1456,8 @@ static int starvis2_program_window(struct starvis2 *starvis2, int ret = 0; cci_write(starvis2->cci, STARVIS2_REG_ADDMODE, 0x00, &ret); - cci_write(starvis2->cci, STARVIS2_REG_WINMODE, 0x04, &ret); + cci_update_bits(starvis2->cci, STARVIS2_REG_WINMODE, + STARVIS2_REG_WINMODE_MASK, 0x04, &ret); cci_write(starvis2->cci, STARVIS2_REG_PIX_HST, crop->left - starvis2->variant->active_area.left, &ret); cci_write(starvis2->cci, STARVIS2_REG_PIX_HWIDTH, crop->width, &ret); -- 2.34.1