mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guanglei Zhu <zhugl3@xiaopeng.com>
To: Jan Kara <jack@suse.cz>
Cc: Theodore Ts'o <tytso@mit.edu>,
	linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
	guozh23@xiaopeng.com
Subject: Re: [PATCH] ext4: check CAP_SYS_ADMIN in ext4_ioctl_get_tune_sb()
Date: Tue, 13 Oct 2026 10:01:45 +0800	[thread overview]
Message-ID: <20261013020145.1297074-1-zhugl3@xiaopeng.com> (raw)
In-Reply-To: <20261012060844.836001-1-zhugl3@xiaopeng.com>

I checked the original series (20250916-tune2fs-v2): neither the
commit message of 04a91570ac67 nor the discussion around it says
anything about a permission policy for the GET side - the only
statement is that the ioctls allow parameters to be changed while
the file system is mounted, without needing write access to the
block device.

You are probably right that reading these parameters is not
sensitive on its own: most of them are already visible through
/proc/mounts or statfs(), and the superblock is readable by anyone
with read access to the block device.  The argument of my patch was
the asymmetry with the SET side rather than an actual leak.

I'm happy to drop this patch if Ted confirms that the missing check
was deliberate.

  parent reply	other threads:[~2026-10-13  2:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-12  6:08 Guanglei Zhu
2026-10-12 10:15 ` Jan Kara
2026-10-13  2:01 ` Guanglei Zhu [this message]
2026-10-13  3:30   ` Theodore Tso
2026-10-13  6:55   ` Guanglei Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261013020145.1297074-1-zhugl3@xiaopeng.com \
    --to=zhugl3@xiaopeng.com \
    --cc=guozh23@xiaopeng.com \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®