From: Biplab Raut <Biplab.Raut@amd.com>
To: <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>
Cc: <akpm@linux-foundation.org>, <hsiangkao@linux.alibaba.com>,
<terrelln@fb.com>, <yann.collet.73@gmail.com>,
<guoxuenan@huawei.com>, <Biplab.Raut@amd.com>
Subject: [PATCH] lib/lz4: add software-pipelined prefetch to decode fast loop
Date: Tue, 13 Oct 2026 03:20:10 +0000 [thread overview]
Message-ID: <20261013032010.2453893-1-Biplab.Raut@amd.com> (raw)
From: "S. Biplab Raut" <Biplab.Raut@amd.com>
LZ4 decompression of cold 4 KiB pages (the zswap/zram hot path) stalls
on cache misses because the input stream (compressed) and output buffer
(uncompressed page) are not resident in L1/L2. Insert read-ahead and
write-intent prefetch hints at the top of the decode loop in
LZ4_decompress_generic() to overlap memory latency with decode work.
The prefetch distances (96 B read, 128 B write) are tuned for the
page-at-a-time workload where both buffers fit in L1d. Prefetch is
architecturally a no-op hint on all Linux-supported architectures;
it never faults, never changes correctness, and compiles to nothing
on targets without hardware prefetch.
Measured on AMD EPYC 9755 (Turin, 2S×128C), Ubuntu 24.04, kernel
6.8.0-90-generic, real zswap path (cgroup-constrained MADV_PAGEOUT +
full scan-back), Silesia corpus, 15 paired rounds:
Kernel LZ4 median scan: 1.0994 s
Patched median scan: 1.0472 s
Median paired speedup: 5.09% (range 4.19%–6.99%)
Patched was faster in all 15 rounds.
Signed-off-by: S. Biplab Raut <Biplab.Raut@amd.com>
---
lib/lz4/lz4_decompress.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/lib/lz4/lz4_decompress.c b/lib/lz4/lz4_decompress.c
index 3a2cd9acada4..efbbde7ae58d 100644
--- a/lib/lz4/lz4_decompress.c
+++ b/lib/lz4/lz4_decompress.c
@@ -37,6 +37,7 @@
#include <linux/init.h>
#include <linux/module.h>
#include <linux/kernel.h>
+#include <linux/prefetch.h>
#include <linux/unaligned.h>
/*-*****************************
@@ -122,6 +123,26 @@ static FORCE_INLINE int LZ4_decompress_generic(
const BYTE *match;
size_t offset;
+ /*
+ * Software-pipelined prefetch hints. On the zswap/zram
+ * hot path, both the compressed input and the output page
+ * are cold (just faulted in or freshly allocated). Prime
+ * the L1d for the next loop iteration so that the actual
+ * loads/stores hit warm cache lines.
+ *
+ * Distances are tuned for 4 KiB page-at-a-time workloads:
+ * 96 B read-ahead on ip ~ 6 tokens ahead
+ * 128 B write-intent on op ~ 2 long-literal copies ahead
+ * 192 B deeper read-ahead ~ covers the match-copy tail
+ *
+ * prefetch() / prefetchw() are architecture-portable hints
+ * that compile to NOP on targets without HW prefetch. They
+ * never fault, even past buffer boundaries.
+ */
+ prefetch(ip + 96);
+ prefetchw(op + 128);
+ prefetch(ip + 192);
+
/* get literal length */
unsigned int const token = *ip++;
length = token>>ML_BITS;
--
2.43.0
next reply other threads:[~2026-10-13 3:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 3:20 Biplab Raut [this message]
2026-10-13 3:32 ` Andrew Morton
2026-10-14 8:50 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261013032010.2453893-1-Biplab.Raut@amd.com \
--to=biplab.raut@amd.com \
--cc=akpm@linux-foundation.org \
--cc=guoxuenan@huawei.com \
--cc=hsiangkao@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=terrelln@fb.com \
--cc=yann.collet.73@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®