mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: syzbot <syzbot+6835d5c11145e4f77057@syzkaller.appspotmail.com>,
	linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@kernel.org>,
	Radu Rendec <radu@rendec.net>, Ingo Molnar <mingo@redhat.com>,
	Juri Lelli <juri.lelli@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
	Valentin Schneider <vschneid@redhat.com>,
	K Prateek Nayak <kprateek.nayak@amd.com>
Subject: Re: [RFC PATCH v2] sched: irq: cpu-hotplug race vs set_cpus_allowed_ptr()
Date: Tue, 13 Oct 2026 08:46:17 +0200	[thread overview]
Message-ID: <20261013064617.jw7Sk6un@linutronix.de> (raw)
In-Reply-To: <20261012143047.GV2009045@noisy.programming.kicks-ass.net>

On 2026-10-12 16:30:47 [+0200], Peter Zijlstra wrote:
> >   There is nothing that waits for the interrupt thread to complete,
> >   there is no synchronize_irq() invocation which would be required for
> >   the deadlock to happen.
> 
> But any other set_cpus_allowed_ptr() call in the kernel can suffer the
> same problem, no? Why is the irq thing 'special'?

Not saying this is special.

> I am struggling to follow along. The actual fail scenario is a
> combination of hotplug *and* migrate_disable()? Can we get a picture?

let me grab the reproducer and a few tracepoints to make an accurate
drawing.

> A CPU must not be able to go offline while there are migrate_disable()
> tasks on it. Are you saying the migrate_disable() happens after hotplug
> already marks the CPU offline?

I *think* there were no tasks on it. So based on fading out memory:
T on CPU0 in migrate_disable(), assigned to CPU1, schedule().
CPU1 about to go down while the T on CPU0 returns does
migrate_enable() and should migrate to CPU1.
But this old memory. Let me get the reproducer and get back to you.

Sebastian

  reply	other threads:[~2026-10-13  6:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-12 10:39 Sebastian Andrzej Siewior
2026-10-12 14:19 ` Juri Lelli
2026-10-12 14:30 ` Peter Zijlstra
2026-10-13  6:46   ` Sebastian Andrzej Siewior [this message]
2026-10-13 13:43     ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261013064617.jw7Sk6un@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=radu@rendec.net \
    --cc=rostedt@goodmis.org \
    --cc=syzbot+6835d5c11145e4f77057@syzkaller.appspotmail.com \
    --cc=tglx@kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®