From: Juerg Haefliger <juerg.haefliger@canonical.com>
To: Abel Vesa <abel.vesa@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Abel Vesa <abelvesa@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: hp-elitebook-ultra-g1q: Drop omnibook-x14.dts include
Date: Tue, 13 Oct 2026 07:38:56 +0200 [thread overview]
Message-ID: <20261013073856.40fc2cec@smeagol.fritz.box> (raw)
In-Reply-To: <3hc574blvlfxelyvrki27dc3pjabf36vc3jh7muiisz7cjuvbd@qv5cjqvao6he>
[-- Attachment #1: Type: text/plain, Size: 841 bytes --]
On Fri, 9 Oct 2026 22:11:56 +0300
Abel Vesa <abel.vesa@oss.qualcomm.com> wrote:
> On 26-10-08 20:34:46, Juerg Haefliger via B4 Relay wrote:
> > From: Juerg Haefliger <juerg.haefliger@canonical.com>
> >
> > The EliteBook Ultra G1q is a different product from the OmniBook X14 that
> > happens to reuse the same mainboard, not a variant of it. As such, it
> > should not be a child of x1e80100-hp-omnibook-x14 but rather a sibling.
> > Include the shared base platform dtsi to match the other OmniBook X14s.
> >
> > Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
>
> You are also enabling the some remoteprocs, so please mention that in
> the commit message.
Done, v2 is on the list.
> With that fixed:
>
> Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
Thanks for the review!
...Juerg
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2026-10-13 5:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 18:34 [PATCH 0/2] arm64: dts: qcom: HP OmniBook X14 / EliteBook Ultra G1q cleanups Juerg Haefliger via B4 Relay
2026-10-08 18:34 ` [PATCH 1/2] arm64: dts: qcom: x1-hp-omnibook-x14: Consolidate pmics and chassis Juerg Haefliger via B4 Relay
2026-10-09 19:09 ` Abel Vesa
2026-10-08 18:34 ` [PATCH 2/2] arm64: dts: qcom: hp-elitebook-ultra-g1q: Drop omnibook-x14.dts include Juerg Haefliger via B4 Relay
2026-10-09 19:11 ` Abel Vesa
2026-10-13 5:38 ` Juerg Haefliger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261013073856.40fc2cec@smeagol.fritz.box \
--to=juerg.haefliger@canonical.com \
--cc=abel.vesa@oss.qualcomm.com \
--cc=abelvesa@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®