From: Wang Yibo <szwyb123@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Jennifer Guo <guojy.bj@gmail.com>,
Nikolay Kulikov <nikolayof23@gmail.com>
Subject: [PATCH] staging: rtl8723bs: remove commented out code in hal/ files
Date: Tue, 13 Oct 2026 17:29:08 +0800 [thread overview]
Message-ID: <20261013092908.380050-1-szwyb123@gmail.com> (raw)
Remove commented out code in a few hal/ source files, including
commented out switch case branches in odm.c, leftover debug statements
in odm_DIG.c and stale assignments in hal_intf.c.
The removed lines were already disabled and do not affect the generated
code.
Signed-off-by: Wang Yibo <szwyb123@gmail.com>
---
drivers/staging/rtl8723bs/hal/hal_intf.c | 4 ----
drivers/staging/rtl8723bs/hal/odm.c | 22 ----------------------
drivers/staging/rtl8723bs/hal/odm_DIG.c | 11 -----------
3 files changed, 37 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl8723bs/hal/hal_intf.c
index 1443875d1369..2a33bea9018c 100644
--- a/drivers/staging/rtl8723bs/hal/hal_intf.c
+++ b/drivers/staging/rtl8723bs/hal/hal_intf.c
@@ -120,14 +120,10 @@ int rtw_hal_mgnt_xmit(struct adapter *padapter, struct xmit_frame *pmgntframe)
int ret;
update_mgntframe_attrib_addr(padapter, pmgntframe);
- /* pframe = (u8 *)(pmgntframe->buf_addr) + TXDESC_OFFSET; */
- /* pwlanhdr = (struct rtw_ieee80211_hdr *)pframe; */
- /* memcpy(pmgntframe->attrib.ra, pwlanhdr->addr1, ETH_ALEN); */
if (padapter->securitypriv.binstallBIPkey) {
if (is_multicast_ether_addr(pmgntframe->attrib.ra)) {
pmgntframe->attrib.encrypt = _BIP_;
- /* pmgntframe->attrib.bswenc = true; */
} else {
pmgntframe->attrib.encrypt = _AES_;
pmgntframe->attrib.bswenc = true;
diff --git a/drivers/staging/rtl8723bs/hal/odm.c b/drivers/staging/rtl8723bs/hal/odm.c
index f3989fa33d9f..84edb6b5704e 100644
--- a/drivers/staging/rtl8723bs/hal/odm.c
+++ b/drivers/staging/rtl8723bs/hal/odm.c
@@ -445,7 +445,6 @@ static void odm_RSSIMonitorCheckCE(struct dm_odm_t *pDM_Odm)
FindMinimumRSSI(Adapter);/* get pdmpriv->MinUndecoratedPWDBForDM */
pDM_Odm->RSSI_Min = pdmpriv->MinUndecoratedPWDBForDM;
- /* ODM_CmnInfoUpdate(&pHalData->odmpriv , ODM_CMNINFO_RSSI_MIN, pdmpriv->MinUndecoratedPWDBForDM); */
}
static void odm_RSSIMonitorCheck(struct dm_odm_t *pDM_Odm)
@@ -515,7 +514,6 @@ void odm_TXPowerTrackingInit(struct dm_odm_t *pDM_Odm)
else
pdmpriv->TxPowerTrackControl = false;
- /* pDM_Odm->RFCalibrateInfo.TxPowerTrackControl = true; */
pDM_Odm->RFCalibrateInfo.ThermalValue = pHalData->EEPROMThermalMeter;
pDM_Odm->RFCalibrateInfo.ThermalValue_IQK = pHalData->EEPROMThermalMeter;
pDM_Odm->RFCalibrateInfo.ThermalValue_LCK = pHalData->EEPROMThermalMeter;
@@ -616,8 +614,6 @@ void ODM_DMWatchdog(struct dm_odm_t *pDM_Odm)
ODM_TXPowerTrackingCheck(pDM_Odm);
- /* odm_EdcaTurboCheck(pDM_Odm); */
-
/* 2010.05.30 LukeLee: For CE platform, files in IC subfolders may not be included to be compiled, */
/* so compile flags must be left here to prevent from compile errors */
pDM_Odm->PhyDbgInfo.NumQryBeaconPkt = 0;
@@ -804,24 +800,6 @@ void ODM_CmnInfoHook(struct dm_odm_t *pDM_Odm, enum odm_cmninfo_e CmnInfo, void
pDM_Odm->mp_mode = pValue;
break;
- /* case ODM_CMNINFO_RTSTA_AID: */
- /* pDM_Odm->pAidMap = (u8 *)pValue; */
- /* break; */
-
- /* case ODM_CMNINFO_BT_COEXIST: */
- /* pDM_Odm->BTCoexist = (bool *)pValue; */
-
- /* case ODM_CMNINFO_STA_STATUS: */
- /* pDM_Odm->pODM_StaInfo[] = (PSTA_INFO_T)pValue; */
- /* break; */
-
- /* case ODM_CMNINFO_PHY_STATUS: */
- /* pDM_Odm->pPhyInfo = (ODM_PHY_INFO *)pValue; */
- /* break; */
-
- /* case ODM_CMNINFO_MAC_STATUS: */
- /* pDM_Odm->pMacInfo = (struct odm_mac_status_info *)pValue; */
- /* break; */
/* To remove the compiler warning, must add an empty default statement to handle the other values. */
default:
/* do nothing */
diff --git a/drivers/staging/rtl8723bs/hal/odm_DIG.c b/drivers/staging/rtl8723bs/hal/odm_DIG.c
index c862c86b7695..12455e883200 100644
--- a/drivers/staging/rtl8723bs/hal/odm_DIG.c
+++ b/drivers/staging/rtl8723bs/hal/odm_DIG.c
@@ -68,8 +68,6 @@ void odm_NHMBBInit(void *pDM_VOID)
void odm_NHMBB(void *pDM_VOID)
{
struct dm_odm_t *pDM_Odm = (struct dm_odm_t *)pDM_VOID;
- /* u8 test_status; */
- /* struct false_ALARM_STATISTICS *pFalseAlmCnt = &pDM_Odm->FalseAlmCnt; */
pDM_Odm->NHMCurTxOkcnt =
*(pDM_Odm->pNumTxBytesUnicast)-pDM_Odm->NHMLastTxOkcnt;
@@ -83,7 +81,6 @@ void odm_NHMBB(void *pDM_VOID)
if ((pDM_Odm->NHMCurTxOkcnt) + 1 > (u64)(pDM_Odm->NHMCurRxOkcnt<<2) + 1) { /* Tx > 4*Rx possible for adaptivity test */
if (pDM_Odm->NHM_cnt_0 >= 190 || pDM_Odm->adaptivity_flag) {
/* Enable EDCCA since it is possible running Adaptivity testing */
- /* test_status = 1; */
pDM_Odm->adaptivity_flag = true;
pDM_Odm->tolerance_cnt = 0;
} else {
@@ -91,24 +88,19 @@ void odm_NHMBB(void *pDM_VOID)
pDM_Odm->tolerance_cnt = pDM_Odm->tolerance_cnt + 1;
else
pDM_Odm->tolerance_cnt = 4;
- /* test_status = 5; */
if (pDM_Odm->tolerance_cnt > 3) {
- /* test_status = 3; */
pDM_Odm->adaptivity_flag = false;
}
}
} else { /* TX<RX */
if (pDM_Odm->adaptivity_flag && pDM_Odm->NHM_cnt_0 <= 200) {
- /* test_status = 2; */
pDM_Odm->tolerance_cnt = 0;
} else {
if (pDM_Odm->tolerance_cnt < 3)
pDM_Odm->tolerance_cnt = pDM_Odm->tolerance_cnt + 1;
else
pDM_Odm->tolerance_cnt = 4;
- /* test_status = 5; */
if (pDM_Odm->tolerance_cnt > 3) {
- /* test_status = 4; */
pDM_Odm->adaptivity_flag = false;
}
}
@@ -586,7 +578,6 @@ void odm_DIGbyRSSI_LPS(void *pDM_VOID)
CurrentIGI = RSSI_Lower;
ODM_Write_DIG(pDM_Odm, CurrentIGI);
- /* ODM_Write_DIG(pDM_Odm, pDM_DigTable->CurIGValue); */
}
/* 3 ============================================================ */
@@ -709,10 +700,8 @@ u8 odm_ForbiddenIGICheck(void *pDM_VOID, u8 DIG_Dynamic_MIN, u8 CurrentIGI)
if (pDM_DigTable->LargeFAHit != 3)
pDM_DigTable->LargeFAHit++;
- /* if (pDM_DigTable->ForbiddenIGI < pDM_DigTable->CurIGValue) */
if (pDM_DigTable->ForbiddenIGI < CurrentIGI) {
pDM_DigTable->ForbiddenIGI = CurrentIGI;
- /* pDM_DigTable->ForbiddenIGI = pDM_DigTable->CurIGValue; */
pDM_DigTable->LargeFAHit = 1;
}
--
2.25.1
reply other threads:[~2026-10-13 9:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261013092908.380050-1-szwyb123@gmail.com \
--to=szwyb123@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=guojy.bj@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nikolayof23@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®