From: Wang Yibo <szwyb123@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
"Bera Yüzlü" <b9788213@gmail.com>,
"Jennifer Guo" <guojy.bj@gmail.com>,
"Ethan Tidmore" <ethantidmore06@gmail.com>,
"Adriano Cordova" <adrianox@gmail.com>,
"Azamat Rakhim" <azamatrakhim8@gmail.com>,
"Nikolay Kulikov" <nikolayof23@gmail.com>,
"Michael Steinmötzger" <m.steinmoetzger@gmail.com>
Subject: [PATCH] staging: rtl8723bs: remove unused defines in odm.h
Date: Tue, 13 Oct 2026 17:57:07 +0800 [thread overview]
Message-ID: <20261013095707.387341-1-szwyb123@gmail.com> (raw)
hal/odm.h still defines several constants that no code in the driver
ever references:
BAND_NUM, AFH_PSD, Adaptive_SIR
ANTTESTALL, ANTTESTA, ANTTESTB
AUX_ANT
They come from the PSD and antenna-diversity sections of the vendor ODM
code and were never wired up for the RTL8723BS. The "/* ANT Test */"
comment is removed together with the defines it introduced.
No functional change intended.
Signed-off-by: Wang Yibo <szwyb123@gmail.com>
---
drivers/staging/rtl8723bs/hal/odm.h | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/odm.h b/drivers/staging/rtl8723bs/hal/odm.h
index 3532f0d79363..8a357658fdb5 100644
--- a/drivers/staging/rtl8723bs/hal/odm.h
+++ b/drivers/staging/rtl8723bs/hal/odm.h
@@ -29,12 +29,10 @@
#define TXSCALE_TABLE_SIZE 37
#define TXPWR_TRACK_TABLE_SIZE 30
#define DELTA_SWINGIDX_SIZE 30
-#define BAND_NUM 4
/* 3 PSD Handler */
/* 3 ============================================================ */
-#define AFH_PSD 1 /* 0:normal PSD scan, 1: only do 20 pts PSD */
#define MODE_40M 0 /* 0:20M, 1:40M */
#define PSD_TH2 3
#define PSD_CHMIN 20 /* Minimum channel number for BT AFH */
@@ -46,7 +44,6 @@
#define Smooth_Size_3 20
#define Smooth_TH_3 4
#define Smooth_Step_Size 5
-#define Adaptive_SIR 1
#define PSD_RESCAN 4
#define PSD_SCAN_INTERVAL 700 /* ms */
@@ -56,16 +53,10 @@
#define DM_DIG_HIGH_PWR_THRESHOLD 0x3a
#define DM_DIG_LOW_PWR_THRESHOLD 0x14
-/* ANT Test */
-#define ANTTESTALL 0x00 /* Ant A or B will be Testing */
-#define ANTTESTA 0x01 /* Ant A will be Testing */
-#define ANTTESTB 0x02 /* Ant B will be testing */
-
#define PS_MODE_ACTIVE 0x01
/* for 8723A Ant Definition--2012--06--07 due to different IC may be different ANT define */
#define MAIN_ANT 1 /* Ant A or Ant Main */
-#define AUX_ANT 2 /* AntB or Ant Aux */
#define MAX_ANT 3 /* 3 for AP using */
/* Antenna Diversity Type */
--
2.25.1
reply other threads:[~2026-10-13 9:57 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261013095707.387341-1-szwyb123@gmail.com \
--to=szwyb123@gmail.com \
--cc=adrianox@gmail.com \
--cc=azamatrakhim8@gmail.com \
--cc=b9788213@gmail.com \
--cc=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=guojy.bj@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=m.steinmoetzger@gmail.com \
--cc=nikolayof23@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®