From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4ED073C5546; Tue, 13 Oct 2026 14:14:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791900899; cv=none; b=tyOP0Ofn3ML4fQ8Rib/OdXnfuV8K7lmTHUZzQBm4ZINEHVx3CPeh/xy3nmQhQzg6iYeipdfqMnkFXbyhH7XJ/vWd5bHJ4hBiAdRj14uxtcpfrh346o6d7yTHJM6bM/yLisrxixrUhVWtWQDfQvUjLK2M+Q3qUKtVaPfpPD2NoGE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791900899; c=relaxed/simple; bh=JxEjWEU6dC37GG3VdhIlrv6fnHylkRr7g9HUGAHBSlM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sIBJ/ZLUnZnztjB/vFEseIrnk8/qw9PyfZNS9CiSAhw7lHOdrxc3Qg9hObKYPNQWddiuEx3f8bFq9RQ4Ks1ia1wRCWoBsWOeb+UdsF4MiQ2mUSLpaKe2ojLDwVzhCx1qcDtNO9Gfl90lhXiTz4LSHdnBtEg314um6q73AUGIbN4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=2RTKA2s4; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="2RTKA2s4" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id EAFB31A11FE; Tue, 13 Oct 2026 14:14:56 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id BEC4E60362; Tue, 13 Oct 2026 14:14:56 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 5D7AA11D716A0; Tue, 13 Oct 2026 16:14:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1791900891; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding:in-reply-to:references; bh=CyGU6d7OI09akB0dO5wo6D/vikIohPnXs+OHMj6aMGs=; b=2RTKA2s4Y5VC+WZWwByNfIDbOJS84c+C8+rSgFlElQOhYQvAa+yRnbZ2ny3tDgOfNiSeD6 igmyKjV2lnWXXFxle4W9TKKsFA1DtmOmUmGSbOs3ZQxVNDWqdwz9O2JXtnj7C7CU7diq5w iwFK3S9i/wfyrKUv1rvdNsPqnD8AwNUJ1atb6W+KYe918FqAO+4k80LERQ7wHWWgZygaRA 3DecKKwJ4SjZ89TiU6Krp5pjmsu18RjCbk/D9oaD4L1qAMRaqF6lOKrjc/PiC4pzjAYq5W QLgeRe+kdosxlRUa29xBgNYgSrRDDbJ5UbKEUevxOpdWOj/OR5Irxs/UtlWkvQ== From: Paul Cercueil To: Pratyush Yadav , Michael Walle , Takahiro Kuwano , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Mark Brown , Thomas Petazzoni Cc: Kees Cook , Tony Luck , "Guilherme G . Piccoli" , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Bharat Bhushan , Sunil Kovvuri Goutham , Tanmay Jagdale , stable@vger.kernel.org, Paul Cercueil Subject: [PATCH v2 4/7] spi: cadence-xspi: Clear "SDMA ready" IRQ flag after polling Date: Tue, 13 Oct 2026 16:13:47 +0200 Message-ID: <20261013141350.189996-5-paul.cercueil@bootlin.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261013141350.189996-1-paul.cercueil@bootlin.com> References: <20261013141350.189996-1-paul.cercueil@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 From: Tanmay Jagdale When polling for the "SDMA ready" event, once the corresponding bit is set in the CDNS_XSPI_SDMA_TRIGGER we should reset it to zero. Otherwise, any subsequent call to cdns_xspi_is_sdma_ready() will just return early. Fixes: 931e389ded0f ("spi: cadence: Add Marvell xfer operation support") Cc: stable@vger.kernel.org Signed-off-by: Tanmay Jagdale Co-developed-by: Paul Cercueil Signed-off-by: Paul Cercueil --- Notes: v2: New patch drivers/spi/spi-cadence-xspi.c | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/spi/spi-cadence-xspi.c b/drivers/spi/spi-cadence-xspi.c index 39c868a5b171..095bf640b379 100644 --- a/drivers/spi/spi-cadence-xspi.c +++ b/drivers/spi/spi-cadence-xspi.c @@ -1068,12 +1068,20 @@ static bool cdns_xspi_is_sdma_ready(struct cdns_xspi_dev *cdns_xspi, bool sleep) { u32 ctrl_stat; - return !readl_relaxed_poll_timeout - (cdns_xspi->iobase + CDNS_XSPI_INTR_STATUS_REG, - ctrl_stat, - (ctrl_stat & CDNS_XSPI_SDMA_TRIGGER), - sleep ? MRVL_XSPI_POLL_DELAY_US : 0, - sleep ? MRVL_XSPI_POLL_TIMEOUT_US : 0); + if (readl_relaxed_poll_timeout + (cdns_xspi->iobase + CDNS_XSPI_INTR_STATUS_REG, + ctrl_stat, + (ctrl_stat & CDNS_XSPI_SDMA_TRIGGER), + sleep ? MRVL_XSPI_POLL_DELAY_US : 0, + sleep ? MRVL_XSPI_POLL_TIMEOUT_US : 0)) { + return false; + } + + /* Clear the flag */ + writel(CDNS_XSPI_SDMA_TRIGGER, + cdns_xspi->iobase + CDNS_XSPI_INTR_STATUS_REG); + + return true; } static int cdns_xspi_transfer_one_message_b0(struct spi_controller *controller, -- 2.47.3