From: DaeMyung Kang <charsyam@gmail.com>
To: Namjae Jeon <linkinjeon@kernel.org>, Hyunchul Lee <hyc.lee@gmail.com>
Cc: ntfs@lists.linux.dev, linux-kernel@vger.kernel.org,
DaeMyung Kang <charsyam@gmail.com>
Subject: [PATCH 0/2] ntfs: handle block device cache flush in fsync paths
Date: Tue, 13 Oct 2026 23:58:44 +0900 [thread overview]
Message-ID: <20261013145846.56415-1-charsyam@gmail.com> (raw)
Regular-file fsync currently ignores a block device cache flush failure,
while directory fsync never issues a cache flush. Both can report success
without ensuring that the data and metadata reached stable storage.
The first patch returns and logs flush failures from regular-file fsync.
The second adds a flush to directory fsync and reports its failure. The
syncfs path already handles flush errors.
QEMU blkdebug injected -EIO for flush_to_disk on ntfs-next at
04fb910da2c8. Before these changes, both file and directory fsync
returned success while syncfs returned -EIO. With the respective fixes,
both fsync calls return -EIO. A kretprobe confirmed the flush failures.
DaeMyung Kang (2):
ntfs: report block device flush failures from fsync
ntfs: flush the block device when syncing a directory
fs/ntfs/dir.c | 2 ++
fs/ntfs/file.c | 4 ++--
2 files changed, 4 insertions(+), 2 deletions(-)
base-commit: 04fb910da2c857cdf99a331c576c3e5e7197c6dd
--
2.43.0
next reply other threads:[~2026-10-13 14:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 14:58 DaeMyung Kang [this message]
2026-10-13 14:58 ` [PATCH 1/2] ntfs: report block device flush failures from fsync DaeMyung Kang
2026-10-13 14:58 ` [PATCH 2/2] ntfs: flush the block device when syncing a directory DaeMyung Kang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261013145846.56415-1-charsyam@gmail.com \
--to=charsyam@gmail.com \
--cc=hyc.lee@gmail.com \
--cc=linkinjeon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ntfs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®