From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B91E4078E0 for ; Tue, 13 Oct 2026 14:59:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791903544; cv=none; b=YoxVW7pUbN2kPh7cskrhVm7QNd+D8Osf8HwbVqjik70wuwZljAKpMltXcAtXEc0umKqkVoAwfw+JIHMK13hW1YzBUPYsRZXKkdbCvnQ1ZXfIzsLZcCJVNim+5pVwPMYyHL+0wCAgqntuCqDVNP45cqse9frJu0aZo5+VvegX5N4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791903544; c=relaxed/simple; bh=A62Md/Uyi/42qVimXLqVhcnX90wP83924gg05eeVTvs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KWaVYy/bzyOnBqEVeqp2T6tBzFTZ6s1vhwGLZe9hxEymK0vm4GCvnyuC+NXeyun+r+hcNv9I5Wuje9sBEUXArqDyb4FPowB0T+nZ0HwR9W7UiZEjdF0CjC5DuTki5HzJm3Erm5dKUzxRMm6zxu9/z0NpaVJSItxQLTqNYbwaQOY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kYLRvpZ/; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kYLRvpZ/" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-88746bf1ec2so190085b3a.0 for ; Tue, 13 Oct 2026 07:59:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791903543; x=1792508343; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=YzNvwx+hTE/Sy4DERDQI0AUbkPSf6A0fBJaHS6Z80VE=; b=kYLRvpZ/mbqZe62B31Zik+dW2RBXs04Cas5ucpWTDn6veiUq+MSbbBCHAhG0OVO+YT CYgs6qaoN/LTE42zjd+tOPDewoyJbE6vdvR3gF/3KaPSs9fi25SPuE0CcpYjg1aJzyEz vI8rASzV2IRHibKhXeJQJwPo9dIyfMO7M8QfyqxYApPFzaTT5eLf7+s6o5ycl+We6WX7 CueQkFV+70eEf5nQ4JeVISrtLo8U2j0k3naEjnTv1L17DENTAZkdaZd2Ub61nN7jvPJG MjP3dR28/XJpSA7qI1v/K/GtkepIU67uyYFaQi4ssXy04AEJvu+R+h9Grmas0ZkTv0jY qWQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791903543; x=1792508343; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=YzNvwx+hTE/Sy4DERDQI0AUbkPSf6A0fBJaHS6Z80VE=; b=ZHwC1pO2sHV7OCa+LqvUfHxWmm7O9vdCBVG2dCrRiQIe2+kblv63sfBiOJEOMVijzr rSFu9jBvp3wCXancAKFX6KBX4GZbw/XRDjGEvm6QwbXen9Dl5qpBiK5+6lE9BqegwVXk Fe6I7mrR9CMR0HR8cA1YbFt0G2Lxv+AEm/FkXFopVI0GwJZV4iy8VP9GPpJqCdLpOXpk sakdqligDtEzmIG+/KXlV/2EXQhrCJ/Y8QwVdkhqyLsgltk+u8Gc4cJ3An0vySVH7gt0 668lLZAqB5NSZ4tBA4ErXXMcVLSVfPwSm5AlRY0m5gIL4x+3wvzrv2hrETMA+J6Iyq6d soJg== X-Forwarded-Encrypted: i=1; AKwUvBz+IYdF19Pq3P7cZCRyWBXjG5D9Io9h7KhKCCg0qeG1tV5Yq1eRATv3KTk49rkJQBOfkaRV6MJ1PKsi3Yw=@vger.kernel.org X-Gm-Message-State: AFq9FYLHWUUB4QLQhATPGOZSgz2lSlzcUtnZFy2MQPl0sry1NrHmPNMP CE9kzqjokl+kEmrfpuMKI+iGBTxy2vtlgDO1wGEk4Fk65cUW1Jl/XXju X-Gm-Gg: AYBFou0WEo1t6KHHToiZWEVJC96MQBmXagxSnsJYx1lYjFfAeuwTVQGDonbjgHYHlU9 UbdfsqXn+zJ70GKgXj+EBY8cB2ibvZSS+/bx9bfhf0ifHIIBUEgx+bcla92/v2K8dQ21X+xaaiF V0ayCtxb7uqn4r4yzGX3REPFakubOU93r2C88vbPu75BBesDuZp5SjWqNLCZZmP+md4DTV2HqhM 1GURK73J3kOi4XIB04+UTQmJqjZ6ijXboSClp5+T/p6gWhQ29qiDSdXqnrTizr+3roUGeXabzKW 8yAwpxBV8GVynb+X95CsR3x2P5nUQT2HdcZ2ipc0cvwSbBJzl+aSEKa44J0dVKIWjpigDWCNq3S Z0smiHrC6HERVwmA4qjeA6JtaGsu/ra8ZLRodbrh8V0bAyFTWvyuqOtElEBDHG7DUxfksAgUK7c rP5OlQj119b4b1spQOuoY4hc9xGOESj3QaMkZB3pf7j4qC0StFS5Cv9yUhwY0AD7g= X-Received: by 2002:a05:6a00:4889:b0:89a:ee91:e894 with SMTP id d2e1a72fcca58-89aeeb074bamr5887952b3a.0.1791903542669; Tue, 13 Oct 2026 07:59:02 -0700 (PDT) Received: from ser8.. ([221.156.231.192]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-89a0724a045sm2987330b3a.45.2026.10.13.07.59.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Oct 2026 07:59:02 -0700 (PDT) From: DaeMyung Kang To: Namjae Jeon , Hyunchul Lee Cc: ntfs@lists.linux.dev, linux-kernel@vger.kernel.org, DaeMyung Kang , stable@vger.kernel.org Subject: [PATCH 2/2] ntfs: flush the block device when syncing a directory Date: Tue, 13 Oct 2026 23:58:46 +0900 Message-ID: <20261013145846.56415-3-charsyam@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261013145846.56415-1-charsyam@gmail.com> References: <20261013145846.56415-1-charsyam@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ntfs_dir_fsync() writes directory metadata and calls sync_blockdev(), but does not flush the block device write cache. A successful fsync() can therefore leave the directory's metadata in a volatile device cache. Issue a cache flush after successful writeback and return any flush error. This matches the regular-file fsync and syncfs paths. With QEMU blkdebug injecting -EIO for flush_to_disk, fsync() on an NTFS directory returned 0 before this change while syncfs() returned -EIO. After this change, both return -EIO. A kretprobe confirmed the flush error in the directory fsync path. Fixes: 1e9ea7e04472 ("Revert "fs: Remove NTFS classic"") Cc: stable@vger.kernel.org Signed-off-by: DaeMyung Kang --- fs/ntfs/dir.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/ntfs/dir.c b/fs/ntfs/dir.c index 5a0e21e7c283..fce10baa2b93 100644 --- a/fs/ntfs/dir.c +++ b/fs/ntfs/dir.c @@ -1192,6 +1192,8 @@ static int ntfs_dir_fsync(struct file *filp, loff_t start, loff_t end, err = sync_blockdev(vi->i_sb->s_bdev); if (unlikely(err && !ret)) ret = err; + if (!ret) + ret = blkdev_issue_flush(vi->i_sb->s_bdev); if (likely(!ret)) ntfs_debug("Done."); else -- 2.43.0