From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95E725349CA for ; Tue, 13 Oct 2026 15:19:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791904759; cv=none; b=jtebLjuHpaAuYeoXpfIMazbuN0al4Z5nrB4munlr+2YHqS3Rq95cq1VOaOumDLhOP5f0tuAeRSELuDSlSGnlAMZthAzQmQhHz7PzceWHFYs6nQUkimxy+6rcIrt/cBw6MuTpSSKUOuwOaN2+8tiGM7gDqunqTwMln3/2CStkHZE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791904759; c=relaxed/simple; bh=74VHLSgwRzNKKyzn4xtt5CJpDC+AOHiXpkoywV8LdL0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bEV7QRnU7h/jF//f/bVPKoDiXAxLiBK/MFVxfhMyqznvbDVFREH3NFytHhm0GLny7pRZ6nRukwp4BoHjJSeQCpXZAE2V6raDAyoKd82CJX9xRO+NyTvepi3a+lWBb1Eg0FXFvL2lPhXR0JKpfIaJC22aLQVJM/K7stGOIXqcVwQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z+AHiyHK; arc=none smtp.client-ip=209.85.215.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z+AHiyHK" Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-cd60d155070so766543a12.2 for ; Tue, 13 Oct 2026 08:19:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791904758; x=1792509558; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0H70aAMMimCbLXT1pVFm2uX6egTnEDs8iDKGzFjDDBI=; b=Z+AHiyHKK2m3bW0twaTi6bwgeZ5nZojGRvq8mQbuVtxVsJBytZh52YfPtPqcOBE8Bh /QfpAbcPw1bUgzPmFcn3foc56qyqSkWFfDe1t2gPW1SzNDms6xskUjZkXDc18skyYtWD Dkyc7NDWQCyYAcqooUmQaJwSI8R0jRGMCbtNBAli4IFikKwToKViMa3scC6reFWSitVE pb137j4dl0cD7vwgtzhOfFbXNgIl9KmUJCaJBqevmA11irKlDl5T3jmb8IJfHFWF2Wej 5WWvsRqIkK+8kk207tIwh2wO8Sx7hcC7NVed42ExqixkOa5M6gslSEeuU85epsBmtUqV ++Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791904758; x=1792509558; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=0H70aAMMimCbLXT1pVFm2uX6egTnEDs8iDKGzFjDDBI=; b=F/TNked5Rl35xqkfDnb9c7tm4x8IJtB60LpOm8E2JJrLRRnJERufURYYawBDjosK5I /429/qq5EpYjQkneVeFpa1DtBRlAUDLOQvqEfhNXsX+Psc8LUL4SfDWTxoZPi+6xO4T9 PRAMw1ddS4Uj7APuehSOPn6PBOZFiEn7m4ZcBopipB0zcL2kvf4Vmnyb09Ia8oIIc0Id m5spe12E15IFInbTaq/7Os5aEx1f80PJLdro9Mp1N04QpveiQaHVL12trkblB4GEQdsr ZI4oBd9vxxXrul3NedYaNHDYxhwmB4ienjENqxqgbJicY/lsPQzKHgviaxrLaUEyT282 BcIw== X-Forwarded-Encrypted: i=1; AKwUvBx1x9Zbw1GDMee2/07p3ATTAHeQXXs6tldUJ7i1/vKmBdpykmpx3iW7gn0sQlnnS4cFAwEM7jsrPyzKWRo=@vger.kernel.org X-Gm-Message-State: AFq9FYIUM2QzkFbHrCMi8NmelVOWlH2qIK+JfawQng4HKWPFF9MhlYBE dbDI+fvueM8T4l5DyvUp/+av4BnupsfxByiI8e6kbAUJoBHknSelMhjg X-Gm-Gg: AYBFou3MQQVTW/Ut9oS4yD/JY7cItJPiP33JOSGkQOmoW+sYaf/Zjto8PcZ4b83bXbt RhaY9dJxxvgNJzVO1h7l2LhDWP/OfCRF9b18qTSxJ/wmm21Y48gfokpR/mSZ0bbNMhQ/As47rHJ OMb4SPnsGUuRgAep3V4peqNT/7ECAYNYo1NBpXitjwsASHeOQO66porNydcmM8VDMYhWpzRsF2r U8S773slZZnkXQpTdzpuywJMlJAfFZUe2UZdGSyV6+sWjpayB80nhfL7SiZfwgp51VlVftmzmOj kkYoYudPCuaHYhszyCxhd/BleJAfMK32IFXXtQYGO4UZNBJYCwILxBzd/ACY2NiyfZCQpeTrGGb +TaOhI3l4TTi4eO893z9PITnv/dwd7ycqM8C7T3+tXDbp3U2uD6ys92Z5i8maXhAN4rDWYeHMnd UDodirh5+I9/a2FHUg3MqVUdr8Uc1FhQRgIlbvYA22eseZWrSdfWpf0QnxsehAQEDMoYTPdD6NR ChC7oZC9GzfblXm2/+O02S8k3BgLUQ3v0lumfA= X-Received: by 2002:a05:6a21:8216:b0:3de:b120:bb88 with SMTP id adf61e73a8af0-3e16bb71260mr12893094637.2.1791904758027; Tue, 13 Oct 2026 08:19:18 -0700 (PDT) Received: from buffalo-ssd.taila54753.ts.net ([240b:253:4760:f400:1ebf:ceff:fe7f:5e0b]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cd3da04596dsm5759888a12.29.2026.10.13.08.19.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Oct 2026 08:19:15 -0700 (PDT) From: Akari Tsuyukusa To: Brian Masney , Jerome Brunet , Matthias Brugger , AngeloGioacchino Del Regno , Yassine Oudjana , Richard Cochran Cc: Chen-Yu Tsai , Bartosz Golaszewski , Kees Cook , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= , Danilo Krummrich , Nicolas Frattaroli , Bjorn Helgaas , Takashi Sakamoto , Haotian Zhang , Miles Chen , Sam Shih , Daniel Golle , Chun-Jie Chen , Laura Nao , =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= , linux-clk@vger.kernel.org (open list:COMMON CLK FRAMEWORK), linux-kernel@vger.kernel.org (open list), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Mediatek SoC support), linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek SoC support), Akari Tsuyukusa Subject: [PATCH v2 14/35] clk: mediatek: Add child-device population to probe/remove helpers Date: Wed, 14 Oct 2026 00:17:13 +0900 Message-ID: <20261013151734.3177690-15-akkun11.open@gmail.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261013151734.3177690-1-akkun11.open@gmail.com> References: <20261013151734.3177690-1-akkun11.open@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit MediaTek audio clock drivers call devm_of_platform_populate() after mtk_clk_simple_probe(). Extend __mtk_clk_simple_probe() to run of_platform_populate() when the new 'populate_children' flag is set, reducing boilerplate. Signed-off-by: Akari Tsuyukusa --- Changes in v2: - Use non "devm_" helper (based on Chen-Yu Tsai's review) --- drivers/clk/mediatek/clk-mtk.c | 18 +++++++++++++++++- drivers/clk/mediatek/clk-mtk.h | 1 + 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/clk/mediatek/clk-mtk.c b/drivers/clk/mediatek/clk-mtk.c index e06cd40d995a..1172e76516c0 100644 --- a/drivers/clk/mediatek/clk-mtk.c +++ b/drivers/clk/mediatek/clk-mtk.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include @@ -603,7 +604,16 @@ static int __mtk_clk_simple_probe(struct platform_device *pdev, r = mtk_register_reset_controller_with_dev(&pdev->dev, mcd->rst_desc); if (r) - goto unregister_clks; + goto unregister_provider; + } + + if (mcd->populate_children) { + r = of_platform_populate(pdev->dev.of_node, NULL, NULL, + &pdev->dev); + if (r) { + of_platform_depopulate(&pdev->dev); + goto unregister_provider; + } } if (mcd->need_runtime_pm) @@ -611,6 +621,9 @@ static int __mtk_clk_simple_probe(struct platform_device *pdev, return 0; +unregister_provider: + of_clk_del_provider(node); + platform_set_drvdata(pdev, NULL); unregister_clks: if (mcd->clks) mtk_clk_unregister_gates(mcd->clks, mcd->num_clks, clk_data); @@ -658,6 +671,9 @@ static void __mtk_clk_simple_remove(struct platform_device *pdev, struct clk_hw_onecell_data *clk_data = platform_get_drvdata(pdev); const struct mtk_clk_desc *mcd = device_get_match_data(&pdev->dev); + if (mcd->populate_children) + of_platform_depopulate(&pdev->dev); + of_clk_del_provider(node); if (mcd->clks) mtk_clk_unregister_gates(mcd->clks, mcd->num_clks, clk_data); diff --git a/drivers/clk/mediatek/clk-mtk.h b/drivers/clk/mediatek/clk-mtk.h index b6504b3e77ed..11939e3e0b38 100644 --- a/drivers/clk/mediatek/clk-mtk.h +++ b/drivers/clk/mediatek/clk-mtk.h @@ -265,6 +265,7 @@ struct mtk_clk_desc { unsigned int mfg_clk_idx; bool need_runtime_pm; + bool populate_children; }; int mtk_clk_pdev_probe(struct platform_device *pdev); -- 2.56.0