From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B95F953D9CA for ; Tue, 13 Oct 2026 15:20:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791904838; cv=none; b=DRxbiTF99Of7Fh2V5j2KgjxivNu48Fcq6y1Ap3zIGRiZyUCwmMza8T78eVHgSiv1JbA2HYuuC/NNxV0VCQhQW87j41LfC6N2paehhwy9lPnxDY52cB5oeH+0McFiDk/dio/NPJhBitu3JDO6yW0uVNV+hvVhK2YkXnFr13QZxtE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791904838; c=relaxed/simple; bh=EEYZOJo1fS1pyLaIRu4n/N1/lu9GsA3pg0KxBd0b5SQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Os6BSD027s3rKFh0pu0uiuGOLvyd0S0zWzwIgVCIGP87nN8a6Vf2BHNbzNqZs3siR3AOKpGfH9N5FFeis6waEUtu1xmMoODxIut/tO0jElkUvVqvEorBYWHiWRM2c4eyQKOAazyWuKZYPpKOR5+PrsfzRcGc0O6BDodgRIQazJg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=I6EAlxgz; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="I6EAlxgz" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-3ab33730821so1796428a91.3 for ; Tue, 13 Oct 2026 08:20:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791904836; x=1792509636; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=auCf8eCSpvAiDE8LzEvBEdtxk+NZAa2oXMsy16G7EVc=; b=I6EAlxgz9QyJOgyP4dlNSnuRlYpmBwRD8SeBxJH0lWnzc2BpNRuPrAbjHpOnefWlc0 H4Dt9l5A69d7JVbWZFMb3SRWjCqu8BXiprAxdybc+a1umqQtmdegz/56YXOAKqzVMVSP D99nxlgk74xk8OoNK49SHKujCIosSMKLK4YR7byJHYhUG3dl7MPc0fgy5rdOxj6pRwbY FuiNU53NkVBPnkhfpsyNF2Ps0OSOP0aplhUVUHBcgeM9ARLhbIL7IfY0Z+xaGWUVCQlU LySNc41JCxXV0UJGMBQuVLFX16KvkqHg9QRaBuPS+D+dQmFikqL125Noj8IzLaz08BVJ 39lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791904836; x=1792509636; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=auCf8eCSpvAiDE8LzEvBEdtxk+NZAa2oXMsy16G7EVc=; b=gWMypEd2f6ZqUxUvKqjNLS2K3+SBx2PbqToz/NjgxdRfX9V62NTZep1AA7Wx3H6xYV SZtSwgIORIe62Z8DGxtRcavbHxCZQhqCAfhy8GBrsgLpBKqiYyW9I632apjX5KmJZlna Iytq8OFRTLOzQXX4SB5gsXln0gdInVfESJGpEADMrUeU6sr8ghWTujTO7JB+eXt77vmx sDsXLUgP2ks3v85dxZVcxr4km/jz1u3R9aO1XNR2VjA6gob3sEdQZZF4bF59c+U2DsAg ckXtPVGf+mjWkKMCkGg1PpMh5lIAarobRI0qT3bHFxu0jcb7FGu+1rYA+sC6Yr7or9wW Ah5A== X-Forwarded-Encrypted: i=1; AKwUvByqjq9KI8Pzqci1INK8OlMoVe4Krdyfh1S47y7j+WUO9VJ7fZoYXw+OEcB8a3cdKcfJqRm1HYb+cofcjcQ=@vger.kernel.org X-Gm-Message-State: AFq9FYLBjRTfFBP6GipzWizVOk7SxY1hQ+7hRvunc3lYeLXLl9oxr/J8 qxxdWx+ylmt80WUVoNLXpPjMPmJzGGoa9YAzU0Z9uA896ff2pRUAV0uO X-Gm-Gg: AYBFou3LZXnlOVrbUJ3FJN4cYKg4RPpu49s6cebLhJ96gXA5MBTLcR0stJht4VRcXDx BqxcnZa0byHGFu7CshYWxGB4m4GEWMhWXvwf+3f8h/t/IkaI/nQQbMxoC1nIzhub9QiE5pKiJ4f Vw7KdXdMgFegWfbmgHFn+Lgt6onSTHvonvOJG9ArDgcRFiGwU+OXimmtPKMIRy6/C2gOhYj8XBj MN08OtoMw/Y+OurahBe2fAWa03heZr4ITfhZCMYEhwpnxc7J4HjNqJSOQo9f8QEL26bTsMSkc4B ml/Wkb4sVvwj768M1mKm6oKAKP3HVUkx0Tch7UYy2caEXXCqtxvNXo5z0n03DCBFWkubF0naq8V FZq8I+Ap+hqiGsAJr3xVghBvSDRp3Ce3kqibLFyj6DSmrK7JW5Lb5aNx+9J5A9HicciFJBuP1nQ owODKFYVSN+Ds8iC+uXTi3y9F3PtLM2dzoAEIpYpuKaafmNQlrbvLwN5iJRidrARtt3NCj4YmM9 b4IWeF36KBhNtrngfIc66QfXWn7 X-Received: by 2002:a17:90b:2d86:b0:39d:f4fd:8075 with SMTP id 98e67ed59e1d1-3ab3a60eb9bmr10510529a91.19.1791904835959; Tue, 13 Oct 2026 08:20:35 -0700 (PDT) Received: from buffalo-ssd.taila54753.ts.net ([240b:253:4760:f400:1ebf:ceff:fe7f:5e0b]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cd3da04596dsm5759888a12.29.2026.10.13.08.20.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Oct 2026 08:20:35 -0700 (PDT) From: Akari Tsuyukusa To: Brian Masney , Jerome Brunet , Matthias Brugger , AngeloGioacchino Del Regno , Yassine Oudjana , Richard Cochran Cc: Chen-Yu Tsai , Bartosz Golaszewski , Kees Cook , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= , Danilo Krummrich , Nicolas Frattaroli , Bjorn Helgaas , Takashi Sakamoto , Haotian Zhang , Miles Chen , Sam Shih , Daniel Golle , Chun-Jie Chen , Laura Nao , =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= , linux-clk@vger.kernel.org (open list:COMMON CLK FRAMEWORK), linux-kernel@vger.kernel.org (open list), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Mediatek SoC support), linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek SoC support), Akari Tsuyukusa Subject: [PATCH v2 27/35] clk: mediatek: mt8167-apmixedsys: Switch to common probe/remove helpers Date: Wed, 14 Oct 2026 00:17:26 +0900 Message-ID: <20261013151734.3177690-28-akkun11.open@gmail.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261013151734.3177690-1-akkun11.open@gmail.com> References: <20261013151734.3177690-1-akkun11.open@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The MT8167 apmixedsys driver used a custom probe to register PLLs and divider clocks but had no remove callback. With PLL registration now supported alongside the existing divider-clock support, the driver can use mtk_clk_simple_probe() and mtk_clk_simple_remove(). Switch to module_platform_driver() to support module unloading and ensure that registered clocks are unregistered on removal. Signed-off-by: Akari Tsuyukusa --- Changes in v2: - Improvement of commit messages - Add missing `.data = &apmixed_desc` entry to the OF match table. --- drivers/clk/mediatek/clk-mt8167-apmixedsys.c | 58 ++++++-------------- 1 file changed, 16 insertions(+), 42 deletions(-) diff --git a/drivers/clk/mediatek/clk-mt8167-apmixedsys.c b/drivers/clk/mediatek/clk-mt8167-apmixedsys.c index fb6c21bbeef8..aba33e5aafe6 100644 --- a/drivers/clk/mediatek/clk-mt8167-apmixedsys.c +++ b/drivers/clk/mediatek/clk-mt8167-apmixedsys.c @@ -89,59 +89,33 @@ static const struct mtk_clk_divider adj_divs[] = { 0x1c4, 24, 3, CLK_DIVIDER_POWER_OF_TWO), }; -static int clk_mt8167_apmixed_probe(struct platform_device *pdev) -{ - void __iomem *base; - struct clk_hw_onecell_data *clk_data; - struct device_node *node = pdev->dev.of_node; - struct device *dev = &pdev->dev; - int ret; - - base = devm_platform_ioremap_resource(pdev, 0); - if (IS_ERR(base)) - return PTR_ERR(base); - - clk_data = mtk_devm_alloc_clk_data(dev, MT8167_CLK_APMIXED_NR_CLK); - if (!clk_data) - return -ENOMEM; - - ret = mtk_clk_register_plls(dev, plls, ARRAY_SIZE(plls), clk_data); - if (ret) - return ret; - - ret = mtk_clk_register_dividers(dev, adj_divs, ARRAY_SIZE(adj_divs), base, - &mt8167_apmixed_clk_lock, clk_data); - if (ret) - goto unregister_plls; - - ret = of_clk_add_hw_provider(node, of_clk_hw_onecell_get, clk_data); - if (ret) - goto unregister_dividers; - - return 0; - -unregister_dividers: - mtk_clk_unregister_dividers(adj_divs, ARRAY_SIZE(adj_divs), clk_data); -unregister_plls: - mtk_clk_unregister_plls(plls, ARRAY_SIZE(plls), clk_data); - - return ret; -} +static const struct mtk_clk_desc apmixed_desc = { + .plls = plls, + .num_plls = ARRAY_SIZE(plls), + .divider_clks = adj_divs, + .num_divider_clks = ARRAY_SIZE(adj_divs), + .clk_lock = &mt8167_apmixed_clk_lock, +}; static const struct of_device_id of_match_clk_mt8167_apmixed[] = { - { .compatible = "mediatek,mt8167-apmixedsys" }, - { /* sentinel */ } + { + .compatible = "mediatek,mt8167-apmixedsys", + .data = &apmixed_desc, + }, { + /* sentinel */ + }, }; MODULE_DEVICE_TABLE(of, of_match_clk_mt8167_apmixed); static struct platform_driver clk_mt8167_apmixed_drv = { - .probe = clk_mt8167_apmixed_probe, + .probe = mtk_clk_simple_probe, + .remove = mtk_clk_simple_remove, .driver = { .name = "clk-mt8167-apmixed", .of_match_table = of_match_clk_mt8167_apmixed, }, }; -builtin_platform_driver(clk_mt8167_apmixed_drv) +module_platform_driver(clk_mt8167_apmixed_drv) MODULE_DESCRIPTION("MediaTek MT8167 apmixedsys clocks driver"); MODULE_LICENSE("GPL"); -- 2.56.0