From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9D2A519DEE for ; Tue, 13 Oct 2026 15:18:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791904700; cv=none; b=cTAV0u2sdI5NaHeZkCa2gHlKe0VtMfKIoLOXSJuvDTqQ4MwMxTm/tfuQlt8bqqBamnSit3fKBLSOQq1/syO4nFJZVS9G/9ZUzJ/p8FF0pWPWZmpSnAFZLN4zWK5/ZUHr4jH8lCR/JZYjumwA7QHZEB2wtDx0cpwGDIjOpq/02B4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791904700; c=relaxed/simple; bh=4+GfQyXsSLAaCGQTxF4OfH8XhOmFeLya9+t5OyxeHWI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DLQa1AlT77Y5Yd7UnSaCEraIcFA0gfvzrClDi6CfwLDJoTlh+f1sAFZYoFXjaVeVBV4/9DmeMOx9aiibTdRCQZVMcydas3ZI5V21kh5wDE557FVOmUEt8X+BChFXekW/pZmvd97yAfP31BoaC3WxFqwhsDwR7zBM0/S2BTca1as= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TF0/aQG7; arc=none smtp.client-ip=209.85.215.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TF0/aQG7" Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-cc4dbda1e5dso1087163a12.2 for ; Tue, 13 Oct 2026 08:18:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791904699; x=1792509499; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=onVmbrIGz8Z0hScXq6eH5zvGAlPqsRkr0+Mi5GF04W4=; b=TF0/aQG7or7ApNOLSN8JGOO9ytFTTPOMHEPZ8DfMTkU9xGakJGExf8voW4IIDV3NxF LijKC70D+PK14kY16AEG5I8zPtU9jehHWX3VPRx5d6Un2YRT79LQ7s56ArVmiuoUedmK 00GS/xNG0YxdkuXE4AQEy4qenSl0CsAc5U9apOQ6wAhxjU2qXQ5WLD4rgcDsA2Wak2IH fYrVvEAkp4TYTRNE6uYXTfPKHP/tVQ5IuJOVrd4l7wyaKG25fuSxgz2ZHYzdNw0UTizw afbrDU7wz/g4oPCKlWGUg6zH9LqYBvNL0wQ9rDIk/aKOOtQgr2m7zFF2PQpLEiOgE9XV BGiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791904699; x=1792509499; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=onVmbrIGz8Z0hScXq6eH5zvGAlPqsRkr0+Mi5GF04W4=; b=hIbziieijdWALP58beOX/w5CBjUGuVfePbScNofw59kCZ9iI6e6OYRV+gBGfoPZIUK GTQBC71DiKBZIQlTyfPqwTwnIyRAB0TJsTmj/3ZYZNMGHzfQgK/b9/JhnktrWxirzof2 epcswybbghLX9c4GEHSRHDiSn4Gy6uubW1PLeBx87XSAyPI0ZJt03JA7O5CI1iccuSL7 LeawHXlqqtAAoq6/Rh2DPE7PygwUrrFjbyFUZavj8ODUpMcQwfzlZ40KNp8L63EM80W1 vWeP646Yd3CvjnlOUT4qInQN68oe4kJ4dVvB4LtM4lYf+0gMA21mBDdtGJn6xryLqSW2 I6vA== X-Forwarded-Encrypted: i=1; AKwUvBxAKAHAKT7g80wtL19is/C5H3trH0rEtd/wE8Vkct3yEbsHbXJJy/vyZLTPz64myU88GM2PuvUOYeciw9Y=@vger.kernel.org X-Gm-Message-State: AFq9FYLxVGVy6u3vgW1ZqT7wDtx1fG1QbcT/Hb51+ReqU/vooFG21HoS Syus+Vt02eJq3/pEPDcOZauwmSSnvcmrFCEGhCjFNginoiQnRezfGj5d X-Gm-Gg: AYBFou0Arx5qv2UGTKQC11bb4RQ0Mc9DV5hei6LsfI1EPKPaxGnWPx1abL2xqGvJTcr qsn0noHxzn3UOHV3AwBWxVU5GeMI1b+OUY6Zi2ry85FG7K5j6aGc+X9hJ4eIQMeR3y5HfqEILdq k5cwQvuivLMak0Gq6Eqh44Gnh+Of3+VZHTtdCKEh7ZndFFwk9o0l47ZInYB9m/I1lVC+aH5ga+6 xrQndV7GYhcIWWLciZF1uXpUxHyP8+x279/AionIMHivMVwJI9I6C7GOCIQQAdT1qWfd7T39RZT 4xYxOfquv89YwLSlkO/Yt5Wt0yN3LAcaey0QdFkFW7WGWstDy5ReBs2rL5YovZ0PXBm+qn9Q3ER IMEmrf3IkPHBUvC5fd2/arZ5zntjuXn+8uf7UjB8CE977Y88mvmVrjqGDZICVTz4wPF7UwGtwPh w4AYwaY4atD5woUdJ+EsxyB5X7dFMJoNO9TVVt2idQfS4j5R59Xt7O7TU88gcODz59VHsV+ZQpt HHxCq99T56XBpZ/CU1RaUGssMhn X-Received: by 2002:a05:6a20:9c98:b0:3e1:c04b:59cc with SMTP id adf61e73a8af0-3e1c04b92fdmr2161022637.70.1791904698979; Tue, 13 Oct 2026 08:18:18 -0700 (PDT) Received: from buffalo-ssd.taila54753.ts.net ([240b:253:4760:f400:1ebf:ceff:fe7f:5e0b]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cd3da04596dsm5759888a12.29.2026.10.13.08.18.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Oct 2026 08:18:18 -0700 (PDT) From: Akari Tsuyukusa To: Brian Masney , Jerome Brunet , Matthias Brugger , AngeloGioacchino Del Regno , Yassine Oudjana , Richard Cochran Cc: Chen-Yu Tsai , Bartosz Golaszewski , Kees Cook , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= , Danilo Krummrich , Nicolas Frattaroli , Bjorn Helgaas , Takashi Sakamoto , Haotian Zhang , Miles Chen , Sam Shih , Daniel Golle , Chun-Jie Chen , Laura Nao , =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= , linux-clk@vger.kernel.org (open list:COMMON CLK FRAMEWORK), linux-kernel@vger.kernel.org (open list), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Mediatek SoC support), linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek SoC support), Akari Tsuyukusa , stable@vger.kernel.org, Brian Masney Subject: [PATCH v2 04/35] clk: mediatek: mt8135: Fix memory leak on module removal Date: Wed, 14 Oct 2026 00:17:03 +0900 Message-ID: <20261013151734.3177690-5-akkun11.open@gmail.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261013151734.3177690-1-akkun11.open@gmail.com> References: <20261013151734.3177690-1-akkun11.open@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit clk_mt8135_apmixed_probe() in clk-mt8135-apmixedsys.c does not call platform_set_drvdata(), but clk_mt8135_apmixed_remove() callback calls platform_get_drvdata(). This results in platform_get_drvdata() returning NULL, which leads to calling kfree(NULL) in mtk_free_clk_data(NULL). This leaves clk_data unreleased, causing a memory leak. Fix this by calling platform_set_drvdata() during probe. Fixes: 54b7026f011e ("clk: mediatek: mt8135-apmixedsys: Convert to platform_driver and module") Cc: stable@vger.kernel.org Signed-off-by: Akari Tsuyukusa Reviewed-by: Brian Masney --- Changes in v2: - Capitalize the first letter of the commit message: "fix" -> "Fix" --- drivers/clk/mediatek/clk-mt8135-apmixedsys.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/clk/mediatek/clk-mt8135-apmixedsys.c b/drivers/clk/mediatek/clk-mt8135-apmixedsys.c index 19e4ee489ec3..e3b7dc13b458 100644 --- a/drivers/clk/mediatek/clk-mt8135-apmixedsys.c +++ b/drivers/clk/mediatek/clk-mt8135-apmixedsys.c @@ -66,6 +66,8 @@ static int clk_mt8135_apmixed_probe(struct platform_device *pdev) if (ret) goto unregister_plls; + platform_set_drvdata(pdev, clk_data); + return 0; unregister_plls: -- 2.56.0