From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85EC6530DFC for ; Tue, 13 Oct 2026 15:18:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791904706; cv=none; b=ZFTtHOVh8MRWtk5cXeGWu1MJzlv2GPkd6N0H/6+vfY9d8uJEi/gUHjxRXrn1U8XcBAglk2m8MQ1G+a0hFBDN/TDaqVnOWj35M/C1JZjLpEk7cD29F4TufDnMNnGrGa2xYByAFNJh6uX+RYpIO0MwmsBteEiNrQJGyuktALYRb/Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791904706; c=relaxed/simple; bh=bP+OI5XWAwChiCcP9BrkzwzZMVjZOHDOY48stjGhON8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=e1FivlaQm+RvCkxDL+Q0remzquOe28zv/hxhBfUaQNvTxcteho/q53t+2kCyW2ttApLdLcpdhKASXa6sa1n8H5LK8fVgsYxYRgNLVFc/UMfpGX7kK38Yznvq3rcOvMDWgsgHAwTIIblfrCGEU0ZT44SjR4efYR6FU/s9VMJmSoY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=X/aUIjfb; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X/aUIjfb" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-8897e83332fso2174818b3a.1 for ; Tue, 13 Oct 2026 08:18:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791904705; x=1792509505; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=AUYTFLfF8KyYjB9jrAOG5HypNcpJe9ONDAWrxzRVXzY=; b=X/aUIjfbc7FShqq/ZU0IrOcb2d+D2N4b9WROGw8/uLR5udERWs4dtLFJ1j/v5KZSWT fEGVINsEngAeVPO9rt5aZg08w5osfFCEGdAecnIKieT55+DT5ypL+rxj07ExPLXswMLs F2/kDt2pz4LBZKIgyfxQb41uMj1puTOYx2G6oSqZhs5wlYiwEXokWJRYnN+2ElLoLakm gCUK/WvDAPfOG/SRLiFTpVwmic90FouEaeSOqQNQ77aFRChZ7WrGxQjl2ESlQtraLPso C4ctozFgnZRubSVWWcMFY2wiDicSdM90sZuOLew4bc/Y/50mefSA0UZLAMqjyX7mPZX8 1XSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791904705; x=1792509505; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=AUYTFLfF8KyYjB9jrAOG5HypNcpJe9ONDAWrxzRVXzY=; b=uZ24WcPTMdQVENXqu2o9WAOPFoUPf8BI+vnlC8g1seb3lOr24wBk1AErv0DggufRnL Xnn4QcTsk7q9UIK8RpsdTQVNCxxM4fBBCFopFmlz60IIiGj5kroB91H/ehr28zeJ432P /8IVYK5xPYK9YLQFDRpMd0YnyiAPn/NwxNsjze9dQNsLzmNknkjUgGYlwThVPuoGj0D7 5ndwphrHn3VuLFgCEPpDfIXumB3zP8w6cRyS/E3Rq5fbY4BR+UTRgRAee7iWn55ztqLL 4qNEy2F5u31F2xGNwyS/SCj2H3uOkqh0Bc9i2mgezjb1Nlh7Cx0wunnpz7+jk+oJ3Rvv leAQ== X-Forwarded-Encrypted: i=1; AKwUvBzNmIIAFYKLj/6bfM180kzfo42/cFcdzFvfw177/u/KIClDfANCL5nGOgChj6pf18chwvuXZLxZfbhv1M0=@vger.kernel.org X-Gm-Message-State: AFq9FYIqCkmPcpMEqyxVCGNU0DqWp5083Qw72DcD5k0+oABBn0VDLiGd o0YhBmGZ4wJRt1zV9Qu0qCaRX3ZtCsvf2uLnzXffhuMLCbWbfkDWQ4Rf X-Gm-Gg: AYBFou1FQYINk4clYBdgfrIuDCOzvRpWS8cqBZhZg1Z3jiuAOzV6v75ytbKKnphjBNT z5fPi/hUh/lDCMS0uxXr5FqZcH7258hRfDbHPYeyoAH84wTZmG2a5LrtTOrJk65wK1w7qA1X6yv WAAlhLEBS1I+OSlWUhFkqcJqGf4aD81w187dGK7JfrD/U7ajkshiREWE+/AmarU9+/Baruc0zDd AhvJSV0r9HttMrvxzq1i6faKK1ZLHegyt4O5f/RaFtPP23uO9EFg4SvLBb6eLFUFOALQuSYPI4w JzmVb6Du4IwmVWs0HTVgL3qtJGUt7GuriRuyx5ZLjoV+mZhN6rFb/ZpQV6MoUpRCAmPH2fOEu/l QVGB4mIG4WcWm0pw2ZCK0uL7qJNnTPDEBoOVorSUZV0x2W/fvRJg5xQRLgF+CIxYKTkzD6XFuSm oJGpqlaElfXJLRsp0qzfvpA/FUPMpC9tgqMq+drwz8TF4pyBXX0lgHeVTttZO2gBPLPD9c3o3pz i5vsoyCji/TEcg8WONgP5TLyHdS X-Received: by 2002:a05:6372:a80b:b0:3de:ab1e:a63e with SMTP id adf61e73a8af0-3e165032ef1mr7892032637.39.1791904704905; Tue, 13 Oct 2026 08:18:24 -0700 (PDT) Received: from buffalo-ssd.taila54753.ts.net ([240b:253:4760:f400:1ebf:ceff:fe7f:5e0b]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cd3da04596dsm5759888a12.29.2026.10.13.08.18.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Oct 2026 08:18:24 -0700 (PDT) From: Akari Tsuyukusa To: Brian Masney , Jerome Brunet , Matthias Brugger , AngeloGioacchino Del Regno , Yassine Oudjana , Richard Cochran Cc: Chen-Yu Tsai , Bartosz Golaszewski , Kees Cook , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= , Danilo Krummrich , Nicolas Frattaroli , Bjorn Helgaas , Takashi Sakamoto , Haotian Zhang , Miles Chen , Sam Shih , Daniel Golle , Chun-Jie Chen , Laura Nao , =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= , linux-clk@vger.kernel.org (open list:COMMON CLK FRAMEWORK), linux-kernel@vger.kernel.org (open list), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Mediatek SoC support), linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek SoC support), Akari Tsuyukusa , stable@vger.kernel.org Subject: [PATCH v2 05/35] clk: mediatek: mt8173: Fix memory leak on module removal Date: Wed, 14 Oct 2026 00:17:04 +0900 Message-ID: <20261013151734.3177690-6-akkun11.open@gmail.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261013151734.3177690-1-akkun11.open@gmail.com> References: <20261013151734.3177690-1-akkun11.open@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit clk-mt8173-apmixedsys.c and clk-mt8173-infracfg.c do not call platform_set_drvdata() during their driver probe callback, but their remove callback calls platform_get_drvdata(). This results in platform_get_drvdata() returning NULL, which leads to calling kfree(NULL) in mtk_free_clk_data(NULL). This leaves clk_data unreleased, causing a memory leak. Fix this by calling platform_set_drvdata() during probe. Fixes: 4c02c9af3cb9 ("clk: mediatek: mt8173: Break down clock drivers and allow module build") Cc: stable@vger.kernel.org Signed-off-by: Akari Tsuyukusa --- Changes in v2: - Capitalize the first letter of the commit message: "fix" -> "Fix" --- drivers/clk/mediatek/clk-mt8173-apmixedsys.c | 2 ++ drivers/clk/mediatek/clk-mt8173-infracfg.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/clk/mediatek/clk-mt8173-apmixedsys.c b/drivers/clk/mediatek/clk-mt8173-apmixedsys.c index d7d416172ab3..65dc4489a09c 100644 --- a/drivers/clk/mediatek/clk-mt8173-apmixedsys.c +++ b/drivers/clk/mediatek/clk-mt8173-apmixedsys.c @@ -179,6 +179,8 @@ static int clk_mt8173_apmixed_probe(struct platform_device *pdev) if (r) goto unregister_ref2usb; + platform_set_drvdata(pdev, clk_data); + return 0; unregister_ref2usb: diff --git a/drivers/clk/mediatek/clk-mt8173-infracfg.c b/drivers/clk/mediatek/clk-mt8173-infracfg.c index fa2d1d557e04..9b8c35897789 100644 --- a/drivers/clk/mediatek/clk-mt8173-infracfg.c +++ b/drivers/clk/mediatek/clk-mt8173-infracfg.c @@ -128,6 +128,8 @@ static int clk_mt8173_infracfg_probe(struct platform_device *pdev) if (r) goto unregister_clk_hw; + platform_set_drvdata(pdev, infra_clk_data); + return 0; unregister_clk_hw: -- 2.56.0