From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05B9654DADD for ; Tue, 13 Oct 2026 20:38:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791923914; cv=none; b=TEhExppmm6LpjFFMfxGFjIFuswbelkmMHO4Ey9byoMhTQ54Upzp2l6zByPCnqLe5MTFzBfLiDI5jjg8PlcmymZbj32lSc4olrn5pm/safi/C8xWkUkEoB54fGiwjMa5ejFI55pyYV+ENRRZ4TSWnX0tEEW0p4EsEodVuxmV3kAc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791923914; c=relaxed/simple; bh=31zs8sR/R/SmtXARin9KLj4k0/40iZWjwag/VVg2T3o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZXFcB2XffC8/D4V74Yz2oyQl+XnY/MV0hwIanI+xKUx0NfSAmHgOAhz0dUtOTzX44RqkAHGctXP7EeJkUe8g4lHsGiqGX+3vFrtAY0UcmrDjDjGjONvAL2r2uTWyJmcKWF+pB/CO0wXdVHzw0ekh2VUb2xmtelqvxdNYQ/mdhEs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=bVr4q6K0; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=AHrVaRK3; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bVr4q6K0"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="AHrVaRK3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1791923910; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1QlmvDXTmRUU9nYKkcaNrdZ6s9iHMpAA+451lF8KTl8=; b=bVr4q6K0iIyLgG402O/kbX1ClSGP6/1E6yVfS3RzsoRZxWsGCB1YKCKEN6v7OTr/TSK6UV 96S9EFwxrkf10w+Sw0QU+xpw0K7PsBeFUY8bB6iUTt685MezgkZMXsd9hGGRkejWbHJKVI fw6FKQfrBHSULrZB84uIkPIMZjPT2LM= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-278-ipzgzRTCOc-h9IoflgZ66Q-1; Tue, 13 Oct 2026 20:38:28 +0000 X-MC-Unique: ipzgzRTCOc-h9IoflgZ66Q-1 X-Mimecast-MFC-AGG-ID: ipzgzRTCOc-h9IoflgZ66Q_1791923907 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-49febef74e3so42105105e9.0 for ; Tue, 13 Oct 2026 13:38:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1791923907; x=1792528707; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=1QlmvDXTmRUU9nYKkcaNrdZ6s9iHMpAA+451lF8KTl8=; b=AHrVaRK3+24yZGmukKCTaVSJBZl2Xp3EVz1T0J9MXR0rLlJ3VGDZMrw0LensKtgJo2 XPVf6PoWMBdGYPTOgvIf3pr3Zvw3XN3Ep8z4WlMU88+Bw43KG1wJZAgNpMWXJQgNqJ3k kkd8kAsi2+iA0MxOz0X+VuxR1S06mMqDPy6/4jZJPWYSlwtBcZ27cJ1q1iH/GFnV0w+F cGxl+by5cjZEXUQwCjXXE3Wt7gKOmWmxPPVfCJuc8GOQ2zHunDQeIBUZvkNtcI+n6h4o thB8VFzqahpia8U7A+f9EgtwAOSnO37cWrHEetXCCQM1LyvnvdPXwQzCoHgWzU/QU2nE FAcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791923907; x=1792528707; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1QlmvDXTmRUU9nYKkcaNrdZ6s9iHMpAA+451lF8KTl8=; b=dKkE76eDqoLzfj0WMrp+ISI4IUie7J9cq8UdSS/en+EJe4MXQGvbnsu/VOhYcRUvSq Ylin+S67orAMAM5EpdxU74JFysWR7GHSXkxJUpd+gigbhpf+qvbTJaxZpoxNAtazIm/V 9MPGtAXcGYV/cGt5OUsJwH8O/olpd3kWL3wrdl67aDKLwJaLkQyX1KAwl9e2W1oefxSB GVzl/w+zItOGr9u8qJUa7EMUVhKFmRq3KnSMdw3F/UIdfBss8YNFrNyeEQuul8LmMzXa u1F37cQeY88cqMJRNMhCTEqCC6HOyRn4CNDrPFTuQfgNKL+oD9R4vBr01Zm6pZtzJcDK lWdw== X-Gm-Message-State: AFq9FYLl1JcbmoglP+wmTTBHJU7Ub2GuOeN/jv5HYqQtJCCmhwme2ANZ mL8+PpK5cCaEOcYbX+5I5ayj0X2xsIYzqM42yqpOHXNdPepuMOMZ2u3uJF5AkjsamcKGtWCDURU Eb3eIKAFSlEEn4UhXnXEvd/JuQHBwyWVKOgUQiMCQ41oqDpfz/Fzjb9CxglT61JCfJBFnYPo2Vg == X-Gm-Gg: AYBFou3AdqB8CrQrY7VJsC7sO/6zkSHuL1vNRzelZiqJnMbWSl3xA7qO1oUQWc58DgW 83ZuIY3IeH7j5rtu/vZ9LijuQWFwzffULXzsSZ+L7u/E84uojaKGDBUn7D04xj4T4jSpseLYaKN Cbcv+pOFhwIzxJ7jyXviTi5UkJ/jxRLdfPIvTZcnZQirGbJlMYtySwJtA1cRkW8L0/PtT2DSd9V nd7IdSx7C8HxjKc/qT1srUE7OsW6hhamddIMwL2T4wOlVbdqX+BkYN6SZw8fu14aPKyXXWh3vy9 Nya093jfFaf5GrWYwJCpg7ZmqR1xZr6qppAsSlV/UNcK4anzyycIva5oOqKhdmQLEKufyg== X-Received: by 2002:a05:600c:58d3:b0:4a1:9388:7f40 with SMTP id 5b1f17b1804b1-4a193888295mr163024045e9.4.1791923906951; Tue, 13 Oct 2026 13:38:26 -0700 (PDT) X-Received: by 2002:a05:600c:58d3:b0:4a1:9388:7f40 with SMTP id 5b1f17b1804b1-4a193888295mr163023725e9.4.1791923906449; Tue, 13 Oct 2026 13:38:26 -0700 (PDT) Received: from redhat.com ([2a0d:6fc0:3fd7:5300:3d6b:52a4:a23f:9d0b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48de0ab4edfsm7923045f8f.26.2026.10.13.13.38.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Oct 2026 13:38:24 -0700 (PDT) Date: Tue, 13 Oct 2026 16:38:21 -0400 From: "Michael S. Tsirkin" To: Willem de Bruijn Cc: linux-kernel@vger.kernel.org, Jason Wang , Eugenio =?iso-8859-1?Q?P=E9rez?= , Xuan Zhuo , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, virtualization@lists.linux.dev, Max Krasnyansky , Rusty Russell Subject: Re: [PATCH net-next 3/4] net: resolve uncommon partial checksums at ingress Message-ID: <20261013163706-mutt-send-email-mst@kernel.org> References: <20261013070549-mutt-send-email-mst@kernel.org> <20261013143335-mutt-send-email-mst@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Oct 13, 2026 at 02:32:26PM -0600, Willem de Bruijn wrote: > > > > > + > > > > > + if (virtio_net_csum_partial_ok_at_offset(skb, gso_inner_type, inner_nh, > > > > > + inner_proto)) > > > > > + return 0; > > > > > + > > > > > + if (skb_is_gso(skb)) > > > > > + return -EINVAL; > > > > > > This is a risk the commit message will have to call out. > > > > I tried with this: > > > > > > > We can't easily "complete the checksum" for GSO we don't recognize - GSO > > > > > assumes knowledge of the protocol. We could segment ignoring the > > > > > checksum then do whatever csum_start and csum_offset say, but that > > > > > seems like an overkill for something that should happen. > > > > I guess I can add a more detailed explanation about what the risk is? > > Let's just explicitly mention the consequence: non-standard GSO > packets that previous would be sent may now fail. > > > > > > I don't see a simple way around it. We discussed segmenting here too, > > > but that requires intrusive changes to all callers too. > > > Alternatively, > > > > > > 1. call segmentation, but only to see it remove the SKB_GSO_DODGY and > > > thus verify that the TSO/USO packet is valid. Still drop otherwise. > > > This also does not add overhead, because it would be called later > > > anyway. > > > > > > 2. a failsafe off-by-default sysctl + static_branch that skips the > > > drop when set. Messy, but so is the situation we're dealing with. > > > > Tack this on top or do you feel it's needed straight away. > > Not urgent. Can even wait until a report appears. But worth taking a > look sooner if either of us gets around to it. Maybe if people intend all this for stable, I'll feel safer with this in there. Just to make sure, the branch would just short-circuit all checks, yes? -- MST