From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-b2-smtp.messagingengine.com (fhigh-b2-smtp.messagingengine.com [202.12.124.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43BF2563FBB for ; Tue, 13 Oct 2026 23:14:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.153 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791933290; cv=none; b=UqZSa2w0Gp9BproMN+XO58bMYHB/vMofDaTq6Y5OQy2t1qX04DV7vseY9GTb3LdY0rtj/RT9nTDFzRUt67tyrIzxTfJB1LLZPLDpQhkpFaiKpk92lIfG0vfyE+R3dGFc/5oeqwbyZmuEL/UkAF4lIYjCZliYw92VGFmWQlI4p2A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791933290; c=relaxed/simple; bh=eRPoX+cvghqiMrqus0n9Qybh3O85l6XeVOQrj+10NLw=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=EuuEJHuZle+7zizeCommDJLtNQNOV8F9Xmvj9kUbprMbv2osomeYn7ghr37SYXC2fMRdrLYNwoZd8O7ctsEuUmeT1781lR+RMSLSF5RTDqQRSeAkW8j5hsfsE09bFY06JWQbnnQTpTw5Q8juKqPCBHbJLymAGf/T2m2A4xf/9Gk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=shazbot.org; spf=pass smtp.mailfrom=shazbot.org; dkim=pass (2048-bit key) header.d=shazbot.org header.i=@shazbot.org header.b=rw10vX/3; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=uGs+/jBZ; arc=none smtp.client-ip=202.12.124.153 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=shazbot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=shazbot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=shazbot.org header.i=@shazbot.org header.b="rw10vX/3"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="uGs+/jBZ" Received: from phl-compute-12.internal (phl-compute-12.internal [10.202.2.52]) by mailfhigh.stl.internal (Postfix) with ESMTP id 8CB647A0274 for ; Tue, 13 Oct 2026 19:14:48 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-12.internal (MEProxy); Tue, 13 Oct 2026 19:14:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shazbot.org; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1791933286; x=1792019686; bh=2DfpwWFq1HOra+MrNUUfPOhw7Qi6lGgc7bfsPMNOQOM=; b= rw10vX/3EztxiCLfuAPaQYIqpIQOR8P+AcSB4BcUl7V14lz4tRwDnSJ7JnodaO5r mGDDOk8WPjj10H4xxzr7hMCvXrMk/T4k4immzjUjXshPjjZfERoDDmamE/SsPRGM fK3tAzpTuxexxoO27IxwBtKb9Q8Z5DLHHYXgXqtJew08YfwGMZW4LNy9zApp+e+p OJA+ahQwuJASMmX+3P2g4tk6vNkK1hswUOYHczBfYTaSZwoQRmPtRqCTijI/f6Hu KPyrPYHjBcvN1EyeY4MPOUf7gLLaB23xmMycA68ywKPBtk+TyZia1tqkGSVHcCGb jqWpQsFHBTeKZewgS6ocOA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1791933286; x= 1792019686; bh=2DfpwWFq1HOra+MrNUUfPOhw7Qi6lGgc7bfsPMNOQOM=; b=u Gs+/jBZ7hZPKJuAGnY8LVLfwEHA9aJ+94581k1+GmS3gmwfgeDX+Gf9QIEGEgzFo XQ5YzbJd30nlrFr5CjBpXCQ0RuwkNgfuQOKBUm/whRlLYzB3Lvl7Hni+wGcagHIn t+23a4z+8gZd6izV0xEs5v4fap/IUtIfrPPdtJBMiNmE4QyPk5D+Ry1ThuftF4jL CJlhi5vdQ30FXAkVFXs516U7wAH660Oc/rttfLE+0PCIfFcGrtRHPhWK4VjtqDiZ V3XlOrV5Lecw7IXlkaaFq9eo3o3kUj4tzGSsYC/t96RbwkFIBtJ7lDAc/ioyhV0K s+4jcXkdb2iEVgUmxbMXA== X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-06; repo=github.com/dkim2wg/interop; date=2026-10-04; sw=lmtpprox; action=sign d=shazbot.org a=rsa-sha256; DKIM2-Signature: i=1; m=1; t=1791933286; d=shazbot.org; mf=PGFsZXhAc2hhemJvdC5vcmc+; rt=PGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc+; s=fm1:rsa-sha256:O0ckCPC/SJzbYlAvknfI0l2D6JDSerqfHSYQZLyFgrRoVVa kgPJwf63jLtxCfC5JSTvTbwth8t1/R7ePgppynhbpB0j7/qea/7/t1yzGzMf/Rng HGaJwP93NTCdqdVYrCgoa3+c/sl31TC9gGj0LorpDwKD+8xU23YMMLDtfhlWt+rs xB9eVppx2dkpTUl1cL5BX/TSzw9RQaw3cIPPQlRwzPTE0sIrSYi4ioJPyeQkdKiF L8zgqtUPul7M1rvEzl8dTbMOw/HPDwxpH31mJdeK8P1qP1wD0KO8F0mGrEpnPsgj 2tPbrEZLqaIgOgJId06wowTJ9zjxYBuifkY4Dbw==; X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-06; repo=github.com/dkim2wg/interop; date=2026-10-04; sw=lmtpprox; action=mi-m=1; hc=12; hn=cc,content-transfer-encoding,content-type,date,feedback-id, from,in-reply-to,message-id,mime-version,references,subject,to; Message-Instance: m=1; h=sha256:kkU8cm0X3UdsSi7fY2qIUOqaXcxT0ngc1PD+8exrdjc=:eRPoX+cvghqiMrqus0n9Qybh3O85l6XeVOQrj+10NLw=; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTGh5K968C2Cl84ptSi+4y/RZ/kVjRI/KuhQFT9EdVF+wlBRkUV3+MnA4Bw8USczqh K75Ks9fzzqoUpxb7GlBjbnkhjHyFx4/Ig31C73IxKiEP0jiid6Tlem7NohMXSaR+5FMEhK ifHB8gtzfUTonlinprF4mw7WPTut7T/J1hPsQXDLSJK0xqaYcZbKfDVq23wYMjW2iywqpO ZIPaJ4ce5Zm6PCb9LkghPIarZYc8Qnu+WxwoCZiOXCKojQi16QdbuVc39mEboH71fqwON2 cQwxZsIGEE5+oDvRemv0bEM6otLHIcNZE8FD2rvXxw3NzcIK91ZKa9ZQuG1p86j7bXidbN bTt2lMDWBc72Ycb2zfdXeYr8tOieQM+emlz06TGu4mwTOBMAeH/bYdIObNhlmvQ2NOcZYg cNBGBqigPaupTMhTkhD4IQvoWYJDI65SwzwWtAutEgzZaUxZFmZM2BpiWjda7sWrsvqhw5 lIABPrgE0lVg1eFk7slpb+3GC9Ky2XqeIL2mFEfGwGbrUAA7idIENWnzP9BdjZQsHQANAg OlAI8UpCeKEqrMIqXOTeSw2mGhTQO70D9PZIJlMiQKs2t1auwCWngeSkV/diVoEF/CJ3NJ ULSmsbW8OmioGjZ9Rk9TYwK3D/Q2NqIexOsljbhnaFsvbSEMAQYIRW+SeQug X-ME-Proxy: Feedback-ID: i03f14258:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 13 Oct 2026 19:14:44 -0400 (EDT) Date: Tue, 13 Oct 2026 17:13:52 -0600 From: Alex Williamson To: Matt Evans Cc: Leon Romanovsky , Jason Gunthorpe , Alex Mastro , Christian =?UTF-8?B?S8O2bmln?= , Kevin Tian , Pranjal Shrivastava , Longfang Liu , Mahmoud Adam , David Matlack , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Sumit Semwal , Ankit Agrawal , Alistair Popple , Vivek Kasireddy , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, kvm@vger.kernel.org, linux-pci@vger.kernel.org, alex@shazbot.org Subject: Re: [PATCH v8 7/9] vfio/pci: Clean up BAR zap and revocation Message-ID: <20261013171352.1c467040@shazbot.org> In-Reply-To: <20261006193643.76330-8-matt@ozlabs.org> References: <20261006193643.76330-1-matt@ozlabs.org> <20261006193643.76330-8-matt@ozlabs.org> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 6 Oct 2026 20:36:35 +0100 Matt Evans wrote: > diff --git a/drivers/vfio/pci/vfio_pci_core.c b/drivers/vfio/pci/vfio_pci_core.c > index cb0e4865d110..986852b1d44f 100644 > --- a/drivers/vfio/pci/vfio_pci_core.c > +++ b/drivers/vfio/pci/vfio_pci_core.c > @@ -1337,13 +1338,18 @@ static int vfio_pci_ioctl_reset(struct vfio_pci_core_device *vdev, > * have NoSoftRst-, the reset function can cause the PCI config space > * reset without restoring the original state (saved locally in > * 'vdev->pm_save'). > + * > + * The zap is done after making the device accessible in D0, > + * because a DMABUF importer could access the device as part > + * of its revocation cleanup. Nit, s/zap/revoke/ Thanks, Alex > */ > vfio_pci_set_power_state(vdev, PCI_D0); > > - vfio_pci_dma_buf_move(vdev, true); > + vfio_pci_revoke_bars(vdev); > + > ret = pci_try_reset_function(vdev->pdev); > if (__vfio_pci_memory_enabled(vdev)) > - vfio_pci_dma_buf_move(vdev, false); > + vfio_pci_unrevoke_bars(vdev); > up_write(&vdev->memory_lock); > > return ret;