From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx2-f5.google.com (mail-yx2-f5.google.com [74.125.224.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C43AB476CF1 for ; Tue, 13 Oct 2026 17:33:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791912804; cv=none; b=I9BwFA/4e4eT3qIPhLPCCD2UHYRw9PohWhhGL46pbxymZxHZTbUt2DJ1pGPYjHgYFYEJAzY9QRoBxzLx0mz16yD9IVdzvE/kFsk5P82uw9nXV683dxdUUsLXe3j3MPihvQzwexIA6YQv/GeyGd0bkMggQnVXK4Qdug3sRLY08P4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791912804; c=relaxed/simple; bh=JVFkb7Cu6YP094+ZnATto6Q9s4QbtUg3QlEdZAc0Qo4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=rAoOXAx5kXImoesHWc23bJTaVntKZfOeF/zczTDUNYYGWsjdqrj/l2LBEh1yCcNmod1s1r5u5UuM3xVRNU4M6e29iTkVOyYXKWJlXb0myFcVoLcFwvADOUdoSfpE+7O7OIZbwSiGkUstT92P8FGjecLNtKIDr/2qxaqtFURjtqQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AiqjafpK; arc=none smtp.client-ip=74.125.224.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AiqjafpK" Received: by mail-yx2-f5.google.com with SMTP id 956f58d0204a3-672d92bbfd3so1444269d50.1 for ; Tue, 13 Oct 2026 10:33:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791912802; x=1792517602; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=ktaJr2DM5Zu0cnAztDTvIMhfnw3Hsx1asRS1ecJrXeg=; b=AiqjafpK1JYuCmn+s3TiNuPOZcd9gH6oLc0ptahOzx4EMyOWymGzmF43/cg+rE4h/z DWLLDpTEmEX+1qUBfe9zkkJSk/KWhxS7D/IMwyQeHiTl+25Fr1oGh6ueEGoOdPD/30kH 9xpDhE6rKyDWK+sHipKQcBJtbAWPqTBA4juOAmRDB77qtH7M+gfSOU7SffhwJxQeWaLH BO09wPhjIcEqMtDriZvP27sPMgnlVFusMUc2cipCF5iaF4blzTN/kfVw3gNt6ic3Ly5f bTFYI2T6Lk6JX5UqXWsZqm4iQZwxC78BUrprcUrupB/ICwS6wiuVs5iuyOV1oAiJ5Sgk H77Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791912802; x=1792517602; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ktaJr2DM5Zu0cnAztDTvIMhfnw3Hsx1asRS1ecJrXeg=; b=HP1UcYARy3TMAP8Tnlycxwssut9SFyRVjdwOePTwqxxG5xJhCT0+LwcrGBNwv8Tvb+ F9/TYFgpQiH461gm/wPUd9K4ok9EhyAptrAFSNfK/TfPyLdWLBSCqWbuo9eShkIAa7X3 E+SIT0YYxHTEIN2mY+uXX7sqEUYIKATu2ky/yFLK4ABzTg4t+J8QuHM0Hk9byGHFEomo LEvSe26SIA46Nk/Z4qkzxyyc7wG+UFvgxP/CLqQKDHuKvhhlraHbyq7YrPBAFM+46L00 MJneT7v+gCaIlsC/72aU1SFr9wsal3smElE6jDEQQ46ufkMiUdEnvkdV2DAgUXtGX4oE J3Fw== X-Forwarded-Encrypted: i=1; AKwUvBz1anb+I68qHgQQsDQp75PWFs4XDcAAnz2gnEqSk4iFzdMjeTIjRfWTFG/R1/fEUCnDCFzbpmMlQi3aiRQ=@vger.kernel.org X-Gm-Message-State: AFq9FYJSPVVW9Ql7XOb8SC3xy6fWCKYszZkYa9jPHHmyK2o8NUwXlvvs LyHuq9+l1yXBJdqlwzBHTT+kG+3u6gcJxiCwK+BPKBfPdoFvTT+OX6dZ X-Gm-Gg: AYBFou1ZpJuJ1rG0UoN2X5QSRvid9Z+kHRkhNgZSuYgBPBqDrHSEvLn4J0vjEDbGkHl hpfchdldYxl9ndyCCN7a4gSB6H0hvMN20NEMUWulUorNoAxk+/H4zSSEniN/TaTFBqQEf5inTdx Rxz4bP7A7ibqfhWNh1O90AsH6FldG68tX8DgF76ttFDYmSgST4HQpm6l1/+TXo+ITDhSGo4f+o1 rGXsWiBX9jJsqKo6tO62Whv+oup4SguZt+Enwsph/GavrMUf+8V4UxncN0908IIJhBXer5YoYuY PvArdoMfApFvyB69dhyAzeOi6NiiERDISqicnd3zVrGSLzg89MqALWS6eyNTxDOLEkryubyQqfK BoEQM4j23Na4QIfQF7GmCbrNGlfNdJb/lGxKtl6PUxASDqlxoCSHT6Z+YonjXGMVHm+Df+z1m1b v146w931j0B1NV5/PDY9Ujq31SAOT8T5hgkqMMHV9lkwBGiS6bFqwnPeCKO1r3KOYiCcKr4jOu X-Received: by 2002:a05:690e:14c1:b0:675:40a6:142c with SMTP id 956f58d0204a3-67935f1c770mr4649463d50.22.1791912801676; Tue, 13 Oct 2026 10:33:21 -0700 (PDT) Received: from paradox ([98.122.223.224]) by smtp.gmail.com with ESMTPSA id 00721157ae682-8b07f1ecbfbsm46571567b3.23.2026.10.13.10.33.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Oct 2026 10:33:21 -0700 (PDT) From: Martin Belanger To: linux-nvme@lists.infradead.org, kbusch@kernel.org, sagi@grimberg.me, hch@lst.de Cc: axboe@kernel.dk, hare@suse.de, linux-kernel@vger.kernel.org, security@kernel.org, Martin Belanger , stable@vger.kernel.org, Daniel Wagner Subject: [PATCH] nvme: make the DH-HMAC-CHAP secret attributes readable by root only Date: Tue, 13 Oct 2026 13:32:41 -0400 Message-ID: <20261013173241.1713708-1-martin.nvme.dev@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The dhchap_secret and dhchap_ctrl_secret sysfs attributes have mode 0644. Their show functions return the secret, so any local user can read the DH-HMAC-CHAP secrets of a connected controller. Change the mode to 0600. Writing the attributes was already limited to root and is not changed. Fixes: f50fff73d620 ("nvme: implement In-Band authentication") Cc: stable@vger.kernel.org Cc: Daniel Wagner Assisted-by: LLM Signed-off-by: Martin Belanger --- drivers/nvme/host/sysfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/nvme/host/sysfs.c b/drivers/nvme/host/sysfs.c index e1e3dcfd084b..e0cb34545b97 100644 --- a/drivers/nvme/host/sysfs.c +++ b/drivers/nvme/host/sysfs.c @@ -864,7 +864,7 @@ static ssize_t nvme_ctrl_dhchap_secret_store(struct device *dev, return count; } -static DEVICE_ATTR(dhchap_secret, S_IRUGO | S_IWUSR, +static DEVICE_ATTR(dhchap_secret, 0600, nvme_ctrl_dhchap_secret_show, nvme_ctrl_dhchap_secret_store); static ssize_t nvme_ctrl_dhchap_ctrl_secret_show(struct device *dev, @@ -922,7 +922,7 @@ static ssize_t nvme_ctrl_dhchap_ctrl_secret_store(struct device *dev, return count; } -static DEVICE_ATTR(dhchap_ctrl_secret, S_IRUGO | S_IWUSR, +static DEVICE_ATTR(dhchap_ctrl_secret, 0600, nvme_ctrl_dhchap_ctrl_secret_show, nvme_ctrl_dhchap_ctrl_secret_store); #endif -- 2.53.0