From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f225.google.com (mail-yw1-f225.google.com [209.85.128.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 235735476E6 for ; Tue, 13 Oct 2026 20:08:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.225 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791922095; cv=none; b=g7SDFto3POJ4x2OZSAkoYkJxOS/Pe2mPUJz3IQPWzUKuoJ0+QTCnHdCySf2ua1c2c8vPDYbd0bnJ4DDoQKDtBBSRTikeRWkdGfPEYPMbH5BUW+/MNuiOhKaA8MI+87vRNDvrOiF5Z7rcGQFo5dP245xxSnhFHw3e/tt9cK/PsCo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791922095; c=relaxed/simple; bh=nuj98LMHJV7YXMvZFP0mgsnkil3gxXP9Diu5IS6CATg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mofoccI63eRHEzziW3FhoQTPHw/Ov6HMVbO3brOv787X7kR9+lP8nAoeOstADgt2SfaZDlvNOyEA/b98NxWUPus0AyGL4i2/MJ2pdHOo7cnD7jMpLNWfk9H9RrQ0Iz2wC26lW36+rdVeZPDlYQSzcnVtR95V+lsPDcP+C21Tf14= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=Z91HPY7z; arc=none smtp.client-ip=209.85.128.225 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="Z91HPY7z" Received: by mail-yw1-f225.google.com with SMTP id 00721157ae682-8ac551be4d3so27021527b3.3 for ; Tue, 13 Oct 2026 13:08:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791922092; x=1792526892; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=UOX1fnqCCqvGPeGhBPtjplBZCMxVrAi4/APZ6zwxUvY=; b=vIGW9aCrsBJTneBOIcHzZ+3diuwy8CEjmo70MMbRqrTL677E8pmG4PZ9hP9qVw3Dgs Cc40PefYDQDTqskhvB1lHlla2iUlESrK75IGq6QxikNzoh7Glb+lTe1UBLy6NP51PrEW 0OpZs5pdZ6vCyL22mntHg1SoHjkQkuuzGv9I5ekR0TKFOIVS519I882IWdvTJv75Cl0M KhFWQqQBj9fhL3qQ89px/utjVZEn98P7gSMUYT1BbSiax+5kksvxzb0GHdQzYjfL7qHb /sXRQ0NrU0Nf9VQ/VcRg9L8HYgzdUUukviTG275rkX37iihk4MEVbBMipl8D4AnJAO6v 5VqQ== X-Forwarded-Encrypted: i=1; AKwUvBwemuZlt4prCsbPjBY1oXgzl0BYDZF/6if4zkAPcuF4Zkkl7/CDuoBTSm7V2iSM7oRKaHeiDRKuTAnPkxk=@vger.kernel.org X-Gm-Message-State: AFq9FYLiFAVd276CgiWNwjo2BpwZSFFh6+YhjMt5kcorQNGmkjQ0Ugy7 oJDujbdeC4dgNKD+mwTu9/vPDGaDCXqNCMqLYFCKxngSIbWVha1D1uzRXfaYM/yLwx27Penqiu9 MeK6wALPFMvP9gmzCDyhlkUGm5DrMYsB8Bm7v/e9CgVrWPnBI7AJgPTmSCPVCTZ9uSLI8aM4M/I 4uKfXFvFqFuq0BXm06JcOQ3mtJOZIKXlwn4ejwZ+rA+fl66EEMfDDIGgSaMDhtMxCRrxgCOMtbw jGwBR1vVpBei5mGZH2I+rVydto6jrg= X-Gm-Gg: AYBFou03Ek7Tfukx83FZvpslJIx1f6W0FDv8iQLNYmCs4XydEGEocQ/HfeXKt35AHok GoOo1z1DklC5k+XvuTFGCBLVxi+x8JbMg6e0A+gor+aCepTaY8/WLeAWCrUXekMiOlT39b7FaOd 0np1Z9zY9mr1STwR93PYP3TFKTgGJfUzKaVVnnFB1UPJElT6oeKZxNDbqLnCaMY24DIIDpGUUyQ XGsaKJi0ZuOatUzVoMPZv3/5YhO6+DKYdSFuhe7+lMTa9+VMlReDI+su+WCdIODNsm7ILsmUaOd ye+7Eg9plQcay0ZmE8HSsys3Ob76cCpkazKeLPhG4ISmVliwbOaZA0V0oMvd45EhRtVusMA7NsN ZexdeTq9Mwtd4DSsxD/ETjYvOZJ1OuqZUP+TgapNcuFa4SztK5EKanA8JCea7EoVn+Mh3GDZboa JiitSdnDLFoDIOMTq+aHYfpDleWXSnnKoqej/nawy41WyU X-Received: by 2002:a05:690c:6d84:b0:8b0:8b34:edc2 with SMTP id 00721157ae682-8b08b34f047mr35035717b3.19.1791922091867; Tue, 13 Oct 2026 13:08:11 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-120.dlp.protect.broadcom.com. [144.49.247.120]) by smtp-relay.gmail.com with ESMTPS id 00721157ae682-8b07f30c569sm696567b3.37.2026.10.13.13.08.11 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Oct 2026 13:08:11 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-dl1-f69.google.com with SMTP id a92af1059eb24-152d1363a29so12558478c88.1 for ; Tue, 13 Oct 2026 13:08:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1791922091; x=1792526891; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=UOX1fnqCCqvGPeGhBPtjplBZCMxVrAi4/APZ6zwxUvY=; b=Z91HPY7zRaFWXBohwshKSeOvqCw5QU0xXoYnVzee/XF3Ai2ERedjUDYHnTdhnpyEJz eObThpIIG/bG6Z9XWNwVCD2S5kGean0wUjpApvGjsX7W2rIXpCyeNhHnmhcIEmnnhW+d VJtaPWOc/hLOCd9h9fb7jNFPb/NIk659repFs= X-Forwarded-Encrypted: i=1; AKwUvBxPxSDLl5VX8OTKc+bupibAqzViC519+ytaxdpnst8fEfc9/HCGzpk8TAVJJhNc8Xl7SGTSNpSgPnD8J/0=@vger.kernel.org X-Received: by 2002:a05:701b:2707:b0:144:c127:dd1b with SMTP id a92af1059eb24-16a5fe7c188mr20179186c88.39.1791922090230; Tue, 13 Oct 2026 13:08:10 -0700 (PDT) X-Received: by 2002:a05:701b:2707:b0:144:c127:dd1b with SMTP id a92af1059eb24-16a5fe7c188mr20179129c88.39.1791922089345; Tue, 13 Oct 2026 13:08:09 -0700 (PDT) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-169a31f6f5csm39526585c88.11.2026.10.13.13.08.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Oct 2026 13:08:08 -0700 (PDT) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, Bhargava Marreddy , Dharmender Garg , Kumar Mudide , Ramakrishna Koduri Subject: [PATCH net-next v3 2/5] bnge: add bnge_err()/bnge_warn()/bnge_dbg() logging helpers Date: Wed, 14 Oct 2026 01:36:42 +0530 Message-ID: <20261013200645.1346299-3-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261013200645.1346299-1-bhargava.marreddy@broadcom.com> References: <20261013200645.1346299-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e netdev_err() and netdev_warn() print "(unnamed net_device) (uninitialized)" instead of the interface name while the netdev has not been registered yet. Later patches in this series run NQ0 init before register_netdev() in probe, so messages from the HWRM ring alloc/free paths and from NQ0's NAPI would be logged that way. Add bnge_err(), bnge_warn() and bnge_dbg(), which take a struct bnge_dev and log through the netdev once it has been registered, including while it is being unregistered and after, where it keeps its name. Before that, fall back to dev_err()/dev_warn()/dev_dbg() on the PCI device. Convert the HWRM ring alloc/free error messages, the IRQ affinity hint warning and the async event debug message, which are reachable from those paths. No other message is changed. No functional change. Signed-off-by: Bhargava Marreddy Reviewed-by: Dharmender Garg Reviewed-by: Kumar Mudide Reviewed-by: Ramakrishna Koduri --- drivers/net/ethernet/broadcom/bnge/bnge.h | 18 ++++++++++++++++++ .../net/ethernet/broadcom/bnge/bnge_hwrm_lib.c | 8 +++++--- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 5 ++--- drivers/net/ethernet/broadcom/bnge/bnge_txrx.c | 4 ++-- 4 files changed, 27 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge.h b/drivers/net/ethernet/broadcom/bnge/bnge.h index 4479ccd071f5..e76ba4e063bb 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge.h @@ -220,6 +220,24 @@ struct bnge_dev { u32 phy_flags; }; +/* The netdev has no name until register_netdev(), so log through the PCI + * device before that (e.g. during probe). + */ +#define bnge_log(level, bd, fmt, ...) \ + do { \ + struct bnge_dev *__bd = (bd); \ + \ + if (__bd->netdev && \ + READ_ONCE(__bd->netdev->reg_state) != NETREG_UNINITIALIZED)\ + netdev_##level(__bd->netdev, fmt, ##__VA_ARGS__);\ + else \ + dev_##level(__bd->dev, fmt, ##__VA_ARGS__); \ + } while (0) + +#define bnge_err(bd, fmt, ...) bnge_log(err, bd, fmt, ##__VA_ARGS__) +#define bnge_warn(bd, fmt, ...) bnge_log(warn, bd, fmt, ##__VA_ARGS__) +#define bnge_dbg(bd, fmt, ...) bnge_log(dbg, bd, fmt, ##__VA_ARGS__) + static inline bool bnge_is_roce_en(struct bnge_dev *bd) { return bd->flags & BNGE_EN_ROCE; diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_hwrm_lib.c b/drivers/net/ethernet/broadcom/bnge/bnge_hwrm_lib.c index 651c5e783516..fb960bff85fa 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_hwrm_lib.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_hwrm_lib.c @@ -1302,7 +1302,8 @@ int hwrm_ring_free_send_msg(struct bnge_net *bn, bnge_hwrm_req_drop(bd, req); exit: if (rc) { - netdev_err(bd->netdev, "hwrm_ring_free type %d failed. rc:%d\n", ring_type, rc); + bnge_err(bd, "hwrm_ring_free type %d failed. rc:%d\n", + ring_type, rc); return -EIO; } return 0; @@ -1395,7 +1396,7 @@ int hwrm_ring_alloc_send_msg(struct bnge_net *bn, req->int_mode = RING_ALLOC_REQ_INT_MODE_MSIX; break; default: - netdev_err(bn->netdev, "hwrm alloc invalid ring type %d\n", ring_type); + bnge_err(bd, "hwrm alloc invalid ring type %d\n", ring_type); return -EINVAL; } @@ -1406,7 +1407,8 @@ int hwrm_ring_alloc_send_msg(struct bnge_net *bn, exit: if (rc) { - netdev_err(bd->netdev, "hwrm_ring_alloc type %d failed. rc:%d\n", ring_type, rc); + bnge_err(bd, "hwrm_ring_alloc type %d failed. rc:%d\n", + ring_type, rc); return -EIO; } ring->fw_ring_id = ring_id; diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c index 8cd0d8bd68c2..f8f81f3f7cd9 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -2696,9 +2696,8 @@ static int bnge_nq_request_irq(struct bnge_net *bn, struct bnge_napi *bnapi) cpumask_set_cpu(cpumask_local_spread(bnapi->index, numa_node), irq->cpu_mask); if (irq_set_affinity_hint(irq->vector, irq->cpu_mask)) - netdev_warn(bn->netdev, - "Set affinity failed, IRQ = %d\n", - irq->vector); + bnge_warn(bd, "Set affinity failed, IRQ = %d\n", + irq->vector); } return 0; } diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c b/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c index 472b02cc43b3..2f382514c6ea 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c @@ -1135,8 +1135,8 @@ static void bnge_async_event_process(struct bnge_net *bn, u32 data1 = le32_to_cpu(cmpl->event_data1); u32 data2 = le32_to_cpu(cmpl->event_data2); - netdev_dbg(bn->netdev, "hwrm event 0x%x {0x%x, 0x%x}\n", - event_id, data1, data2); + bnge_dbg(bn->bd, "hwrm event 0x%x {0x%x, 0x%x}\n", + event_id, data1, data2); switch (event_id) { case ASYNC_EVENT_CMPL_EVENT_ID_LINK_SPEED_CFG_CHANGE: -- 2.47.3