mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: yoxcu <mick@yoxcu.de>
To: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>
Cc: Abel Vesa <abelvesa@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Michael Auer <mick@yoxcu.de>
Subject: [PATCH] arm64: dts: qcom: sdm845: Route the SPMI interrupt through the PDC
Date: Tue, 13 Oct 2026 22:37:49 +0200	[thread overview]
Message-ID: <20261013203749.3078262-1-mick@yoxcu.de> (raw)

From: Michael Auer <mick@yoxcu.de>

The SPMI arbiter interrupt (PMIC RTC alarm, power key, charger) goes
directly to GIC SPI 481. In CX collapse the GIC does not detect
interrupts, so only interrupts routed through the PDC can wake the SoC.

SPI 481 is PDC pin 1. Route the interrupt through the PDC, as sc7180,
sm8250 and sc8280xp already do.

On a OnePlus 6 in CX collapse, a 60 s RTC alarm did not end s2idle. The
phone slept for 456 s, until the modem woke it. With this change the
alarm wakes it on time (after 62 s), and the power key wakes it too.

Assisted-by: LLM
Signed-off-by: Michael Auer <mick@yoxcu.de>
---
Tested on a OnePlus 6 with an sdm845-mainline 7.1-rc1 based kernel.
On qcom/for-next only the DTB build and dtbs_check (W=1) were run, for
all sdm845 and sdm850 boards.
On this phone CX collapse also needs the sdm845 ALC interconnect RFC,
sent separately.

 arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index 844b840bc546..52059ba75893 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -5176,7 +5176,7 @@ spmi_bus: spmi@c440000 {
 			      <0 0x0c40a000 0 0x26000>;
 			reg-names = "core", "chnls", "obsrvr", "intr", "cnfg";
 			interrupt-names = "periph_irq";
-			interrupts = <GIC_SPI 481 IRQ_TYPE_LEVEL_HIGH>;
+			interrupts-extended = <&pdc_intc 1 IRQ_TYPE_LEVEL_HIGH>;
 			qcom,ee = <0>;
 			qcom,channel = <0>;
 			#address-cells = <2>;

base-commit: d628f8fa591e8e78995afd179e6ee021135cba6c
-- 
2.43.0


             reply	other threads:[~2026-10-13 20:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-13 20:37 yoxcu [this message]
2026-10-14  8:37 ` Abel Vesa
2026-10-14  8:46 ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261013203749.3078262-1-mick@yoxcu.de \
    --to=mick@yoxcu.de \
    --cc=abelvesa@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®