From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f198.google.com (mail-dy1-f198.google.com [74.125.82.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 932A75650E8 for ; Tue, 13 Oct 2026 22:40:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.198 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791931226; cv=none; b=MvJFDQE91LE+SH7FCJPGzsCOFAByTjEUfJwg5L78Ha4P1FFiJ5oqrUmR1peTeqYzdQ7guiaRywNXYjSVbYejRyuNUe/8YwwUS7eKJQ4cCtQeMlB8l4kAXIpLBXlVhsio3A7De9u7vossyg5rB2Ihr28sGkKBu1d+6vxBQdV3j/c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791931226; c=relaxed/simple; bh=uNMrTEMgpiVDbGIrdW7hNuAL0UJnSkmxUybVeT9BNfA=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=S4bE/bZkufWsfiEnp7/+N1H2j5wj4ULmD8db1eZp4kB4rXOrltbJmPqNnljxcvK/cNXT824B42wlOvmu6xM56/WHOsm6thFFFoNf2H/9HU2SokeNwc1XhDGU/Efoi0Jgof6JRUs3cjMlUp7KkalBbPpJLM6wDoZSO4RQRLVx5nM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=kns9kZdQ; arc=none smtp.client-ip=74.125.82.198 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="kns9kZdQ" Received: by mail-dy1-f198.google.com with SMTP id 5a478bee46e88-35a4d2e39acso1187152eec.1 for ; Tue, 13 Oct 2026 15:40:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1791931221; x=1792536021; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=4r3hXDLd6Bqk9XmcFR/JS5uHIdkPs2TN+2FSnsngXIE=; b=kns9kZdQnF6cg4c0ebOilPzJCHe8toqjGE3fYLbFm6TYXt+cVn4n8vjUDDFEqtYRdg j214Tc4Y6nRycI8073Q0jtW4bqsD0NBk2H3bvq9dbC5ko9g2XT3yfMelKJiklZEw0LRU 1CTrD2WgwNDK0koQYCyIeKRq0ufaSEK39WKRgtAfqk+Go7KP2M7XZ+onpEe4u6Xt6aFJ lceHgBMEhKocQVYKjgPFAjVZz0GXrK3rHcsOO0B23LrtIwXXDGOrIzPoOo51SeWaYuO7 hSc3VIWtfqQ2bjH4hs26pU6WB3XzFO3FB5P1K3+iHf8bfphXcqsJAhvcYY+UTh6rXNoa Je/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791931221; x=1792536021; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4r3hXDLd6Bqk9XmcFR/JS5uHIdkPs2TN+2FSnsngXIE=; b=cHNWePcAh2rloJxsn1/adhria5lZN4s9L0ZFQqZcd1kX2LYkHuIendJutwzimj2V9Y f0ANN/7DXZWrlAoOBfOemCkB572xjOev0r/Ox0af96BGkkJlHNM/NJ3215zMlzzUq69C oP/t/2IG8Az91Y7bMZmpWDiFVNQtrSU9iitM7MXWuwZOrsrRJ/lQO5SCG9jE0cnxT/5d sG0HDDAUwgiWcB/v4oq1HEUXdZi6mnVIG5EXmF3Czfy+SfGSYyVf/Ow/UazrIKamMxjg lZG0Py/1KQwGigMcM1LoI0eXpoIiNs4aNKx4tPGeyisC+svokxhw6yDz2j6G0CIFcHO6 n/xg== X-Forwarded-Encrypted: i=1; AKwUvBzs3O5ZAeBkJBRXIKcrqieW8ovL9JDoeN9f6MTXkEPVwYt3NGo/l6Wnzb4rD41bSgaamADcTR9jztG/mwU=@vger.kernel.org X-Gm-Message-State: AFq9FYL+6KLf3nuKCS5/DyNugYXt81nVsv8rEcRs9wIdcQBoMXqgsmA7 4r/xUnMhDAgGrLPviQ1PxWebLCZmw2m8mmFHv6+NLkRc6l6ldlHg1xyx07OSEY1d8rHYFgWkZmZ iJMvCCQoJkA== X-Received: from dyu6.prod.google.com ([2002:a05:693c:8106:b0:352:94e:a8c9]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7301:71a8:b0:358:f717:ff61 with SMTP id 5a478bee46e88-358f717ff90mr13337962eec.6.1791931219210; Tue, 13 Oct 2026 15:40:19 -0700 (PDT) Date: Tue, 13 Oct 2026 15:39:38 -0700 In-Reply-To: <20261013223946.1836757-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20261013223946.1836757-1-irogers@google.com> X-Mailer: git-send-email 2.56.0.385.gd3acb90ef8-goog Message-ID: <20261013223946.1836757-4-irogers@google.com> Subject: [PATCH 03/11] sh: sq: Add missing kobject release callback to ktype_percpu_entry From: Ian Rogers To: Greg Kroah-Hartman , "Rafael J . Wysocki" , Danilo Krummrich , Miguel Ojeda , Kees Cook , Nathan Chancellor Cc: Nick Desaulniers , Bill Wendling , Justin Stitt , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Nayna Jain , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Viresh Kumar , David Teigland , Alexander Aring , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Richard Weinberger , Zhihao Cheng , Felix Kuehling , Alex Deucher , "=?UTF-8?q?Christian=20K=C3=B6nig?=" , driver-core@lists.linux.dev, llvm@lists.linux.dev, linux-hardening@vger.kernel.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-pm@vger.kernel.org, linux-acpi@vger.kernel.org, gfs2@lists.linux.dev, xen-devel@lists.xenproject.org, linux-s390@vger.kernel.org, linux-mtd@lists.infradead.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ian Rogers Content-Type: text/plain; charset="UTF-8" In sq_dev_add(), sq_kobject[cpu] is dynamically allocated with kzalloc_obj() and initialized with ktype_percpu_entry. When sq_dev_remove() calls kobject_put(kobj), the kobject is never freed because ktype_percpu_entry lacks a .release callback. Provide a sq_kobj_release() callback that calls kfree(kobj). Fixes: d7c30c682a27 ("sh: Store Queue API rework.") Assisted-by: Antigravity:gemini-3.1-pro Signed-off-by: Ian Rogers --- arch/sh/kernel/cpu/sh4/sq.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/sh/kernel/cpu/sh4/sq.c b/arch/sh/kernel/cpu/sh4/sq.c index 908a8e09113b..f33864958487 100644 --- a/arch/sh/kernel/cpu/sh4/sq.c +++ b/arch/sh/kernel/cpu/sh4/sq.c @@ -331,7 +331,13 @@ static const struct sysfs_ops sq_sysfs_ops = { .store = sq_sysfs_store, }; +static void sq_kobj_release(struct kobject *kobj) +{ + kfree(kobj); +} + static struct kobj_type ktype_percpu_entry = { + .release = sq_kobj_release, .sysfs_ops = &sq_sysfs_ops, .default_groups = sq_sysfs_groups, }; -- 2.56.0.385.gd3acb90ef8-goog