From: Carlos Llamas <cmllamas@google.com>
To: David Howells <dhowells@redhat.com>,
David Woodhouse <dwmw2@infradead.org>
Cc: Sami Tolvanen <samitolvanen@google.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Nathan Chancellor <nathan@kernel.org>,
Xi Ruoyao <xry111@xry111.site>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Will Deacon <will@kernel.org>,
kernel-team@android.com, linux-kernel@vger.kernel.org,
Giuliano Procida <gprocida@google.com>,
Carlos Llamas <cmllamas@google.com>,
"open list:CERTIFICATE HANDLING" <keyrings@vger.kernel.org>
Subject: [PATCH v3] certs: specify byte alignment
Date: Tue, 13 Oct 2026 22:45:51 +0000 [thread overview]
Message-ID: <20261013224552.557528-1-cmllamas@google.com> (raw)
In-Reply-To: <8932791855928d9f12b7356648e2ebacfc126bee.camel@xry111.site>
From: Giuliano Procida <gprocida@google.com>
The alignments specified in system_certificates.S and
revocation_certificates.S are intended to be byte quantities.
However, the .align macro is architecture dependent and on arm64 it
behaves as .p2align. So use the .balign macro to avoid unnecessary
padding due to over-alignment.
Signed-off-by: Giuliano Procida <gprocida@google.com>
Acked-by: Will Deacon <will@kernel.org>
Tested-by: Carlos Llamas <cmllamas@google.com>
Signed-off-by: Carlos Llamas <cmllamas@google.com>
---
v3: tested, collected tags, rebased on top of mainline.
certs/revocation_certificates.S | 4 ++--
certs/system_certificates.S | 8 ++++----
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/certs/revocation_certificates.S b/certs/revocation_certificates.S
index f21aae8a8f0e..a53b49d49931 100644
--- a/certs/revocation_certificates.S
+++ b/certs/revocation_certificates.S
@@ -4,14 +4,14 @@
__INITRODATA
- .align 8
+ .balign 8
.globl revocation_certificate_list
revocation_certificate_list:
__revocation_list_start:
.incbin "certs/x509_revocation_list"
__revocation_list_end:
- .align 8
+ .balign 8
.globl revocation_certificate_list_size
revocation_certificate_list_size:
#ifdef CONFIG_64BIT
diff --git a/certs/system_certificates.S b/certs/system_certificates.S
index 003e25d4a17e..ea6984b427c9 100644
--- a/certs/system_certificates.S
+++ b/certs/system_certificates.S
@@ -4,7 +4,7 @@
__INITRODATA
- .align 8
+ .balign 8
.globl system_certificate_list
system_certificate_list:
__cert_list_start:
@@ -20,14 +20,14 @@ __cert_list_end:
system_extra_cert:
.fill CONFIG_SYSTEM_EXTRA_CERTIFICATE_SIZE, 1, 0
- .align 4
+ .balign 4
.globl system_extra_cert_used
system_extra_cert_used:
.int 0
#endif /* CONFIG_SYSTEM_EXTRA_CERTIFICATE */
- .align 8
+ .balign 8
.globl system_certificate_list_size
system_certificate_list_size:
#ifdef CONFIG_64BIT
@@ -36,7 +36,7 @@ system_certificate_list_size:
.long __cert_list_end - __cert_list_start
#endif
- .align 8
+ .balign 8
.globl module_cert_size
module_cert_size:
#ifdef CONFIG_64BIT
--
2.56.0.385.gd3acb90ef8-goog
prev parent reply other threads:[~2026-10-13 22:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-12 10:00 [PATCH] system certificates: " Giuliano Procida
2025-09-22 16:38 ` Will Deacon
2025-09-22 20:17 ` Giuliano Procida
2025-09-23 8:13 ` [PATCH v2] certs: " Giuliano Procida
2025-09-23 9:08 ` Will Deacon
2026-08-06 13:50 ` Xi Ruoyao
2026-08-06 14:32 ` Giuliano Procida
2026-08-08 18:49 ` Xi Ruoyao
2026-10-13 22:45 ` Carlos Llamas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261013224552.557528-1-cmllamas@google.com \
--to=cmllamas@google.com \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=gprocida@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-team@android.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=samitolvanen@google.com \
--cc=will@kernel.org \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®