From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-a2-smtp.messagingengine.com (fhigh-a2-smtp.messagingengine.com [103.168.172.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA3CA4CE695 for ; Wed, 14 Oct 2026 11:49:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.153 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791978554; cv=none; b=U+fZ1VX9R2PX7FflgI/gxWL/Tl/lNdGGBqttCL5mO5d+JIvHBjxqWQxo3z0nxquTd+/IpAFzKeZbnJEB+gJDUhyiijhGeOJMNWsViNURnNRlbqJmz54eVxgsnh5Yrf8Ii9VoPBL44san8P7C8uDbaj3yD+UquKPZK+ws/OIGmBk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791978554; c=relaxed/simple; bh=z8r4MRtUi0LNk7lRzCoa0ekWmE4fhmo2OSQMOtBUgZ4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cvcs7dcle19iLeVbj8swaTX7HrFpnVZUcmwtmDqvQr32d1t6I7g7u/GfPEdbT6hwgxDgb8rEy0nI8xPh8waoqNawMW7XeJBUpRQApvF67X+yQ4MzVik3rS8nnp9xqz9xU9pIcH7Wu4DrS0Jor0F0TuSQuQIRZ7cbhyph5NCryGw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kroah.com; spf=pass smtp.mailfrom=kroah.com; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b=N23a4QPq; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=SsJpoFog; arc=none smtp.client-ip=103.168.172.153 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kroah.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kroah.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="N23a4QPq"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="SsJpoFog" Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfhigh.phl.internal (Postfix) with ESMTP id BAB9E14000AE for ; Wed, 14 Oct 2026 07:49:06 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-05.internal (MEProxy); Wed, 14 Oct 2026 07:49:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1791978546; x=1792064946; bh=ljC1EWPWgR PS5tUHzsiAKUkPoihH7ZlQU23a6W9iHaM=; b=N23a4QPqTIewXlHX9ZszNsRyaq KDk5THBTQPf9OLUHbQc4Wcehe6S3A5fym5r9fd00o6BowcsFoKaW73aIRdgD3P2z KJ6S8KGY94vChChxK2cen2ijs2J4GzhMaGTUIEvJWd3/swgXoYJwCJjx2jSY/xAU NB3RMwsDSZLm0Q/lssr9ouH0USAR9cgCZJaNREfQk9cg/ZSCtSnEg890ne2X7cNB FfdPh6CTBNHc+vWXWOINYtrFDgNXyxk/ORhQ74/kzA4qgI1cdhkoMM4cLTJx08WN Zvl4UIqJ9LbM4JXJIhjmia4+V9g+1Mcb9w/Ua1jsh5FAAvdIieN9t0WBqutQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1791978546; x=1792064946; bh=ljC1EWPWgRPS5tUHzsiAKUkPoihH7ZlQU23 a6W9iHaM=; b=SsJpoFogEkA+tO5b/0cjDz3BuyNIbNkn6CUDHXdwGSYbQm4dyP/ MjiJ/XTLWnKJQLCh5ZE6E973SrPLUgs5GY6/CKurl49HTF8Vv2bQ6UWiRuChBdel cNTHVJRdNy5TwG/A1mkLjam8u+guR4qT0N80B+8p3P3TVOEz5c8nFYw+n4YEbSwd smhZ7TiNDnG7h48eWJEUoYfC4FmVVUQ+GEUj6nBzyCuBGqZflvMxX8eqEa/LL4Dh cgRDBz31kxqcVLTGoW5UEl6FonwU+TZRRlLglyd+5ojgmHc4cz/wfa50v0ZYBrtC in4iVNOKlctHg9efklSL2EN+EmWcgAt7dQA== X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-06; repo=github.com/dkim2wg/interop; date=2026-10-04; sw=lmtpprox; action=sign d=kroah.com a=rsa-sha256; DKIM2-Signature: i=1; m=1; t=1791978546; d=kroah.com; mf=PGdyZWdAa3JvYWguY29tPg==; rt=PGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc+; s=fm2:rsa-sha256:qT9yqEN7YzlRUG/FPC88mbpo6A85vMIAiC7yo4Rs+vOVak/ 2tL7yzg3Ylmx/kX0WCr3dPqPcbNVd8Yfn9X8eisFE5JRjnHS+T1r9I/m2mVWcYL4 BWuc3yyR6MYYFttHbnXfKig9SNJwQA9CJUfFLsifG1IKgRcT6Wq/YrUV4DppJAtm JbAfnHh/R/Gf1zfVOD714iBsy1qV5XCAWyfRWWKCYaxK5i2rJNaWVeFMRxuiPszT QQvYPOL6pboRDWE1HuwX1vcx6Wyg8FkRVIT3OlHDubu/IyaC9KYD3iZhApLD++Id a+P8iw2yLeHfHVl/Db+fmAGpp3uGJ3LaRUgsvbw==; X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-06; repo=github.com/dkim2wg/interop; date=2026-10-04; sw=lmtpprox; action=mi-m=1; hc=12; hn=cc,content-disposition,content-type,date,feedback-id,from, in-reply-to,message-id,mime-version,references,subject,to; Message-Instance: m=1; h=sha256:NXqvzbL0EcVKcRouoKFLpRAfiCZ+PZx2mcFB+LVfxPc=:z8r4MRtUi0LNk7lRzCoa0ekWmE4fhmo2OSQMOtBUgZ4=; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFVeTgRVt8VgVVuURS2y6F5bHP7SB45kgAV0kCKhyd9ylXqJwTwTvQiC9dcAZHsZi Gzm+qOu5tvWIrxHx2wabEmTkbqM3P3tmYKUrsv7fKbngo2A1CSxt1+W66E2w1AOMbrw/44 /DuO2vurJ8PdA2BlrizzP1+17Z0exNBIjKuR9CJMOeG+yPX3kdWzUtl3bEqrCMbrbuZxy5 cU+BCGpxGF+D2a3Lzk1jE6/Hg13tLZBeYPZ24aKitB/vGGmHm2my/WeQPKXFqm41W9y9o/ kfkwBDUcCHEKKwmVv44NAqBrqms/zQWhszG1mXfU503Umoc16Scr+LVhmzcnElsrlXmNbZ BN1xzR/L1QALRiRIjjHKeILJP7hk9NR8fi8urAlsL9Yd2pFIj8XJK+0NRkRVR2a2fe9OoG ZF81uS6E6JhxsXj5yph4xU5G5mp19UrX327WpmCrqzx8tIaxSmSNIawn5VwQRpSHBklzz1 ILOMwSTlm/7HoUS1MHj53utuHYOWZyKjoYwU71JW3QwQ0LsCi4iKJ+OmZVCKEE+9MSK2Me A4XL5Xv0UZIi7x59RGNs0slviFZqKmZOQ12s/noV1wu4Z9X7zmW9vnQ30EnhC2j4TVn9g/ 1uCH5NVMk475dW0YKgrrQbLhEIZKMLYPJhc0ic7kgV06ei1s7iagcR6OyABA X-ME-Proxy: Feedback-ID: i787e41f1:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Oct 2026 07:49:05 -0400 (EDT) Date: Wed, 14 Oct 2026 13:49:10 +0200 From: Greg KH To: vienna-0FFH Cc: Alexander Aring , David Teigland , gfs2@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org, syzbot+04dfbd15d442517e713a@syzkaller.appspotmail.com Subject: Re: [PATCH] dlm: don't warn when closing a node without a connection Message-ID: <2026101400-roman-landmass-d03e@gregkh> References: <20261014090237.395-1-viennaoffh@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261014090237.395-1-viennaoffh@gmail.com> On Wed, Oct 14, 2026 at 05:02:37PM +0800, vienna-0FFH wrote: > Opening and closing a configfs comm entry without ever configuring an > address for it triggers the following warning: > > mkdir /sys/kernel/config/dlm/cluster > mkdir /sys/kernel/config/dlm/cluster/comms/1 > rmdir /sys/kernel/config/dlm/cluster/comms/1 > > dlm: closing connection to node 1 > ------------[ cut here ]------------ > !con > WARNING: fs/dlm/lowcomms.c:1455 at dlm_lowcomms_close+0x12d/0x470, CPU#1 > > Since commit 6f0b0b5d7ae7 ("fs: dlm: remove dlm_node_addrs lookup list") > the lowcomms connection has the same lifetime as the configfs comm > entry, but a connection is only created when an address is configured > via the addr attribute. Removing a comm entry for which no address was > ever set up is valid and the resulting close call has simply nothing > to do, so it must not warn. > > Reported-by: syzbot+04dfbd15d442517e713a@syzkaller.appspotmail.com > Closes: https://syzkaller.appspot.com/bug?extid=04dfbd15d442517e713a > Fixes: 6f0b0b5d7ae7 ("fs: dlm: remove dlm_node_addrs lookup list") > Cc: stable@vger.kernel.org > Signed-off-by: vienna-0FFH Real name is needed please. thanks, greg k-h