From: Pengpeng Hou <hppiscas@163.com>
To: johannes@sipsolutions.net
Cc: briannorris@chromium.org, chunfan.chen@gmail.com,
jeff.chen_1@nxp.com, francesco@dolcini.it,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
francesco.dolcini@toradex.com, hppiscas@163.com
Subject: Re: [PATCH v4] wifi: mwifiex: validate event lengths before copying bodies
Date: Wed, 14 Oct 2026 10:52:17 +0800 [thread overview]
Message-ID: <20261014025217.82975-1-hppiscas@163.com> (raw)
In-Reply-To: <97fdc1b8cff6477217100beb9b242ede810a7dc2.camel@sipsolutions.net>
Hi Johannes,
Yes. PCIe sets event_received even when its size condition skips the copy
into event_body. USB and SDIO rejection alone would leave inconsistent
handling and could leave PCIe consumers using an unchanged event body.
The PCIe length also includes the transport header. A revision needs to
validate that extent before trimming/pulling the skb, copy only the body
after both headers, and return a rejected event buffer to its DMA ring
without publishing the event. Dropping the buffer without that ring
completion is not sufficient.
I will hold v4 until that common rejection policy and PCIe buffer-return
path are covered together, rather than resend the USB/SDIO-only change.
Thanks,
Pengpeng
prev parent reply other threads:[~2026-10-14 2:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 14:20 Pengpeng Hou
2026-08-04 7:32 ` Jeff Chen
2026-08-11 21:37 ` Brian Norris
2026-09-03 18:59 ` Johannes Berg
2026-10-14 2:52 ` Pengpeng Hou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261014025217.82975-1-hppiscas@163.com \
--to=hppiscas@163.com \
--cc=briannorris@chromium.org \
--cc=chunfan.chen@gmail.com \
--cc=francesco.dolcini@toradex.com \
--cc=francesco@dolcini.it \
--cc=jeff.chen_1@nxp.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®