From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f181.google.com (mail-dy1-f181.google.com [74.125.82.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC70D31ED93 for ; Wed, 14 Oct 2026 04:55:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791953750; cv=none; b=PFLQnK6asHbd9ELTq4gX9XVhOPaB4Cg79EXrdrLlfFz8GonQlKXvAKlkU3RJtn1H9VnI5Hn/w4BTm4n73jISbFc6FnLei8pi8wd9SnSFZ5u2ZxGPbhfV42Wbo5gRZLs2WCnxY28cQeETZhbqGNkbM76VnY9Ogtfb8UcOGHfMIww= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791953750; c=relaxed/simple; bh=5Qw4a16lsBulx8wAb5cxpyc0vMifzgzNt21wJOz0sOk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Oifle5/ZW6NL33hQ33wxCCwsGNZV9Eo19qlmmYyS7jcQBTcej5xkRmMljc/QNKaExIlO783Hu6fShjcRB5OY/wLOdw0MSbLzL+x3YQOaRhAaC5r7LxcVO6tetevCQ9j6w1hQ65Rz686J9hi8Z956IzLUzCQI/ub0Y72KvBQVAsU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=povT1IDk; arc=none smtp.client-ip=74.125.82.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="povT1IDk" Received: by mail-dy1-f181.google.com with SMTP id 5a478bee46e88-35aa0cf7c40so3451025eec.1 for ; Tue, 13 Oct 2026 21:55:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791953749; x=1792558549; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5Qw4a16lsBulx8wAb5cxpyc0vMifzgzNt21wJOz0sOk=; b=povT1IDk9UlvzUkblm/oSCIVOQ9+5M4QTjJ7/e3xscpl0BYf04br6waKr69tmNxQnF wrq3rxN6epwXDwogmW89x5EXAATHg3Wa8jw9QEESxAufaWgU174vkiEJWsasXZxHwCCh 0+RI6eReszUhsAi16sGdXt1CSA4zvg0yXgyPOhDvGNu8xHOVKwF7z80/tzY/T2qsScIv /XYbrGe1aChduYMT+bfsdiPRrcNJOEq2InRxrJMVJRPCHDDMgW2r2jX7mE7QSzk8w+h3 PkOCULIEuZpmTS4JefA6RiDjlbizfVYXl+k1qtzrYRXIImxhTRX5RAe/mHPb8lXrnw6e OhGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791953749; x=1792558549; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=5Qw4a16lsBulx8wAb5cxpyc0vMifzgzNt21wJOz0sOk=; b=H/HIykW866VF4tvEO2Xl/x6jctPr5+5FJE8Sy0n/3U8R2UgpsvZABzx/BigygdPCjL aEywnaEQA3rW8/00TOGn9Z4kIlYYeou3HpqUmsqsBD7hWLkeG4GVxfIQZQSilJPhHjNz 0cjFYRNr4j9lWU47Z1kQwYO1pKz+kaAzV1cQk1egni0Caz48JUnc4f81lXXoHoObmVQ8 UnkZCp6dS9Dyito0/j1J9mAHCyK+ndIcRBS8/kMKlx4/UEIVp167UloEHuYwrFudOgs9 B/G8mYn5WBFxm64M3VVrrYqujRiUNO8SBKnfS58vA6qjx910eYbVt78kFAgStfa8YFRk 3naw== X-Forwarded-Encrypted: i=1; AKwUvBzw1E53Pe7jSL+Bi3XE+s7YfI2lkqBgTR5wY5+9ohIL86p4BsInJVPbfYTVugJ5nBLjmZSszeypOs6ea2I=@vger.kernel.org X-Gm-Message-State: AFq9FYK3AyhB2nkzKbjfhtn4gZ0x6aQgxDPuh5+TbSoZtcfiKGlL4JE2 gBlit/M8zORtfWFZ0/0odD7RSHIUaj5wnToeUvoz+z7oBxVnurd19v5/ X-Gm-Gg: AYBFou13gN+/atVW8Wrq++i/2TYjNlLXdrpWAFkitSBo0xtFwQwFRU4qOANzwG9NQzY qLiYJf/4P53GI8glKphb2CrzoFJWF2WokbBPUMm0aLG0Tsuf7rMI9Dmyc3T1TJfMUpgxe83YHVX HnQsnT0muYqCG7Jm2dRoszxBvSAEUwCveKDuaJ7MqzoqMZnbZinloxxEbKK8+48tpuKYGXhFkuS FYk2Fz1/Xsjyem1KMZkf/ITwFl7FOSd9svvAHLSQzpTF43Wn4X8fPGPMX62uyA9peCr40JkYGtt 6lcdvnOU/Fb93I73cpU95JUU4mNQka3bH+8xtzoMOV6045IVUUPdn2p0ZU4pMg+vxG3sNBN8l+B QHwUpQR8bEQ/ftifpUWYlWkz5g7fAKV19d2pZQyGhG545TGDOjOcORuIlztikZNl/p1raqWKlrt izVczZ3+49AWtK/maNlQiF9XJtuZYZbh7l+gp7sWT4XAeFJlHYQJxF351B6bmEubhwX2ZcAU7pF 0hSq9QLfhLR5UoWy35KIMUlwa5HWpa1nMWdig== X-Received: by 2002:a05:701b:21c5:b0:158:7ea9:4a92 with SMTP id a92af1059eb24-16a5e968c3emr18577460c88.17.1791953748768; Tue, 13 Oct 2026 21:55:48 -0700 (PDT) Received: from obadmin-Precision-3680.atlascopco.group ([167.103.3.1]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-169a2f17feasm55285032c88.9.2026.10.13.21.55.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Oct 2026 21:55:48 -0700 (PDT) From: Sahaj Chaudhari To: Mark Brown Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Sahaj Chaudhari Subject: Re: [PATCH] spi: omap2-mcspi: handle DMA setup failures Date: Wed, 14 Oct 2026 10:26:27 +0530 Message-ID: <20261014045627.2895305-1-sahaj123.sc@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <4a20222b-7d60-4763-9833-bc453d26ade8@sirena.org.uk> References: <20261013142004.1729849-1-sahaj123.sc@gmail.com> <4a20222b-7d60-4763-9833-bc453d26ade8@sirena.org.uk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Tue, Oct 13, 2026 at 04:40:00PM +0100, Mark Brown wrote: > Do we need to turn off the FIFO here before doing PIO? Yes, good catch. omap2_mcspi_set_fifo(spi, t, 1) runs before the DMA attempt, and omap2_mcspi_txrx_pio() polls per-word TXS/RXS without expecting FIFO mode. v2 disables the FIFO, with the channel off while its bits change, before falling back. I injected DMA setup failures on an AM642 with and without this change, and the PIO fallback completed with no errors or timeouts in both cases. The bus had no device attached, so that test does not show the FIFO problem. The change is based on reading the code and not on a reproduced failure. I have said so in the v2 commit message. v2: https://lore.kernel.org/r/20261014045617.2894886-1-sahaj123.sc@gmail.com