From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A91B48423C for ; Wed, 14 Oct 2026 07:18:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791962292; cv=none; b=povHExGZyy/BEMf6BCMCQR18CFvA5rBaFiDBrc9wnc1T9IslVdF7p9A06RLFIK8n1NZrpsedI5GwtfFImSelcEPCrE5kB0vsIeg4RsguFg3aHk6XH5TZ3TW0dv5Sm5h37h70epFjk0xwnpDLp/j5hCOw8OWdP/ONlBciss8Kdok= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791962292; c=relaxed/simple; bh=XAsShjY8Z5IlS5KJ3rSh157yIfXXyBkTp/ySZ5inQ1g=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dts2hW4OvJuns8ds2p+4cjvsQ1EhIq3RKhCVZKdIYnQrCxG2OYKwQWv5TyZLmB0lp5f2H5fe/vrINyayXgYlinLESpe9JRht43Gf1KqRagXMcof9G/KIwT8g1x2bseGLqUiO+q5sPLEKDF16MxExfWYvIS7j7Raf/81BuyDYppg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hezf1WMl; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hezf1WMl" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4a171b677d2so22586375e9.0 for ; Wed, 14 Oct 2026 00:18:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791962289; x=1792567089; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=KVXvU2y3CWgDkb2iD40+8fhR4es61+R0ZnlRm3BwJkU=; b=hezf1WMlQub1JgO0ymgQsQFV67TTNbyvgGmIR74Z2E2+II8b2FeOZKdEcf8GeMDTV7 9WX2REn1H7QyhTg9ev7MBHDBuNvo1w0w+SQnnwIrPhQUFF19uCKDT6LcrA0vHoLUsIrD xG5pD7Z6HMgcEgT33dm7GHXLiA0g4UNJjSL+dfaVmzDS/iKlA2QzVf1MuGLqz+x7H4ZE girUNZjMamy5DYxYwyn55bonuQER1HhwwERpZj+W8Y1yWiFU7UZwTxXIJ2V7F7Xhsc0o 4XS0jaCY1WzM2P5lNv8RY/dLHpGOe0Ka9xvuzSZLlsNmijkh4lb1FjElWRT3RG16P7L1 RaOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791962289; x=1792567089; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=KVXvU2y3CWgDkb2iD40+8fhR4es61+R0ZnlRm3BwJkU=; b=bLVtGzyZjeOVM9n/zGILOtopaABkwhk2S6meixAUb8Fyj8Nh3SMwS2IGYzpbw3jycj 59H1XRkE35uBXE5PMk4luwLj7cWDL2L74Th+o+twgZvCBCdzFD+mk+I0R0HTiRuzFlV/ iAalo3LfQCBU6cRyKXoB09YV92Rvvy2GLpsgUz37Tfcd/Ml2eAGdyo6myNjRiJwkl/v+ 5mUM1hrNy0RTtX/Esaxxds0x1N3A3bIy79WUzFOwzxMsiUELHeKxSE8Lx3AXo4l75ozC 7C3GD3WUZ+VVy2ZH5fCKzb9CoeV7u3+Mwht0dZl6KzafmZrwjq4wc2aOsoEH2Cz7f4p1 t/Qw== X-Forwarded-Encrypted: i=1; AKwUvByQdytRTupqOdmHEa6nHt+ViqYcCPDOq4RflccXRa+9hdHIX/jHxCu7/+QzFSsXmk39VCHEtxZ5FCjUPi8=@vger.kernel.org X-Gm-Message-State: AFq9FYJ/8nQM6lkkMRArNkg35Y2TwXclW8rXBHL5+CeCun8LWamHU1kK MHwK32oPWPbsR3RFgpjr2lFxXd++ncFllXqJauz3wrRYEy8efYgrf6iI X-Gm-Gg: AYBFou1/V0tIpHiDwh7FayyxvaExbIa+KVqbq3gr4lf9H8nJcMoJiQif8uRAUuuINbe Sjte4XJIV7yxAcDoTQSTkzfgi0taCpiCzouapaX2/P4GY7O97U948LwVp3tNkpTNcmVDn1Ug8pP vi+j+Z3UczWqG0LijtH/tKlGtNa03aqDJS+oJ5Ag1sSNQ5jy7O1I5RIYMav32RJ7MrPbtqoRgcU a4fNxXKikneap1V07P5qtGvra4hJiYnU9pz4Hk+XprAHPPlQ2VZfwm724hQBx4h4gtYJSQIxWSq mux8bmsqSjG9PbYN1G2iqbuF/rrl+p4gCRkd11deoIg+utPK86IJ8lQjawUSsF4X02wGk7J2QeA Hcsi9SHlV6LbU88DTMQfuXX5kR95DwdiE6+O5x21wK47FvaJKtBTXyN0Vof8aCqyIMlk6/Y7HVf fa5PCcXGGuBYWTgjunkJjK8csaQNEGRWehmh6J/IxOd7TQ522hJlkOlZzfMuHjOJCp03sopvz4r o0maZU/O1WZHRV+0PQ1YmA3L7fz1yFSlU9DKKoQxOHapDrM7jL1gaFB4aQ3mMmjU/rOOysH61dI 9WQuFNevl2U9yfpMgaRS8A== X-Received: by 2002:a05:600c:1c07:b0:4a1:b044:9ccd with SMTP id 5b1f17b1804b1-4a1b0449d00mr79174665e9.28.1791962288754; Wed, 14 Oct 2026 00:18:08 -0700 (PDT) Received: from Ansuel-XPS24.localdomain (host-95-235-252-189.retail.telecomitalia.it. [95.235.252.189]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-4a1b35d64e4sm18756285e9.0.2026.10.14.00.18.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2026 00:18:08 -0700 (PDT) From: Christian Marangi To: Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Christian Marangi , Daniel Golle , Qingfang Deng , SkyLake Huang , Matthias Brugger , AngeloGioacchino Del Regno , Ahmed Naseef , Joris Vaisvila , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH net-next v3 3/6] net: phy: mediatek: generalize cal_cycle function for GE SoC Date: Wed, 14 Oct 2026 09:17:34 +0200 Message-ID: <20261014071739.216345-4-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261014071739.216345-1-ansuelsmth@gmail.com> References: <20261014071739.216345-1-ansuelsmth@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In preparation for support of special Software Calibration for Airoha PHY, it's needed to generalize the cal_cycle function as Airoha needs only part of its logic (the wait logic) to complete a calibration cycle. Signed-off-by: Christian Marangi --- drivers/net/phy/mediatek/mtk-ge-soc.c | 32 ++++++++++++++++++--------- drivers/net/phy/mediatek/mtk-ge-soc.h | 3 +++ 2 files changed, 24 insertions(+), 11 deletions(-) diff --git a/drivers/net/phy/mediatek/mtk-ge-soc.c b/drivers/net/phy/mediatek/mtk-ge-soc.c index 2b1e9923db98..f3ce6e67eb38 100644 --- a/drivers/net/phy/mediatek/mtk-ge-soc.c +++ b/drivers/net/phy/mediatek/mtk-ge-soc.c @@ -39,20 +39,11 @@ struct mtk_socphy_shared { struct mtk_socphy_priv priv[4]; }; -/* One calibration cycle consists of: - * 1.Set DA_CALIN_FLAG high to start calibration. Keep it high - * until AD_CAL_COMP is ready to output calibration result. - * 2.Wait until DA_CAL_CLK is available. - * 3.Fetch AD_CAL_COMP_OUT. - */ -static int cal_cycle(struct phy_device *phydev, int devad, - u32 regnum, u16 mask, u16 cal_val) +int mtk_cal_cycle_wait(struct phy_device *phydev) { int reg_val; int ret; - phy_modify_mmd(phydev, devad, regnum, - mask, cal_val); phy_set_bits_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_AD_CALIN, MTK_PHY_DA_CALIN_FLAG); @@ -71,7 +62,26 @@ static int cal_cycle(struct phy_device *phydev, int devad, ret = phy_read_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_AD_CAL_COMP); if (ret < 0) return ret; - ret = FIELD_GET(MTK_PHY_AD_CAL_COMP_OUT_MASK, ret); + + return FIELD_GET(MTK_PHY_AD_CAL_COMP_OUT_MASK, ret); +} +EXPORT_SYMBOL_GPL(mtk_cal_cycle_wait); + +/* One calibration cycle consists of: + * 1.Set DA_CALIN_FLAG high to start calibration. Keep it high + * until AD_CAL_COMP is ready to output calibration result. + * 2.Wait until DA_CAL_CLK is available. + * 3.Fetch AD_CAL_COMP_OUT. + */ +static int cal_cycle(struct phy_device *phydev, int devad, + u32 regnum, u16 mask, u16 cal_val) +{ + int ret; + + phy_modify_mmd(phydev, devad, regnum, + mask, cal_val); + + ret = mtk_cal_cycle_wait(phydev); phydev_dbg(phydev, "cal_val: 0x%x, ret: %d\n", cal_val, ret); return ret; diff --git a/drivers/net/phy/mediatek/mtk-ge-soc.h b/drivers/net/phy/mediatek/mtk-ge-soc.h index 008efd148a2c..14370b5ce482 100644 --- a/drivers/net/phy/mediatek/mtk-ge-soc.h +++ b/drivers/net/phy/mediatek/mtk-ge-soc.h @@ -354,4 +354,7 @@ enum CAL_MODE { SW_M }; +/* MTK GE SoC common functions */ +int mtk_cal_cycle_wait(struct phy_device *phydev); + #endif /* _MTK_GE_SOC_H_ */ -- 2.55.0