mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Zach Schneider <me@zachschneider.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: rtl8723bs: remove remaining comparisons to true/false
Date: Wed, 14 Oct 2026 06:56:26 +0200	[thread overview]
Message-ID: <2026101410-estate-tasting-23bb@gregkh> (raw)
In-Reply-To: <20261013214129.699212-1-me@zachschneider.com>

On Tue, Oct 13, 2026 at 04:41:28PM -0500, Zach Schneider wrote:
> Checkpatch reports "Using comparison to true/false is error prone"
> in rtw_wlan_util.c, hal_com.c, hal_intf.c, odm.c and
> ioctl_cfg80211.c. Replace "x == true" with "x" and "x == false"
> with "!x".
> 
> bwmode_updated, bDisableSWChannelPlan and the HAL_DEF_MACID_SLEEP
> value are u8, and rtw_validate_ssid() returns u8, but they only ever
> hold true or false. ODM_RAStateCheck() returns bool. This does not
> change behavior.
> 
> Assisted-by: LLM
> Signed-off-by: Zach Schneider <me@zachschneider.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_wlan_util.c    | 2 +-
>  drivers/staging/rtl8723bs/hal/hal_com.c           | 2 +-
>  drivers/staging/rtl8723bs/hal/hal_intf.c          | 4 ++--
>  drivers/staging/rtl8723bs/hal/odm.c               | 2 +-
>  drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 2 +-
>  5 files changed, 6 insertions(+), 6 deletions(-)

Please read:
	https://lore.kernel.org/r/2026080354-skater-urgent-31b2@gregkh

thanks,

greg k-h

  parent reply	other threads:[~2026-10-14  4:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-13 21:41 Zach Schneider
2026-10-13 21:41 ` [PATCH 2/2] staging: rtl8723bs: fix long line and braces in odm.c Zach Schneider
2026-10-14  4:56 ` Greg Kroah-Hartman [this message]
2026-10-14 13:03   ` [PATCH 1/2] staging: rtl8723bs: remove remaining comparisons to true/false Zach Schneider

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026101410-estate-tasting-23bb@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=me@zachschneider.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®