mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
To: <broonie@kernel.org>
Cc: <alsa-devel@alsa-project.org>, <lgirdwood@gmail.com>,
	<perex@perex.cz>, <tiwai@suse.com>,
	<yung-chuan.liao@linux.intel.com>, <Basavaraj.Hiregoudar@amd.com>,
	<Sunil-kumar.Dommati@amd.com>, <venkataprasad.potturu@amd.com>,
	<Syed.SabaKareem@amd.com>, <Mario.Limonciello@amd.com>,
	<Richard.Gong@amd.com>, <Vijendar.Mukunda@amd.com>,
	<Poojitha.N@amd.com>, <linux-sound@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<sound-open-firmware@alsa-project.org>
Subject: [PATCH 00/13] ASoC: amd: acp: ACP7.B/7.F SoundWire machine driver support
Date: Wed, 14 Oct 2026 15:46:19 +0530	[thread overview]
Message-ID: <20261014101817.1240200-1-Vijendar.Mukunda@amd.com> (raw)

This series extends the AMD ACP SoundWire machine driver to support
ACP7.B and ACP7.F platforms, adds ACPI machine tables for SoundWire
codec configurations, and fixes several issues in the SOF SoundWire
machine driver.

Patches 1-2 add the infrastructure for ACP7.B/7.F SoundWire support.
Patch 1 adds PCI revision constants and the ACP7X_SDW_MAX_LINKS (4)
constant to soc_amd_sdw_common.h, and switches mc_probe() to set
max_sdw_links based on PCI revision. Patch 2 adds the get_acp7x_cpu_pin_id()
function and hooks it into create_sdw_dailink() for ACP7.B/7.F alongside
the existing ACP63 and ACP70 paths.

Patches 3-7 address DMIC DAI link selection and components string
handling for ACP7.B/7.F platforms. Patch 3 fixes the PDM quirk
evaluation order: ASOC_SDW_ACP_DMIC1 was checked before dmi_check_system()
and quirk_override were applied, making the fallback dead code. It also
corrects the condition to use else if, since only one PDM controller
can be active at a time. Patch 4 adds ASOC_SDW_ACP_DMIC1 to log_quirks()
for boot-time diagnostics. Patch 5 extends the DMIC DAI link enable
condition to also check amd_ctx->pdm_sel so that ACPI-selected PDM
controllers on ACP7.B/7.F are handled without requiring a DMI quirk.
Patch 6 moves the ignore_internal_dmic gate to the DMIC enable condition,
removing dead code and demoting a spurious dev_warn to dev_dbg. Patch 7
appends the DMIC components string to card->components in mc_probe()
when a DMIC link will be registered, mirroring the condition used in
sof_card_dai_links_create().

Patch 8 propagates the PCI subsystem vendor and device IDs to the ALSA
card via snd_soc_card_set_pci_ssid() for correct device identification.

Patch 9 fixes a pre-existing typo: the MODULE_AUTHOR macro call was
missing the closing '>' in the email address.

Patches 10-13 add ACPI machine tables and wire them into the SOF
descriptors. Patch 10 introduces amd-acp7x-acpi-match.c with four
ACP7.F SoundWire machine entries covering RT721+RT1320 (L0+L3),
RT721+RT1320 (L0+L1), standalone RT721, and standalone RT722. Patch 11
registers the ACP7.F SoundWire table as alt_machines in the ACP7.F SOF
descriptor. Patch 12 adds a single ACP7.B entry for RT721 (L0) + RT1320
(L3). Patch 13 registers the ACP7.B SoundWire table as alt_machines in
the ACP7.B SOF descriptor.

This patch series has dependency on the following SOF patch series:
https://lore.kernel.org/alsa-devel/20261014100902.1215212-1-Vijendar.Mukunda@amd.com/T/#t

Vijendar Mukunda (13):
  ASoC: amd: acp: add ACP7.B/7.F SoundWire link count for machine driver
  ASoC: amd: acp: add ACP7.B/7.F SoundWire DAI link support
  ASoC: amd: acp: fix PDM1 quirk and PDM controller selection for
    ACP7.B/7.F
  ASoC: amd: acp: log ASOC_SDW_ACP_DMIC1 quirk in SOF SoundWire machine
    driver
  ASoC: amd: acp7x: enable DMIC DAI link based on PDM controller
    selection
  ASoC: amd: acp: move ignore_internal_dmic gate to DMIC enable
    condition
  ASoC: amd: acp: add DMIC components string for SOF SoundWire machine
    driver
  ASoC: amd: acp: set PCI subsystem ID for SOF SoundWire machine driver
  ASoC: amd: acp: fix MODULE_AUTHOR missing closing angle bracket
  ASoC: amd: acp: add ACPI machine tables for ACP7.F SoundWire
  ASoC: SOF: amd: add alt_machines for ACP7.F SOF SoundWire
  ASoC: amd: acp: add SoundWire machine table for ACP7.B platform
  ASoC: SOF: amd: register SoundWire alt_machines for ACP7.B

 sound/soc/amd/acp/Makefile               |   2 +-
 sound/soc/amd/acp/acp-sdw-mach-common.c  |  36 +++++
 sound/soc/amd/acp/acp-sdw-sof-mach.c     | 101 ++++++++++--
 sound/soc/amd/acp/amd-acp7x-acpi-match.c | 198 +++++++++++++++++++++++
 sound/soc/amd/acp/soc_amd_sdw_common.h   |  32 ++++
 sound/soc/amd/mach-config.h              |   2 +
 sound/soc/sof/amd/pci-acp7x.c            |   2 +
 7 files changed, 360 insertions(+), 13 deletions(-)
 create mode 100644 sound/soc/amd/acp/amd-acp7x-acpi-match.c

-- 
2.48.1

             reply	other threads:[~2026-10-14 10:19 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-14 10:16 Vijendar Mukunda [this message]
2026-10-14 10:16 ` [PATCH 01/13] ASoC: amd: acp: add ACP7.B/7.F SoundWire link count for machine driver Vijendar Mukunda
2026-10-14 10:16 ` [PATCH 02/13] ASoC: amd: acp: add ACP7.B/7.F SoundWire DAI link support Vijendar Mukunda
2026-10-14 10:16 ` [PATCH 03/13] ASoC: amd: acp: fix PDM1 quirk and PDM controller selection for ACP7.B/7.F Vijendar Mukunda
2026-10-14 10:16 ` [PATCH 04/13] ASoC: amd: acp: log ASOC_SDW_ACP_DMIC1 quirk in SOF SoundWire machine driver Vijendar Mukunda
2026-10-14 10:16 ` [PATCH 05/13] ASoC: amd: acp7x: enable DMIC DAI link based on PDM controller selection Vijendar Mukunda
2026-10-14 10:16 ` [PATCH 06/13] ASoC: amd: acp: move ignore_internal_dmic gate to DMIC enable condition Vijendar Mukunda
2026-10-18 16:59   ` Pierre-Louis Bossart
2026-10-19  2:53     ` Mukunda,Vijendar
2026-10-14 10:16 ` [PATCH 07/13] ASoC: amd: acp: add DMIC components string for SOF SoundWire machine driver Vijendar Mukunda
2026-10-14 10:16 ` [PATCH 08/13] ASoC: amd: acp: set PCI subsystem ID " Vijendar Mukunda
2026-10-14 10:16 ` [PATCH 09/13] ASoC: amd: acp: fix MODULE_AUTHOR missing closing angle bracket Vijendar Mukunda
2026-10-14 10:16 ` [PATCH 10/13] ASoC: amd: acp: add ACPI machine tables for ACP7.F SoundWire Vijendar Mukunda
2026-10-14 10:16 ` [PATCH 11/13] ASoC: SOF: amd: add alt_machines for ACP7.F SOF SoundWire Vijendar Mukunda
2026-10-14 10:16 ` [PATCH 12/13] ASoC: amd: acp: add SoundWire machine table for ACP7.B platform Vijendar Mukunda
2026-10-14 10:16 ` [PATCH 13/13] ASoC: SOF: amd: register SoundWire alt_machines for ACP7.B Vijendar Mukunda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261014101817.1240200-1-Vijendar.Mukunda@amd.com \
    --to=vijendar.mukunda@amd.com \
    --cc=Basavaraj.Hiregoudar@amd.com \
    --cc=Mario.Limonciello@amd.com \
    --cc=Poojitha.N@amd.com \
    --cc=Richard.Gong@amd.com \
    --cc=Sunil-kumar.Dommati@amd.com \
    --cc=Syed.SabaKareem@amd.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=sound-open-firmware@alsa-project.org \
    --cc=tiwai@suse.com \
    --cc=venkataprasad.potturu@amd.com \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®