From: Timo Joannin <timo.joannin@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
guojy.bj@gmail.com, error27@gmail.com,
Timo Joannin <timo.joannin@gmail.com>
Subject: [PATCH v6] staging: rtl8723bs: remove unused phy_stat struct and dead prototype
Date: Wed, 14 Oct 2026 15:21:07 +0200 [thread overview]
Message-ID: <20261014132107.171964-1-timo.joannin@gmail.com> (raw)
Commit d355fbb22519 ("staging: rtl8723bs: rename phy_status_rpt_8192cd_t
to rtl8723bs_phy_status_rpt.") renamed struct phy_status_rpt_8192cd_t
and propagated its type through the call chain.
Remove the remaining unused phy_stat struct in rtl8192c_recv.h along
with the dead function prototype rtl8723b_query_rx_phy_status() in
rtl8723b_recv.h which referenced it.
Signed-off-by: Timo Joannin <timo.joannin@gmail.com>
---
Note: While rebasing onto staging-testing as requested in v4, I noticed
that the struct rename and u8 * cast cleanup from v2/v3 were already
applied to staging-testing in commit d355fbb22519 ("staging: rtl8723bs:
rename phy_status_rpt_8192cd_t to rtl8723bs_phy_status_rpt.").
This v6 patch contains only the remaining change from v4/v5: removing
the unused phy_stat struct and dead prototype.
Changes in v6:
- Fixed build failure in v5 caused by leftover rebase conflict markers
in odm_HWConfig.c.
- Dropped patch 1/2 and the cast cleanup from patch 2/2 as they are
already in staging-testing.
- Updated subject and commit message to reflect only the remaining
phy_stat struct and dead prototype removal.
Changes in v5:
- Rebased against the latest staging/staging-testing branch.
- Resolved minor merge conflicts in odm_HWConfig.c.
Changes in v4:
- Split monolithic patch into 2-part series.
- Removed dead struct phy_stat and unused prototype
rtl8723b_query_rx_phy_status().
Changes in v3:
- Included patch version changelog (missed in v2, sorry).
Changes in v2:
- Propagated the real struct type through
the call chain to remove u8 * casting.
.../staging/rtl8723bs/include/rtl8192c_recv.h | 18 ------------------
.../staging/rtl8723bs/include/rtl8723b_recv.h | 1 -
2 files changed, 19 deletions(-)
diff --git a/drivers/staging/rtl8723bs/include/rtl8192c_recv.h b/drivers/staging/rtl8723bs/include/rtl8192c_recv.h
index b63625ab4e45..072e2b5f6129 100644
--- a/drivers/staging/rtl8723bs/include/rtl8192c_recv.h
+++ b/drivers/staging/rtl8723bs/include/rtl8192c_recv.h
@@ -9,24 +9,6 @@
#define MAX_RECVBUF_SZ (10240)
-struct phy_stat {
- unsigned int phydw0;
-
- unsigned int phydw1;
-
- unsigned int phydw2;
-
- unsigned int phydw3;
-
- unsigned int phydw4;
-
- unsigned int phydw5;
-
- unsigned int phydw6;
-
- unsigned int phydw7;
-};
-
/* Rx smooth factor */
#define Rx_Smooth_Factor (20)
diff --git a/drivers/staging/rtl8723bs/include/rtl8723b_recv.h b/drivers/staging/rtl8723bs/include/rtl8723b_recv.h
index e9ebecb224a6..2f230e2d27a4 100644
--- a/drivers/staging/rtl8723bs/include/rtl8723b_recv.h
+++ b/drivers/staging/rtl8723bs/include/rtl8723b_recv.h
@@ -84,7 +84,6 @@ struct rxreport_8723b {
s32 rtl8723bs_init_recv_priv(struct adapter *padapter);
void rtl8723bs_free_recv_priv(struct adapter *padapter);
-void rtl8723b_query_rx_phy_status(union recv_frame *prframe, struct phy_stat *pphy_stat);
void rtl8723b_process_phy_info(struct adapter *padapter, void *prframe);
void rtl8723b_read_chip_version(struct adapter *padapter);
--
2.56.0
reply other threads:[~2026-10-14 13:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261014132107.171964-1-timo.joannin@gmail.com \
--to=timo.joannin@gmail.com \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=guojy.bj@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®